diff mbox series

[v1,1/3] staging: media: ipu3: Drop superfluous check in imgu_vb2_stop_streaming()

Message ID 20240620145820.3910239-2-mstaudt@chromium.org
State New
Headers show
Series [v1,1/3] staging: media: ipu3: Drop superfluous check in imgu_vb2_stop_streaming() | expand

Commit Message

Max Staudt June 20, 2024, 2:45 p.m. UTC 
The check for imgu_all_nodes_streaming() seems superfluous, since
imgu->streaming can only become true once imgu_all_nodes_streaming()
has been true. Hence, checking for imgu->streaming == true should
imply imgu_all_nodes_streaming(), and therefore suffice.

Signed-off-by: Max Staudt <mstaudt@chromium.org>
---
 drivers/staging/media/ipu3/ipu3-v4l2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/drivers/staging/media/ipu3/ipu3-v4l2.c b/drivers/staging/media/ipu3/ipu3-v4l2.c
index 3df58eb3e882..541556037c42 100644
--- a/drivers/staging/media/ipu3/ipu3-v4l2.c
+++ b/drivers/staging/media/ipu3/ipu3-v4l2.c
@@ -548,7 +548,7 @@  static void imgu_vb2_stop_streaming(struct vb2_queue *vq)
 
 	mutex_lock(&imgu->streaming_lock);
 	/* Was this the first node with streaming disabled? */
-	if (imgu->streaming && imgu_all_nodes_streaming(imgu, node)) {
+	if (imgu->streaming) {
 		/* Yes, really stop streaming now */
 		dev_dbg(dev, "IMGU streaming is ready to stop");
 		r = imgu_s_stream(imgu, false);