diff mbox series

[RESEND] hid: bpf: Fix grammar

Message ID 20240625105553.50830-1-luis.hernandez093@gmail.com
State New
Headers show
Series [RESEND] hid: bpf: Fix grammar | expand

Commit Message

Luis Felipe Hernandez June 25, 2024, 10:55 a.m. UTC
* spelling fix: XBox -> Xbox, lowercase 'b' as per Microsoft branding
* rephrase: paddle -> paddles, the controller itself has more than one paddle
* rephrase: replace usage of "those" in favor of explicitly making reference
  to the paddles
* grammatical fix: report -> reports, use present tense verb. 
* spelling fix: interpret
* consistency: capitalize the first word in bullet points

Signed-off-by: Luis Felipe Hernandez <luis.hernandez093@gmail.com>
---
 .../hid/bpf/progs/Microsoft__XBox-Elite-2.bpf.c   | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

Comments

Benjamin Tissoires June 27, 2024, 7:25 a.m. UTC | #1
On Tue, 25 Jun 2024 06:55:51 -0400, Luis Felipe Hernandez wrote:
> * spelling fix: XBox -> Xbox, lowercase 'b' as per Microsoft branding
> * rephrase: paddle -> paddles, the controller itself has more than one paddle
> * rephrase: replace usage of "those" in favor of explicitly making reference
>   to the paddles
> * grammatical fix: report -> reports, use present tense verb.
> * spelling fix: interpret
> * consistency: capitalize the first word in bullet points
> 
> [...]

Applied to hid/hid.git (for-6.11/bpf), thanks!

[1/1] hid: bpf: Fix grammar
      https://git.kernel.org/hid/hid/c/9e16bada9299

Cheers,
diff mbox series

Patch

diff --git a/drivers/hid/bpf/progs/Microsoft__XBox-Elite-2.bpf.c b/drivers/hid/bpf/progs/Microsoft__XBox-Elite-2.bpf.c
index c04abecab8ee..858cf20ebe2c 100644
--- a/drivers/hid/bpf/progs/Microsoft__XBox-Elite-2.bpf.c
+++ b/drivers/hid/bpf/progs/Microsoft__XBox-Elite-2.bpf.c
@@ -15,20 +15,19 @@  HID_BPF_CONFIG(
 );
 
 /*
- * When using the XBox Wireless Controller Elite 2 over Bluetooth,
- * the device exports the paddle on the back of the device as a single
+ * When using the Xbox Wireless Controller Elite 2 over Bluetooth,
+ * the device exports the paddles on the back of the device as a single
  * bitfield value of usage "Assign Selection".
  *
- * The kernel doesn't process those usages properly and report KEY_UNKNOWN
- * for it.
+ * The kernel doesn't process the paddles usage properly and reports KEY_UNKNOWN.
  *
- * SDL doesn't know how to interprete that KEY_UNKNOWN and thus ignores the paddles.
+ * SDL doesn't know how to interpret KEY_UNKNOWN and thus ignores the paddles.
  *
  * Given that over USB the kernel uses BTN_TRIGGER_HAPPY[5-8], we
- * can tweak the report descriptor to make the kernel interprete it properly:
- * - we need an application collection of gamepad (so we have to close the current
+ * can tweak the report descriptor to make the kernel interpret it properly:
+ * - We need an application collection of gamepad (so we have to close the current
  *   Consumer Control one)
- * - we need to change the usage to be buttons from 0x15 to 0x18
+ * - We need to change the usage to be buttons from 0x15 to 0x18
  */
 
 #define OFFSET_ASSIGN_SELECTION		211