From patchwork Fri Nov 4 14:00:12 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Clifton X-Patchwork-Id: 80865 Delivered-To: patch@linaro.org Received: by 10.80.170.210 with SMTP id r18csp1154575edc; Fri, 4 Nov 2016 07:01:01 -0700 (PDT) X-Received: by 10.98.98.68 with SMTP id w65mr26813777pfb.121.1478268060942; Fri, 04 Nov 2016 07:01:00 -0700 (PDT) Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id q199si16688464pgq.205.2016.11.04.07.01.00 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 Nov 2016 07:01:00 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-return-94343-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org; spf=pass (google.com: domain of binutils-return-94343-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=binutils-return-94343-patch=linaro.org@sourceware.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type; q=dns; s=default; b=FwY+ AnIOsMfdkh9dXfRufEkIPTtmi3h4tvBGUwyJ1gEbDlO1kax0G1GptB8jS5UIvcy3 EEEjLpHhx/WKyhIAlUTl3mthW2gg9MSjlbHO2OYeL3MCrgRAdEkJd43CplNC7xXB OcmYIWM+dXF4yZ786xtnsI3ul173RfZzLVJdA84= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type; s=default; bh=06el50RhGg if92OjbiNTjUZB94c=; b=S6A4qEmqQn0wg2Fc1nB3aj03a7vtRlZuj8ZrrHEFDO Vhq4l9hkdqrNINR1cx/S5UPnNimbTserpoc1xfogOQ31PAkTnpIM69J2AectGfBJ q+S0TKKXCjYzX0REZoU14Unu3NWPtGQcO7VGGr7RlN+Xu42WP3Nwz6bsZtuScxl5 s= Received: (qmail 95650 invoked by alias); 4 Nov 2016 14:00:37 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Delivered-To: mailing list binutils@sourceware.org Received: (qmail 92256 invoked by uid 89); 4 Nov 2016 14:00:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=involves, limitsh, waitpid, *path X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 04 Nov 2016 14:00:16 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7C2A5C0567A2 for ; Fri, 4 Nov 2016 14:00:14 +0000 (UTC) Received: from [10.36.6.60] (vpn1-6-60.ams2.redhat.com [10.36.6.60]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uA4E0ChP005231 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 4 Nov 2016 10:00:13 -0400 Subject: Re: ld build configured with additional targets is broken To: binutils@sourceware.org References: <3fc5685b-c191-7b90-acbe-69c509d7e74c@ubuntu.com> <1e8d014f-b1d5-145a-1c53-10fc0954cb9a@redhat.com> <6aedc4f3-e5c2-e4d0-05b8-0050c16f75df@redhat.com> From: Nick Clifton Message-ID: <3ad439df-1c09-c2c0-2b7c-ed2f95bccabe@redhat.com> Date: Fri, 4 Nov 2016 14:00:12 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <6aedc4f3-e5c2-e4d0-05b8-0050c16f75df@redhat.com> X-IsSubscribed: yes Hi Guys, OK - I have checked in a patch to remove support for $PLATFORM in rpath search strings. This seems to be the safest thing to do, as I was never sure that the support would actually be correct anyway. Cheers Nick ld/ChangeLog 2016-11-04 Nick Clifton * emultempl/elf32.em (search_needed): Remove use of getauxval and inclusion of . Replace support for $PLATFORM with a warning message. * configure.ac (AC_CHECK_FUNCS): Remove getauxval. * configure: Regenerate. * config.in: Regenerate. diff --git a/ld/config.in b/ld/config.in index 5c614ed..2c6d698 100644 --- a/ld/config.in +++ b/ld/config.in @@ -62,9 +62,6 @@ /* Define to 1 if you have the header file. */ #undef HAVE_FCNTL_H -/* Define to 1 if you have the `getauxval' function. */ -#undef HAVE_GETAUXVAL - /* Define to 1 if you have the `getpagesize' function. */ #undef HAVE_GETPAGESIZE diff --git a/ld/configure b/ld/configure index 2c55b28..3f82f35 100755 --- a/ld/configure +++ b/ld/configure @@ -16488,7 +16488,7 @@ _ACEOF fi done -for ac_func in getauxval open lseek close +for ac_func in open lseek close do : as_ac_var=`$as_echo "ac_cv_func_$ac_func" | $as_tr_sh` ac_fn_c_check_func "$LINENO" "$ac_func" "$as_ac_var" diff --git a/ld/configure.ac b/ld/configure.ac index 4542845..d17281f 100644 --- a/ld/configure.ac +++ b/ld/configure.ac @@ -216,7 +216,7 @@ AC_CHECK_HEADERS(string.h strings.h stdlib.h unistd.h elf-hints.h limits.h local AC_CHECK_HEADERS(fcntl.h sys/file.h sys/time.h sys/stat.h) ACX_HEADER_STRING AC_CHECK_FUNCS(glob mkstemp realpath sbrk setlocale waitpid) -AC_CHECK_FUNCS(getauxval open lseek close) +AC_CHECK_FUNCS(open lseek close) AC_HEADER_DIRENT dnl AC_CHECK_HEADERS(sys/mman.h) diff --git a/ld/emultempl/elf32.em b/ld/emultempl/elf32.em index 06f02c6..57252da 100644 --- a/ld/emultempl/elf32.em +++ b/ld/emultempl/elf32.em @@ -472,16 +472,6 @@ fragment < -#endif -EOF -fi -fragment < header file which loads the + system header file, which conflicts with the + "include/elf/mips.h" header file. */ + replacement = NULL; } break; @@ -665,7 +642,7 @@ fragment < token might be a legitimate component of a path name in the target's file system. */ - info_msg (_("unrecognised token '%s' in search path\n"), var); + info_msg (_("unrecognised or unsupported token '%s' in search path\n"), var); if (end) /* Restore the path separator. */