| Message ID | 20240704-mfd-const-regmap_config-v2-6-0c8785b1331d@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | mfd: Constify read-only regmap structs | expand |
On 7/4/24 20:23, Javier Carrasco wrote: > `bd957x_regmap`, `bd9576_irqs` and `bd9576_irq_chip` are not modified > and can be declared as const to move its data to a read-only section. > > Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com> Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com> Thanks! Much appreciated. > --- > drivers/mfd/rohm-bd9576.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/mfd/rohm-bd9576.c b/drivers/mfd/rohm-bd9576.c > index 3a9f61961721..17323ae39803 100644 > --- a/drivers/mfd/rohm-bd9576.c > +++ b/drivers/mfd/rohm-bd9576.c > @@ -57,7 +57,7 @@ static const struct regmap_access_table volatile_regs = { > .n_yes_ranges = ARRAY_SIZE(volatile_ranges), > }; > > -static struct regmap_config bd957x_regmap = { > +static const struct regmap_config bd957x_regmap = { > .reg_bits = 8, > .val_bits = 8, > .volatile_table = &volatile_regs, > @@ -65,7 +65,7 @@ static struct regmap_config bd957x_regmap = { > .cache_type = REGCACHE_MAPLE, > }; > > -static struct regmap_irq bd9576_irqs[] = { > +static const struct regmap_irq bd9576_irqs[] = { > REGMAP_IRQ_REG(BD9576_INT_THERM, 0, BD957X_MASK_INT_MAIN_THERM), > REGMAP_IRQ_REG(BD9576_INT_OVP, 0, BD957X_MASK_INT_MAIN_OVP), > REGMAP_IRQ_REG(BD9576_INT_SCP, 0, BD957X_MASK_INT_MAIN_SCP), > @@ -76,7 +76,7 @@ static struct regmap_irq bd9576_irqs[] = { > REGMAP_IRQ_REG(BD9576_INT_SYS, 0, BD957X_MASK_INT_MAIN_SYS), > }; > > -static struct regmap_irq_chip bd9576_irq_chip = { > +static const struct regmap_irq_chip bd9576_irq_chip = { > .name = "bd9576_irq", > .irqs = &bd9576_irqs[0], > .num_irqs = ARRAY_SIZE(bd9576_irqs), >
diff --git a/drivers/mfd/rohm-bd9576.c b/drivers/mfd/rohm-bd9576.c index 3a9f61961721..17323ae39803 100644 --- a/drivers/mfd/rohm-bd9576.c +++ b/drivers/mfd/rohm-bd9576.c @@ -57,7 +57,7 @@ static const struct regmap_access_table volatile_regs = { .n_yes_ranges = ARRAY_SIZE(volatile_ranges), }; -static struct regmap_config bd957x_regmap = { +static const struct regmap_config bd957x_regmap = { .reg_bits = 8, .val_bits = 8, .volatile_table = &volatile_regs, @@ -65,7 +65,7 @@ static struct regmap_config bd957x_regmap = { .cache_type = REGCACHE_MAPLE, }; -static struct regmap_irq bd9576_irqs[] = { +static const struct regmap_irq bd9576_irqs[] = { REGMAP_IRQ_REG(BD9576_INT_THERM, 0, BD957X_MASK_INT_MAIN_THERM), REGMAP_IRQ_REG(BD9576_INT_OVP, 0, BD957X_MASK_INT_MAIN_OVP), REGMAP_IRQ_REG(BD9576_INT_SCP, 0, BD957X_MASK_INT_MAIN_SCP), @@ -76,7 +76,7 @@ static struct regmap_irq bd9576_irqs[] = { REGMAP_IRQ_REG(BD9576_INT_SYS, 0, BD957X_MASK_INT_MAIN_SYS), }; -static struct regmap_irq_chip bd9576_irq_chip = { +static const struct regmap_irq_chip bd9576_irq_chip = { .name = "bd9576_irq", .irqs = &bd9576_irqs[0], .num_irqs = ARRAY_SIZE(bd9576_irqs),
`bd957x_regmap`, `bd9576_irqs` and `bd9576_irq_chip` are not modified and can be declared as const to move its data to a read-only section. Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com> --- drivers/mfd/rohm-bd9576.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)