[v5,4/4] usb: musb: da8xx: Set phy in OTG mode by default

Message ID 1478523908-4383-5-git-send-email-abailon@baylibre.com
State New
Headers show

Commit Message

Alexandre Bailon Nov. 7, 2016, 1:05 p.m.
The DA8xx OTG PHY has some issues when it is forced in host or
peripheral mode. Actually, most of the time, OTG is the best mode
because host or peripheral mode are only required for hardware that
miss some circuitry.
Init the PHY mode OTG mode by default.

Signed-off-by: Alexandre Bailon <abailon@baylibre.com>

 drivers/usb/musb/da8xx.c | 7 +++++++
 1 file changed, 7 insertions(+)



diff --git a/drivers/usb/musb/da8xx.c b/drivers/usb/musb/da8xx.c
index ac0c2f7..a7e7abe 100644
--- a/drivers/usb/musb/da8xx.c
+++ b/drivers/usb/musb/da8xx.c
@@ -340,6 +340,13 @@  static int da8xx_musb_set_mode(struct musb *musb, u8 musb_mode, bool init)
 	struct da8xx_glue *glue = dev_get_drvdata(musb->controller->parent);
 	enum phy_mode phy_mode;
+	/*
+	 * The PHY has some issues when it is forced in device or host mode.
+	 * Unless the user request another mode, configure the PHY in OTG mode.
+	 */
+	if (init)
+		return phy_set_mode(glue->phy, PHY_MODE_USB_OTG);
 	switch (musb_mode) {
 	case MUSB_HOST:		/* Force VBUS valid, ID = 0 */
 		phy_mode = PHY_MODE_USB_HOST;