| Message ID | 20240713015145.314-1-shenghao-ding@ti.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v1,1/2] ASoc: tas2781: Add TAS2563 into the Header | expand |
On Sat, Jul 13, 2024 at 09:51:41AM +0800, Shenghao Ding wrote: > Add TAS2563 into the Header in case of misunderstanding. > @@ -64,8 +64,8 @@ static int tasdevice_change_chn_book(struct tasdevice_priv *tas_priv, > */ > ret = regmap_write(map, TASDEVICE_PAGE_SELECT, 0); > if (ret < 0) { > - dev_err(tas_priv->dev, "%s, E=%d\n", > - __func__, ret); > + dev_err(tas_priv->dev, "%s, E=%d channel:%d\n", > + __func__, ret, chn); > goto out; > } This is reasonable enough but doesn't match the changelog.
On Sat, Jul 13, 2024 at 09:51:42AM +0800, Shenghao Ding wrote: > Rename dai_driver name to unify the name between TAS2563 and > TAS2781, remove unnecessary line feed, strscpy replace scnprintf. This should be split into several changes, the name unification, the linefeed cleanup and the scnprintf() replacement don't seem to overlap at all. > Signed-off-by: Shenghao Ding <shenghao-ding@ti.com> > > v1: > - Use strscpy to replace scnprintf. > - rename dai_driver name from "tas2781_codec" to "tasdev_codec" > - Remove unnecessary line feed for tasdevice_dsp_create_ctrls > --- These changelogs should come after the --- so that tools can cut them out when applying.
diff --git a/sound/soc/codecs/tas2781-comlib.c b/sound/soc/codecs/tas2781-comlib.c index 1fbf4560f5cc..58abbc098a91 100644 --- a/sound/soc/codecs/tas2781-comlib.c +++ b/sound/soc/codecs/tas2781-comlib.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 // -// TAS2781 Common functions for HDA and ASoC Audio drivers +// TAS2563/TAS2781 Common functions for HDA and ASoC Audio drivers // // Copyright 2023 - 2024 Texas Instruments, Inc. // @@ -64,8 +64,8 @@ static int tasdevice_change_chn_book(struct tasdevice_priv *tas_priv, */ ret = regmap_write(map, TASDEVICE_PAGE_SELECT, 0); if (ret < 0) { - dev_err(tas_priv->dev, "%s, E=%d\n", - __func__, ret); + dev_err(tas_priv->dev, "%s, E=%d channel:%d\n", + __func__, ret, chn); goto out; } }
Add TAS2563 into the Header in case of misunderstanding. Signed-off-by: Shenghao Ding <shenghao-ding@ti.com> --- v1: - Add TAS2563 into the Header - Add channel no into the log for error debug --- sound/soc/codecs/tas2781-comlib.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)