[GIT,PULL,drm-next] drm/mali-dp fixes and updates

Message ID 20161108122619.GA10219@e106497-lin.cambridge.arm.com
State New
Headers show

Pull-request

git://linux-arm.org/linux-ld.git for-upstream/mali-dp

Message

Liviu Dudau Nov. 8, 2016, 12:26 p.m.
Hi Dave,

Here is the list of fixes that I have for drm/mali-dp. They've been on the mailing
lists for a while and merged into linux-next for a few weeks, but due to holiday and
travel to Linux Plumbers I did not send the pull request earlier. I don't know if
these patches can be pulled into v4.9 still (they will conflict with Ville Syrjälä's
cleanup of DRM_ROTATE series that is already in drm-next), but if you do that would
be great.

The following changes since commit fb422950c6cd726fd36eb72a7cf84583440a18a2:

  Merge branch 'linux-4.9' of git://github.com/skeggsb/linux into drm-next (2016-10-28 14:24:56 +1000)

are available in the git repository at:

  git://linux-arm.org/linux-ld.git for-upstream/mali-dp

for you to fetch changes up to e64053f05eb924db45f90a1556a200d1acb4b01e:

  drm: mali-dp: Clear CVAL when leaving config mode (2016-11-08 11:40:02 +0000)

----------------------------------------------------------------
Baoyou Xie (1):
      drm/arm: mark symbols static where possible

Brian Starkey (8):
      drm: mali-dp: Add pitch alignment check function
      drm: mali-dp: Add pitch alignment check for planes
      arm: mali-dp: Extract mode_config cleanup into malidp_fini
      drm: mali-dp: Refactor plane initialisation
      drm: mali-dp: Enable alpha blending
      drm: mali-dp: Store internal format and n_planes in plane state
      drm: mali-dp: Don't set DRM_PLANE_COMMIT_ACTIVE_ONLY
      drm: mali-dp: Clear CVAL when leaving config mode

Liviu Dudau (3):
      drm: mali-dp: Clear the config_valid flag before using it in wait_event.
      drm: mali-dp: Set the drm->irq_enabled flag to match driver's state.
      drm: mali-dp: Add support for setting plane's rotation property from userspace.

 drivers/gpu/drm/arm/malidp_drv.c    | 19 +++++---
 drivers/gpu/drm/arm/malidp_drv.h    |  3 ++
 drivers/gpu/drm/arm/malidp_hw.c     |  5 ++
 drivers/gpu/drm/arm/malidp_hw.h     |  9 ++++
 drivers/gpu/drm/arm/malidp_planes.c | 96 ++++++++++++++++++++++++-------------
 5 files changed, 92 insertions(+), 40 deletions(-)


Many thanks,
Liviu

Comments

Daniel Vetter Nov. 8, 2016, 12:49 p.m. | #1
On Tue, Nov 08, 2016 at 12:26:19PM +0000, Liviu Dudau wrote:
> Hi Dave,
> 
> Here is the list of fixes that I have for drm/mali-dp. They've been on the mailing
> lists for a while and merged into linux-next for a few weeks, but due to holiday and
> travel to Linux Plumbers I did not send the pull request earlier. I don't know if
> these patches can be pulled into v4.9 still (they will conflict with Ville Syrjälä's
> cleanup of DRM_ROTATE series that is already in drm-next), but if you do that would
> be great.
> 
> The following changes since commit fb422950c6cd726fd36eb72a7cf84583440a18a2:
> 
>   Merge branch 'linux-4.9' of git://github.com/skeggsb/linux into drm-next (2016-10-28 14:24:56 +1000)
> 
> are available in the git repository at:
> 
>   git://linux-arm.org/linux-ld.git for-upstream/mali-dp
> 
> for you to fetch changes up to e64053f05eb924db45f90a1556a200d1acb4b01e:
> 
>   drm: mali-dp: Clear CVAL when leaving config mode (2016-11-08 11:40:02 +0000)
> 
> ----------------------------------------------------------------
> Baoyou Xie (1):
>       drm/arm: mark symbols static where possible
> 
> Brian Starkey (8):
>       drm: mali-dp: Add pitch alignment check function
>       drm: mali-dp: Add pitch alignment check for planes
>       arm: mali-dp: Extract mode_config cleanup into malidp_fini
>       drm: mali-dp: Refactor plane initialisation
>       drm: mali-dp: Enable alpha blending
>       drm: mali-dp: Store internal format and n_planes in plane state
>       drm: mali-dp: Don't set DRM_PLANE_COMMIT_ACTIVE_ONLY
>       drm: mali-dp: Clear CVAL when leaving config mode
> 
> Liviu Dudau (3):
>       drm: mali-dp: Clear the config_valid flag before using it in wait_event.
>       drm: mali-dp: Set the drm->irq_enabled flag to match driver's state.
>       drm: mali-dp: Add support for setting plane's rotation property from userspace.

Quick check says these patches haven't shown on up a mailing list. Please
submit first, do review in public and then send the pull request. There's
generally a lot of cross-driver learning possible with this kind of stuff.
Imo splitting drivers into their own mailing list and community only makes
sense once there's just too much traffic, like with the big ones (intel,
amd and nouveau because it's developed in userspace entirely).

Thanks, Daniel
> 
>  drivers/gpu/drm/arm/malidp_drv.c    | 19 +++++---
>  drivers/gpu/drm/arm/malidp_drv.h    |  3 ++
>  drivers/gpu/drm/arm/malidp_hw.c     |  5 ++
>  drivers/gpu/drm/arm/malidp_hw.h     |  9 ++++
>  drivers/gpu/drm/arm/malidp_planes.c | 96 ++++++++++++++++++++++++-------------
>  5 files changed, 92 insertions(+), 40 deletions(-)
> 
> 
> Many thanks,
> Liviu
> 
> -- 
> ====================
> | I would like to |
> | fix the world,  |
> | but they're not |
> | giving me the   |
>  \ source code!  /
>   ---------------
>     ¯\_(ツ)_/¯
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Liviu Dudau Nov. 8, 2016, 1:41 p.m. | #2
On Tue, Nov 08, 2016 at 01:49:55PM +0100, Daniel Vetter wrote:
> On Tue, Nov 08, 2016 at 12:26:19PM +0000, Liviu Dudau wrote:
> > Hi Dave,
> > 
> > Here is the list of fixes that I have for drm/mali-dp. They've been on the mailing
> > lists for a while and merged into linux-next for a few weeks, but due to holiday and
> > travel to Linux Plumbers I did not send the pull request earlier. I don't know if
> > these patches can be pulled into v4.9 still (they will conflict with Ville Syrjälä's
> > cleanup of DRM_ROTATE series that is already in drm-next), but if you do that would
> > be great.
> > 
> > The following changes since commit fb422950c6cd726fd36eb72a7cf84583440a18a2:
> > 
> >   Merge branch 'linux-4.9' of git://github.com/skeggsb/linux into drm-next (2016-10-28 14:24:56 +1000)
> > 
> > are available in the git repository at:
> > 
> >   git://linux-arm.org/linux-ld.git for-upstream/mali-dp
> > 
> > for you to fetch changes up to e64053f05eb924db45f90a1556a200d1acb4b01e:
> > 
> >   drm: mali-dp: Clear CVAL when leaving config mode (2016-11-08 11:40:02 +0000)
> > 
> > ----------------------------------------------------------------
> > Baoyou Xie (1):
> >       drm/arm: mark symbols static where possible
> > 
> > Brian Starkey (8):
> >       drm: mali-dp: Add pitch alignment check function
> >       drm: mali-dp: Add pitch alignment check for planes
> >       arm: mali-dp: Extract mode_config cleanup into malidp_fini
> >       drm: mali-dp: Refactor plane initialisation
> >       drm: mali-dp: Enable alpha blending
> >       drm: mali-dp: Store internal format and n_planes in plane state
> >       drm: mali-dp: Don't set DRM_PLANE_COMMIT_ACTIVE_ONLY
> >       drm: mali-dp: Clear CVAL when leaving config mode
> > 
> > Liviu Dudau (3):
> >       drm: mali-dp: Clear the config_valid flag before using it in wait_event.
> >       drm: mali-dp: Set the drm->irq_enabled flag to match driver's state.
> >       drm: mali-dp: Add support for setting plane's rotation property from userspace.
> 
> Quick check says these patches haven't shown on up a mailing list. Please
> submit first, do review in public and then send the pull request. There's
> generally a lot of cross-driver learning possible with this kind of stuff.
> Imo splitting drivers into their own mailing list and community only makes
> sense once there's just too much traffic, like with the big ones (intel,
> amd and nouveau because it's developed in userspace entirely).

Actually, all except the last patch from me and last from Brian have been on the
dri-devel mailing list, I believe you have even commented on one of them (drm->irq_enabled).

For my patches, first two start here [1]. For Brian's patches, his series
starts here [2] (also contains my patches) and one before last is here [3]

[1] https://lists.freedesktop.org/archives/dri-devel/2016-July/114302.html
[2] https://lists.freedesktop.org/archives/dri-devel/2016-October/120486.html
[3] https://lists.freedesktop.org/archives/dri-devel/2016-October/121849.html

I appologise for missing to send the last two patches, they were in the public tree
but did not sent them for some reason to the public list. Will do that now.

Best regards,
Liviu

> 
> Thanks, Daniel
> > 
> >  drivers/gpu/drm/arm/malidp_drv.c    | 19 +++++---
> >  drivers/gpu/drm/arm/malidp_drv.h    |  3 ++
> >  drivers/gpu/drm/arm/malidp_hw.c     |  5 ++
> >  drivers/gpu/drm/arm/malidp_hw.h     |  9 ++++
> >  drivers/gpu/drm/arm/malidp_planes.c | 96 ++++++++++++++++++++++++-------------
> >  5 files changed, 92 insertions(+), 40 deletions(-)
> > 
> > 
> > Many thanks,
> > Liviu
> > 
> > -- 
> > ====================
> > | I would like to |
> > | fix the world,  |
> > | but they're not |
> > | giving me the   |
> >  \ source code!  /
> >   ---------------
> >     ¯\_(ツ)_/¯
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
Daniel Vetter Nov. 8, 2016, 4:13 p.m. | #3
On Tue, Nov 08, 2016 at 01:41:08PM +0000, Liviu Dudau wrote:
> On Tue, Nov 08, 2016 at 01:49:55PM +0100, Daniel Vetter wrote:
> > On Tue, Nov 08, 2016 at 12:26:19PM +0000, Liviu Dudau wrote:
> > > Hi Dave,
> > > 
> > > Here is the list of fixes that I have for drm/mali-dp. They've been on the mailing
> > > lists for a while and merged into linux-next for a few weeks, but due to holiday and
> > > travel to Linux Plumbers I did not send the pull request earlier. I don't know if
> > > these patches can be pulled into v4.9 still (they will conflict with Ville Syrjälä's
> > > cleanup of DRM_ROTATE series that is already in drm-next), but if you do that would
> > > be great.
> > > 
> > > The following changes since commit fb422950c6cd726fd36eb72a7cf84583440a18a2:
> > > 
> > >   Merge branch 'linux-4.9' of git://github.com/skeggsb/linux into drm-next (2016-10-28 14:24:56 +1000)
> > > 
> > > are available in the git repository at:
> > > 
> > >   git://linux-arm.org/linux-ld.git for-upstream/mali-dp
> > > 
> > > for you to fetch changes up to e64053f05eb924db45f90a1556a200d1acb4b01e:
> > > 
> > >   drm: mali-dp: Clear CVAL when leaving config mode (2016-11-08 11:40:02 +0000)
> > > 
> > > ----------------------------------------------------------------
> > > Baoyou Xie (1):
> > >       drm/arm: mark symbols static where possible
> > > 
> > > Brian Starkey (8):
> > >       drm: mali-dp: Add pitch alignment check function
> > >       drm: mali-dp: Add pitch alignment check for planes
> > >       arm: mali-dp: Extract mode_config cleanup into malidp_fini
> > >       drm: mali-dp: Refactor plane initialisation
> > >       drm: mali-dp: Enable alpha blending
> > >       drm: mali-dp: Store internal format and n_planes in plane state
> > >       drm: mali-dp: Don't set DRM_PLANE_COMMIT_ACTIVE_ONLY
> > >       drm: mali-dp: Clear CVAL when leaving config mode
> > > 
> > > Liviu Dudau (3):
> > >       drm: mali-dp: Clear the config_valid flag before using it in wait_event.
> > >       drm: mali-dp: Set the drm->irq_enabled flag to match driver's state.
> > >       drm: mali-dp: Add support for setting plane's rotation property from userspace.
> > 
> > Quick check says these patches haven't shown on up a mailing list. Please
> > submit first, do review in public and then send the pull request. There's
> > generally a lot of cross-driver learning possible with this kind of stuff.
> > Imo splitting drivers into their own mailing list and community only makes
> > sense once there's just too much traffic, like with the big ones (intel,
> > amd and nouveau because it's developed in userspace entirely).
> 
> Actually, all except the last patch from me and last from Brian have been on the
> dri-devel mailing list, I believe you have even commented on one of them (drm->irq_enabled).

Hm indeed, my search-fu was seriously failing me.

> For my patches, first two start here [1]. For Brian's patches, his series
> starts here [2] (also contains my patches) and one before last is here [3]
> 
> [1] https://lists.freedesktop.org/archives/dri-devel/2016-July/114302.html
> [2] https://lists.freedesktop.org/archives/dri-devel/2016-October/120486.html
> [3] https://lists.freedesktop.org/archives/dri-devel/2016-October/121849.html
> 
> I appologise for missing to send the last two patches, they were in the public tree
> but did not sent them for some reason to the public list. Will do that now.

Thanks, and apologies anyway.
-Daniel