From patchwork Wed Nov 9 04:35:24 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 81435 Delivered-To: patch@linaro.org Received: by 10.140.97.165 with SMTP id m34csp16767qge; Tue, 8 Nov 2016 20:34:57 -0800 (PST) X-Received: by 10.99.137.66 with SMTP id v63mr23957084pgd.117.1478666097779; Tue, 08 Nov 2016 20:34:57 -0800 (PST) Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org. [2001:1868:205::9]) by mx.google.com with ESMTPS id x70si40071601pfj.101.2016.11.08.20.34.57 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Nov 2016 20:34:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2001:1868:205::9 as permitted sender) client-ip=2001:1868:205::9; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@nifty.com; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2001:1868:205::9 as permitted sender) smtp.mailfrom=linux-mtd-bounces+patch=linaro.org@lists.infradead.org Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1c4Kb4-0002PS-T0; Wed, 09 Nov 2016 04:34:50 +0000 Received: from conuserg-09.nifty.com ([210.131.2.76]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1c4Ka1-00021g-5i for linux-mtd@lists.infradead.org; Wed, 09 Nov 2016 04:33:49 +0000 Received: from beagle.diag.org (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-09.nifty.com with ESMTP id uA94WsgG025515; Wed, 9 Nov 2016 13:33:00 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-09.nifty.com uA94WsgG025515 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1478665981; bh=R2M1kwv2EY04pqaAC1EF1wXfqcAaRFQ1roQTjuPlcf4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ImXtzsHxZuq4gO5KJG9Ip8j3/g1/xFIhGW103jQ93geX74+cyAYKig7oDCWuE/SQa 7l3LaAjYUSowVbDI9+cnDxKBed7zG5wyL7/yWEYxbsSRArdewcCI07OaIx+cw/he+j Y116C74OD6N5HegER5wW9rIyVaSV1QQFiuzwz1KFCf6b//iEyg2dv2Fs5yllU5/azF tztrUYa1W35NuUYNV79aJiJ43u89vkCXH4PvlVyc7WBICt5MYgrqdqsBjeP4Z6/48Q AFKf7XhO+JOus9xZLmey6X7C7Zvps4DQ6Y/BYfOttD8NgOWb2UnH8bVNYIyN1mOr5T ZLuZMgzFtnL5A== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-mtd@lists.infradead.org Subject: [PATCH 05/11] mtd: nand: denali: remove "Spectra:" prefix from printk strings Date: Wed, 9 Nov 2016 13:35:24 +0900 Message-Id: <1478666130-13413-6-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1478666130-13413-1-git-send-email-yamada.masahiro@socionext.com> References: <1478666130-13413-1-git-send-email-yamada.masahiro@socionext.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20161108_203345_713437_412B4C24 X-CRM114-Status: GOOD ( 11.83 ) X-Spam-Score: 1.5 (+) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (1.5 points) pts rule name description ---- ---------------------- -------------------------------------------------- 2.7 RCVD_IN_PSBL RBL: Received via a relay in PSBL [210.131.2.76 listed in psbl.surriel.com] 0.0 RCVD_IN_MSPIKE_L4 RBL: Bad reputation (-4) [210.131.2.76 listed in bl.mailspike.net] 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid 0.0 RCVD_IN_MSPIKE_BL Mailspike blacklisted X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Boris Brezillon , David Woodhouse , Marek Vasut , Richard Weinberger , Jason Roberts , linux-kernel@vger.kernel.org, Masahiro Yamada , Chuanxiao Dong , Cyrille Pitchen , Brian Norris , David Woodhouse , Dinh Nguyen , Alan Cox MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+patch=linaro.org@lists.infradead.org As far as I understood from the Kconfig menu deleted by commit be7f39c5ecf5 ("Staging: delete spectra driver"), the "Spectra" is specific to Intel Moorestown Platform. The Denali NAND controller IP is used for various SoCs such as Altera SOCFPGA, Socionext UniPhier, etc. The platform specific strings are not preferred in this driver. Signed-off-by: Masahiro Yamada --- As an ARM-SoC developer, I only need denali.c and denali_dt.c. I see some "Spectra:" in drivers/mtd/nand/denali_pci.c as well. I was not quite sure if they are needed or not. If desired, I can update this patch to remove them too. drivers/mtd/nand/denali.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) -- 1.9.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c index 80d3e26..78d795b 100644 --- a/drivers/mtd/nand/denali.c +++ b/drivers/mtd/nand/denali.c @@ -402,7 +402,7 @@ static void get_hynix_nand_para(struct denali_nand_info *denali, break; default: dev_warn(denali->dev, - "Spectra: Unknown Hynix NAND (Device ID: 0x%x).\n" + "Unknown Hynix NAND (Device ID: 0x%x).\n" "Will use default parameter values instead.\n", device_id); } @@ -1458,7 +1458,7 @@ int denali_init(struct denali_nand_info *denali) */ if (request_irq(denali->irq, denali_isr, IRQF_SHARED, DENALI_NAND_NAME, denali)) { - pr_err("Spectra: Unable to allocate IRQ\n"); + dev_err(denali->dev, "Unable to request IRQ\n"); return -ENODEV; } @@ -1495,7 +1495,7 @@ int denali_init(struct denali_nand_info *denali) /* Is 32-bit DMA supported? */ ret = dma_set_mask(denali->dev, DMA_BIT_MASK(32)); if (ret) { - pr_err("Spectra: no usable DMA configuration\n"); + dev_err(denali->dev, "no usable DMA configuration\n"); goto failed_req_irq; } @@ -1503,7 +1503,7 @@ int denali_init(struct denali_nand_info *denali) mtd->writesize + mtd->oobsize, DMA_BIDIRECTIONAL); if (dma_mapping_error(denali->dev, denali->buf.dma_buf)) { - dev_err(denali->dev, "Spectra: failed to map DMA buffer\n"); + dev_err(denali->dev, "failed to map DMA buffer\n"); ret = -EIO; goto failed_req_irq; } @@ -1598,8 +1598,7 @@ int denali_init(struct denali_nand_info *denali) ret = mtd_device_register(mtd, NULL, 0); if (ret) { - dev_err(denali->dev, "Spectra: Failed to register MTD: %d\n", - ret); + dev_err(denali->dev, "Failed to register MTD: %d\n", ret); goto failed_req_irq; } return 0;