[Linaro-uefi,16/27] D03/OemMiscLib: Add interface for SAS driver

Message ID 1478785950-24197-17-git-send-email-heyi.guo@linaro.org
State New
Headers show

Commit Message

gary guo Nov. 10, 2016, 1:52 p.m.
Add OemIsNeedDisableExpanderBuffer() interface for SAS driver.
Only add declaration at header file, the actual implementation
code at OemMiscLib.
D02 uses another SAS driver which doesn't need this interface.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Heyi Guo <guoheyi@huawei.com>
---
 Chips/Hisilicon/Include/Library/OemMiscLib.h                      | 1 +
 Platforms/Hisilicon/D03/Library/OemMiscLib2P/OemMiscLib2PHi1610.c | 5 +++++
 2 files changed, 6 insertions(+)

Comments

Leif Lindholm Nov. 10, 2016, 9:21 p.m. | #1
On Thu, Nov 10, 2016 at 09:52:20PM +0800, Heyi Guo wrote:
> Add OemIsNeedDisableExpanderBuffer() interface for SAS driver.
> Only add declaration at header file, the actual implementation
> code at OemMiscLib.
> D02 uses another SAS driver which doesn't need this interface.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Heyi Guo <guoheyi@huawei.com>

This should be moved to the patch that adds the updated binary SAS driver.

> ---
>  Chips/Hisilicon/Include/Library/OemMiscLib.h                      | 1 +
>  Platforms/Hisilicon/D03/Library/OemMiscLib2P/OemMiscLib2PHi1610.c | 5 +++++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/Chips/Hisilicon/Include/Library/OemMiscLib.h b/Chips/Hisilicon/Include/Library/OemMiscLib.h
> index 19d92e0..6f18c0f 100644
> --- a/Chips/Hisilicon/Include/Library/OemMiscLib.h
> +++ b/Chips/Hisilicon/Include/Library/OemMiscLib.h
> @@ -44,6 +44,7 @@ BOOLEAN OemIsMpBoot();
>  UINT32 OemIsWarmBoot();
>  
>  VOID OemBiosSwitch(UINT32 Master);
> +BOOLEAN OemIsNeedDisableExpanderBuffer(VOID);
>  
>  extern EFI_STRING_ID gDimmToDevLocator[MAX_SOCKET][MAX_CHANNEL][MAX_DIMM];
>  EFI_HII_HANDLE EFIAPI OemGetPackages ();
> diff --git a/Platforms/Hisilicon/D03/Library/OemMiscLib2P/OemMiscLib2PHi1610.c b/Platforms/Hisilicon/D03/Library/OemMiscLib2P/OemMiscLib2PHi1610.c
> index c709f8b..fa1039b 100644
> --- a/Platforms/Hisilicon/D03/Library/OemMiscLib2P/OemMiscLib2PHi1610.c
> +++ b/Platforms/Hisilicon/D03/Library/OemMiscLib2P/OemMiscLib2PHi1610.c
> @@ -134,3 +134,8 @@ VOID OemBiosSwitch(UINT32 Master)
>      (VOID)Master;
>      return;
>  }
> +
> +BOOLEAN OemIsNeedDisableExpanderBuffer(VOID)
> +{
> +    return TRUE;
> +}
> -- 
> 1.9.1
>

Patch

diff --git a/Chips/Hisilicon/Include/Library/OemMiscLib.h b/Chips/Hisilicon/Include/Library/OemMiscLib.h
index 19d92e0..6f18c0f 100644
--- a/Chips/Hisilicon/Include/Library/OemMiscLib.h
+++ b/Chips/Hisilicon/Include/Library/OemMiscLib.h
@@ -44,6 +44,7 @@  BOOLEAN OemIsMpBoot();
 UINT32 OemIsWarmBoot();
 
 VOID OemBiosSwitch(UINT32 Master);
+BOOLEAN OemIsNeedDisableExpanderBuffer(VOID);
 
 extern EFI_STRING_ID gDimmToDevLocator[MAX_SOCKET][MAX_CHANNEL][MAX_DIMM];
 EFI_HII_HANDLE EFIAPI OemGetPackages ();
diff --git a/Platforms/Hisilicon/D03/Library/OemMiscLib2P/OemMiscLib2PHi1610.c b/Platforms/Hisilicon/D03/Library/OemMiscLib2P/OemMiscLib2PHi1610.c
index c709f8b..fa1039b 100644
--- a/Platforms/Hisilicon/D03/Library/OemMiscLib2P/OemMiscLib2PHi1610.c
+++ b/Platforms/Hisilicon/D03/Library/OemMiscLib2P/OemMiscLib2PHi1610.c
@@ -134,3 +134,8 @@  VOID OemBiosSwitch(UINT32 Master)
     (VOID)Master;
     return;
 }
+
+BOOLEAN OemIsNeedDisableExpanderBuffer(VOID)
+{
+    return TRUE;
+}