[Linaro-uefi,17/27] D03/OemNicConfig: add CpldIoLib to avoid potential build error

Message ID 1478785950-24197-18-git-send-email-heyi.guo@linaro.org
State New
Headers show

Commit Message

gary guo Nov. 10, 2016, 1:52 p.m.
D03 OemNicConfig driver is using CpldIoLib, so CpldIoLib needs
to be added to the INF file to avoid potential build error.

The reason why it didn't cause D03 build failure is that CpldIoLib is
invoked by this module implicitly via below chain:
I2CLib->PlatformSysCtrlLib of Hi1610->OemAddressMapLib of D03->CpldIoLib

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
---
 Platforms/Hisilicon/D03/Drivers/OemNicConfig2PHi1610/OemNicConfig2P.inf | 1 +
 1 file changed, 1 insertion(+)

Comments

Leif Lindholm Nov. 10, 2016, 9:24 p.m. | #1
On Thu, Nov 10, 2016 at 09:52:21PM +0800, Heyi Guo wrote:
> D03 OemNicConfig driver is using CpldIoLib, so CpldIoLib needs
> to be added to the INF file to avoid potential build error.
> 
> The reason why it didn't cause D03 build failure is that CpldIoLib is
> invoked by this module implicitly via below chain:
> I2CLib->PlatformSysCtrlLib of Hi1610->OemAddressMapLib of D03->CpldIoLib
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
> ---
>  Platforms/Hisilicon/D03/Drivers/OemNicConfig2PHi1610/OemNicConfig2P.inf | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Platforms/Hisilicon/D03/Drivers/OemNicConfig2PHi1610/OemNicConfig2P.inf b/Platforms/Hisilicon/D03/Drivers/OemNicConfig2PHi1610/OemNicConfig2P.inf
> index 4327406..cc544f7 100644
> --- a/Platforms/Hisilicon/D03/Drivers/OemNicConfig2PHi1610/OemNicConfig2P.inf
> +++ b/Platforms/Hisilicon/D03/Drivers/OemNicConfig2PHi1610/OemNicConfig2P.inf
> @@ -39,6 +39,7 @@
>    DebugLib
>    IoLib
>    TimerLib
> +  CpldIoLib

Please move before DebugLib, so it at least does not make sorting worse.

>    I2CLib
>    PcdLib
>  
> -- 
> 1.9.1
>

Patch

diff --git a/Platforms/Hisilicon/D03/Drivers/OemNicConfig2PHi1610/OemNicConfig2P.inf b/Platforms/Hisilicon/D03/Drivers/OemNicConfig2PHi1610/OemNicConfig2P.inf
index 4327406..cc544f7 100644
--- a/Platforms/Hisilicon/D03/Drivers/OemNicConfig2PHi1610/OemNicConfig2P.inf
+++ b/Platforms/Hisilicon/D03/Drivers/OemNicConfig2PHi1610/OemNicConfig2P.inf
@@ -39,6 +39,7 @@ 
   DebugLib
   IoLib
   TimerLib
+  CpldIoLib
   I2CLib
   PcdLib