diff mbox series

configs: enable efidebug and EFI http boot on QEMU aarch64

Message ID 20240807130010.407399-1-ilias.apalodimas@linaro.org
State Accepted
Commit 02214c8b9dd879ed31973e865a2968167a3a95f5
Headers show
Series configs: enable efidebug and EFI http boot on QEMU aarch64 | expand

Commit Message

Ilias Apalodimas Aug. 7, 2024, 1 p.m. UTC
EFI HTTP is a useful option to have by default and is working reliably on
QEMU. Let's enable it by default, since we have no size limitations.
While at it enable 'efidebug' as well, which is currently needed to
configure the EFI HTTP boot options.

Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
---
 configs/qemu_arm64_defconfig | 2 ++
 1 file changed, 2 insertions(+)

Comments

Heinrich Schuchardt Aug. 7, 2024, 1:45 p.m. UTC | #1
On 07.08.24 15:00, Ilias Apalodimas wrote:
> EFI HTTP is a useful option to have by default and is working reliably on
> QEMU. Let's enable it by default, since we have no size limitations.
> While at it enable 'efidebug' as well, which is currently needed to
> configure the EFI HTTP boot options.

Should this be added to the efconfig command in future?

Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

>
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> ---
>   configs/qemu_arm64_defconfig | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/configs/qemu_arm64_defconfig b/configs/qemu_arm64_defconfig
> index 7e166f439087..088ba39f18e1 100644
> --- a/configs/qemu_arm64_defconfig
> +++ b/configs/qemu_arm64_defconfig
> @@ -33,6 +33,7 @@ CONFIG_CMD_NVEDIT_EFI=y
>   CONFIG_CMD_DFU=y
>   CONFIG_CMD_MTD=y
>   CONFIG_CMD_PCI=y
> +CONFIG_CMD_EFIDEBUG=y
>   CONFIG_CMD_TPM=y
>   CONFIG_CMD_MTDPARTS=y
>   CONFIG_ENV_IS_IN_FLASH=y
> @@ -68,3 +69,4 @@ CONFIG_USB_EHCI_HCD=y
>   CONFIG_USB_EHCI_PCI=y
>   CONFIG_SEMIHOSTING=y
>   CONFIG_TPM=y
> +CONFIG_EFI_HTTP_BOOT=y
Simon Glass Aug. 7, 2024, 2:36 p.m. UTC | #2
On Wed, 7 Aug 2024 at 07:00, Ilias Apalodimas
<ilias.apalodimas@linaro.org> wrote:
>
> EFI HTTP is a useful option to have by default and is working reliably on
> QEMU. Let's enable it by default, since we have no size limitations.
> While at it enable 'efidebug' as well, which is currently needed to
> configure the EFI HTTP boot options.
>
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> ---
>  configs/qemu_arm64_defconfig | 2 ++
>  1 file changed, 2 insertions(+)
>

Reviewed-by: Simon Glass <sjg@chromium.org>


> diff --git a/configs/qemu_arm64_defconfig b/configs/qemu_arm64_defconfig
> index 7e166f439087..088ba39f18e1 100644
> --- a/configs/qemu_arm64_defconfig
> +++ b/configs/qemu_arm64_defconfig
> @@ -33,6 +33,7 @@ CONFIG_CMD_NVEDIT_EFI=y
>  CONFIG_CMD_DFU=y
>  CONFIG_CMD_MTD=y
>  CONFIG_CMD_PCI=y
> +CONFIG_CMD_EFIDEBUG=y
>  CONFIG_CMD_TPM=y
>  CONFIG_CMD_MTDPARTS=y
>  CONFIG_ENV_IS_IN_FLASH=y
> @@ -68,3 +69,4 @@ CONFIG_USB_EHCI_HCD=y
>  CONFIG_USB_EHCI_PCI=y
>  CONFIG_SEMIHOSTING=y
>  CONFIG_TPM=y
> +CONFIG_EFI_HTTP_BOOT=y
> --
> 2.45.2
>
Ilias Apalodimas Aug. 8, 2024, 10:44 a.m. UTC | #3
Hi Heinrich

On Wed, 7 Aug 2024 at 16:46, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> On 07.08.24 15:00, Ilias Apalodimas wrote:
> > EFI HTTP is a useful option to have by default and is working reliably on
> > QEMU. Let's enable it by default, since we have no size limitations.
> > While at it enable 'efidebug' as well, which is currently needed to
> > configure the EFI HTTP boot options.
>
> Should this be added to the efconfig command in future?

Yes, absolutely. I'll see what I can do about it

>
> Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

Thanks!
/Ilias
>
> >
> > Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> > ---
> >   configs/qemu_arm64_defconfig | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/configs/qemu_arm64_defconfig b/configs/qemu_arm64_defconfig
> > index 7e166f439087..088ba39f18e1 100644
> > --- a/configs/qemu_arm64_defconfig
> > +++ b/configs/qemu_arm64_defconfig
> > @@ -33,6 +33,7 @@ CONFIG_CMD_NVEDIT_EFI=y
> >   CONFIG_CMD_DFU=y
> >   CONFIG_CMD_MTD=y
> >   CONFIG_CMD_PCI=y
> > +CONFIG_CMD_EFIDEBUG=y
> >   CONFIG_CMD_TPM=y
> >   CONFIG_CMD_MTDPARTS=y
> >   CONFIG_ENV_IS_IN_FLASH=y
> > @@ -68,3 +69,4 @@ CONFIG_USB_EHCI_HCD=y
> >   CONFIG_USB_EHCI_PCI=y
> >   CONFIG_SEMIHOSTING=y
> >   CONFIG_TPM=y
> > +CONFIG_EFI_HTTP_BOOT=y
>
diff mbox series

Patch

diff --git a/configs/qemu_arm64_defconfig b/configs/qemu_arm64_defconfig
index 7e166f439087..088ba39f18e1 100644
--- a/configs/qemu_arm64_defconfig
+++ b/configs/qemu_arm64_defconfig
@@ -33,6 +33,7 @@  CONFIG_CMD_NVEDIT_EFI=y
 CONFIG_CMD_DFU=y
 CONFIG_CMD_MTD=y
 CONFIG_CMD_PCI=y
+CONFIG_CMD_EFIDEBUG=y
 CONFIG_CMD_TPM=y
 CONFIG_CMD_MTDPARTS=y
 CONFIG_ENV_IS_IN_FLASH=y
@@ -68,3 +69,4 @@  CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_EHCI_PCI=y
 CONFIG_SEMIHOSTING=y
 CONFIG_TPM=y
+CONFIG_EFI_HTTP_BOOT=y