diff mbox series

gitlab-ci: Replace build_script -> step_script in Cirrus jobs

Message ID 20240816213203.18350-1-philmd@linaro.org
State Superseded
Headers show
Series gitlab-ci: Replace build_script -> step_script in Cirrus jobs | expand

Commit Message

Philippe Mathieu-Daudé Aug. 16, 2024, 9:32 p.m. UTC
Long due upgrade, see [1]:

  In GitLab Runner 13.2 a translation for step_script to
  build_script was added to the custom executor. In 14.0
  the build_script stage will be replaced with step_script.

We are using GitLab 17 [2]!

This removes the following warning:

  WARNING: Starting with version 17.0 the 'build_script'
  stage will be replaced with 'step_script':
  https://gitlab.com/groups/gitlab-org/-/epics/6112

[1] https://about.gitlab.com/releases/2021/05/22/gitlab-13-12-released/#remove-translation-from-stepscript-to-buildscript-in-custom-executor
[2] https://about.gitlab.com/releases/2024/05/16/gitlab-17-0-released/

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 .gitlab-ci.d/cirrus/build.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Huth Aug. 19, 2024, 5:38 a.m. UTC | #1
On 16/08/2024 23.32, Philippe Mathieu-Daudé wrote:
> Long due upgrade, see [1]:
> 
>    In GitLab Runner 13.2 a translation for step_script to
>    build_script was added to the custom executor. In 14.0
>    the build_script stage will be replaced with step_script.
> 
> We are using GitLab 17 [2]!
> 
> This removes the following warning:
> 
>    WARNING: Starting with version 17.0 the 'build_script'
>    stage will be replaced with 'step_script':
>    https://gitlab.com/groups/gitlab-org/-/epics/6112
> 
> [1] https://about.gitlab.com/releases/2021/05/22/gitlab-13-12-released/#remove-translation-from-stepscript-to-buildscript-in-custom-executor
> [2] https://about.gitlab.com/releases/2024/05/16/gitlab-17-0-released/
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   .gitlab-ci.d/cirrus/build.yml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.gitlab-ci.d/cirrus/build.yml b/.gitlab-ci.d/cirrus/build.yml
> index 43dd52dd19..102cdbd8b1 100644
> --- a/.gitlab-ci.d/cirrus/build.yml
> +++ b/.gitlab-ci.d/cirrus/build.yml
> @@ -26,7 +26,7 @@ build_task:
>       - git clone --depth 100 "$CI_REPOSITORY_URL" .
>       - git fetch origin "$CI_COMMIT_REF_NAME"
>       - git reset --hard "$CI_COMMIT_SHA"
> -  build_script:
> +  step_script:
>       - mkdir build
>       - cd build
>       - ../configure --enable-werror $CONFIGURE_ARGS

Reviewed-by: Thomas Huth <thuth@redhat.com>
diff mbox series

Patch

diff --git a/.gitlab-ci.d/cirrus/build.yml b/.gitlab-ci.d/cirrus/build.yml
index 43dd52dd19..102cdbd8b1 100644
--- a/.gitlab-ci.d/cirrus/build.yml
+++ b/.gitlab-ci.d/cirrus/build.yml
@@ -26,7 +26,7 @@  build_task:
     - git clone --depth 100 "$CI_REPOSITORY_URL" .
     - git fetch origin "$CI_COMMIT_REF_NAME"
     - git reset --hard "$CI_COMMIT_SHA"
-  build_script:
+  step_script:
     - mkdir build
     - cd build
     - ../configure --enable-werror $CONFIGURE_ARGS