| Message ID | 20240816125132.514488-1-changhuang.liang@starfivetech.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2] staging: media: starfive: Add the dynamic resolution support | expand |
On Fri, Aug 16, 2024 at 05:51:32AM -0700, Changhuang Liang wrote: > Add the dynamic resolution support for video "capture_raw" device. > What does this change look like from a use perspective if a user is reading the git log? > Fixes: e080f339c80a ("media: staging: media: starfive: camss: Add capture driver") > This looks like a new feature and not a bugfix. Please describe the bug more clearly if it's really a bugfix. regards, dan carpenter
On Fri, Aug 16, 2024 at 04:04:38PM +0300, Dan Carpenter wrote: > On Fri, Aug 16, 2024 at 05:51:32AM -0700, Changhuang Liang wrote: > > Add the dynamic resolution support for video "capture_raw" device. > > > > What does this change look like from a use perspective if a user is reading the > git log? > > > Fixes: e080f339c80a ("media: staging: media: starfive: camss: Add capture driver") > > > > This looks like a new feature and not a bugfix. Please describe the bug more > clearly if it's really a bugfix. > Actually the first version of the commit had a good description. Just go back to that. > Add multiple resolution support for video "capture_raw" device. Otherwise > it will capture the wrong image data if the width is not 1920. Btw: 1) Don't put a blank line after the Fixes tag. 2) Put a note under the --- cut off line that says what changed. https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/ Please send v3. regards, dan carpenter
Hi, Dan Thanks for your comments. >On Fri, Aug 16, 2024 at 04:04:38PM +0300, Dan Carpenter wrote: >> On Fri, Aug 16, 2024 at 05:51:32AM -0700, Changhuang Liang wrote: >> > Add the dynamic resolution support for video "capture_raw" device. >> > >> >> What does this change look like from a use perspective if a user is reading the >> git log? >> >> > Fixes: e080f339c80a ("media: staging: media: starfive: camss: Add capture driver") >> > >> >> This looks like a new feature and not a bugfix. Please describe the bug more >> clearly if it's really a bugfix. >> > >Actually the first version of the commit had a good description. Just go back >to that. > Yes, I forgot to synchronous description. >> Add multiple resolution support for video "capture_raw" device. Otherwise >> it will capture the wrong image data if the width is not 1920. > >Btw: >1) Don't put a blank line after the Fixes tag. >2) Put a note under the --- cut off line that says what changed. > >https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/ > Thanks for this. >Please send v3. regards, Changhuang
diff --git a/drivers/staging/media/starfive/camss/stf-capture.c b/drivers/staging/media/starfive/camss/stf-capture.c index ec5169e7b391..e15d2e97eb0b 100644 --- a/drivers/staging/media/starfive/camss/stf-capture.c +++ b/drivers/staging/media/starfive/camss/stf-capture.c @@ -180,6 +180,8 @@ static void stf_channel_set(struct stfcamss_video *video) u32 val; if (cap->type == STF_CAPTURE_RAW) { + const struct v4l2_pix_format *pix = &video->active_fmt.fmt.pix; + val = stf_syscon_reg_read(stfcamss, VIN_CHANNEL_SEL_EN); val &= ~U0_VIN_CHANNEL_SEL_MASK; val |= CHANNEL(0); @@ -193,7 +195,7 @@ static void stf_channel_set(struct stfcamss_video *video) val |= PIXEL_HEIGH_BIT_SEL(0); val &= ~U0_VIN_PIX_CNT_END_MASK; - val |= PIX_CNT_END(IMAGE_MAX_WIDTH / 4 - 1); + val |= PIX_CNT_END(pix->width / 4 - 1); stf_syscon_reg_write(stfcamss, VIN_INRT_PIX_CFG, val); } else if (cap->type == STF_CAPTURE_YUV) {
Add the dynamic resolution support for video "capture_raw" device. Fixes: e080f339c80a ("media: staging: media: starfive: camss: Add capture driver") Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com> --- drivers/staging/media/starfive/camss/stf-capture.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)