[Linaro-uefi,20/28] D03/OemMiscLib: Add interface for SAS driver

Message ID 1479122995-50330-21-git-send-email-heyi.guo@linaro.org
State New
Headers show

Commit Message

Heyi Guo Nov. 14, 2016, 11:29 a.m.
Add OemIsNeedDisableExpanderBuffer() interface for SAS driver.
The Hisilicon D03/D05 and some internal platforms use the same SAS driver,
and they need different configuration about the expander buffer,
The SAS driver will check the interface to disable the expander
buffer or not.
The SAS driver is a binary and will be updated by another patch.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Heyi Guo <guoheyi@huawei.com>
---
 Platforms/Hisilicon/D03/Library/OemMiscLib2P/OemMiscLib2PHi1610.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Leif Lindholm Nov. 15, 2016, 8:41 p.m. | #1
On Mon, Nov 14, 2016 at 07:29:47PM +0800, Heyi Guo wrote:
> Add OemIsNeedDisableExpanderBuffer() interface for SAS driver.
> The Hisilicon D03/D05 and some internal platforms use the same SAS driver,
> and they need different configuration about the expander buffer,
> The SAS driver will check the interface to disable the expander
> buffer or not.
> The SAS driver is a binary and will be updated by another patch.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Heyi Guo <guoheyi@huawei.com>

This should also have a definition added in
Chips/Hisilicon/Include/Library/OemMiscLib.h

> ---
>  Platforms/Hisilicon/D03/Library/OemMiscLib2P/OemMiscLib2PHi1610.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Platforms/Hisilicon/D03/Library/OemMiscLib2P/OemMiscLib2PHi1610.c b/Platforms/Hisilicon/D03/Library/OemMiscLib2P/OemMiscLib2PHi1610.c
> index 75b23d5..c673c42 100644
> --- a/Platforms/Hisilicon/D03/Library/OemMiscLib2P/OemMiscLib2PHi1610.c
> +++ b/Platforms/Hisilicon/D03/Library/OemMiscLib2P/OemMiscLib2PHi1610.c
> @@ -143,3 +143,8 @@ VOID OemBiosSwitch(UINT32 Master)
>      (VOID)Master;
>      return;
>  }
> +
> +BOOLEAN OemIsNeedDisableExpanderBuffer(VOID)
> +{
> +    return TRUE;
> +}
> -- 
> 1.9.1
>

Patch hide | download patch | download mbox

diff --git a/Platforms/Hisilicon/D03/Library/OemMiscLib2P/OemMiscLib2PHi1610.c b/Platforms/Hisilicon/D03/Library/OemMiscLib2P/OemMiscLib2PHi1610.c
index 75b23d5..c673c42 100644
--- a/Platforms/Hisilicon/D03/Library/OemMiscLib2P/OemMiscLib2PHi1610.c
+++ b/Platforms/Hisilicon/D03/Library/OemMiscLib2P/OemMiscLib2PHi1610.c
@@ -143,3 +143,8 @@  VOID OemBiosSwitch(UINT32 Master)
     (VOID)Master;
     return;
 }
+
+BOOLEAN OemIsNeedDisableExpanderBuffer(VOID)
+{
+    return TRUE;
+}