broadcom/brcm80211/brcmfmac/cfg80211 driver, bad regulatory domain frequency value

Message ID 810879191.6335567.1479124065921@mail.yahoo.com
State New
Headers show

Commit Message

Gianfranco Costamagna Nov. 14, 2016, 11:47 a.m.
Hi Arend,



>Well, not before you pointed it out ;-). You are welcome to send a patch

>fixing it. Otherwise, I will take care of it.



attaching a format-patch like version.
I don't think we need a Tested-by or whatever, because it is just a typo in a comment.
(this is my first contribution, feel free to rebase or change whatever you prefer
to make it in line with other styles)

(I gave authorship to Marco, the first one who discovered such typo)

thanks!

G.

Comments

Kalle Valo Nov. 15, 2016, 11:10 a.m. | #1
Gianfranco Costamagna <locutusofborg@debian.org> writes:

>> Well, not before you pointed it out ;-). You are welcome to send a patch

>> fixing it. Otherwise, I will take care of it.

>

> attaching a format-patch like version.

> I don't think we need a Tested-by or whatever, because it is just a typo in a comment.

> (this is my first contribution, feel free to rebase or change whatever you prefer

> to make it in line with other styles)

>

> (I gave authorship to Marco, the first one who discovered such typo)


[...]

> Signed-off-by: Gianfranco Costamagna <gianfranco.costamagna@abinsula.com>

> Signed-off-by: Nicola Smaldone <nicola.smaldone@tierraservice.com>

> Signed-off-by: Arlone Marco <marco.arlone@roj.com>


Please note that you cannot add Signed-off-by for other people without
their explicit approval (see Documentation/SubmittingPatches). I don't
know if they did it in this case or not, but wanted to point out this
anyway.

-- 
Kalle Valo
Gianfranco Costamagna Nov. 15, 2016, 1:13 p.m. | #2
Hi,


> Signed-off-by: Nicola Smaldone <nicola.smaldone@tierraservice.com>


> Signed-off-by: Arlone Marco <marco.arlone@roj.com>


>Please note that you cannot add Signed-off-by for other people without

>their explicit approval (see Documentation/SubmittingPatches). I don't

>know if they did it in this case or not, but wanted to point out this

>anyway.



The first signoff is myself, with the company email, the other two signoffs
are from: the author, and Nicola, who did work with me to test it
(even if a typo fix is not "testable").

Nicola, Marco, is it ok to add your two names in the signoff part?
(that was a verbal talk, I don't have anything written)

Gianfranco
Nicola Smaldone Nov. 15, 2016, 1:18 p.m. | #3
No problem for me, thanks.

Nicola SMALDONE
www.tierratelematics.com

-----Original Message-----
From: Gianfranco Costamagna [mailto:locutusofborg@debian.org] 

Sent: martedì 15 novembre 2016 14:14
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Arend Van Spriel <arend.vanspriel@broadcom.com>; brcm80211-dev-list@broadcom.com; linux-wireless@vger.kernel.org; Nicola Smaldone <nsmaldone@tierratelematics.com>; Marco.Arlone@roj.com
Subject: Re: [PATCH] broadcom/brcm80211/brcmfmac/cfg80211 driver, bad regulatory domain frequency value

Hi,


> Signed-off-by: Nicola Smaldone <nicola.smaldone@tierraservice.com>


> Signed-off-by: Arlone Marco <marco.arlone@roj.com>


>Please note that you cannot add Signed-off-by for other people without 

>their explicit approval (see Documentation/SubmittingPatches). I don't 

>know if they did it in this case or not, but wanted to point out this 

>anyway.



The first signoff is myself, with the company email, the other two signoffs are from: the author, and Nicola, who did work with me to test it (even if a typo fix is not "testable").

Nicola, Marco, is it ok to add your two names in the signoff part?
(that was a verbal talk, I don't have anything written)

Gianfranco

Confidentiality Notice: This message (including attachments) is a private communication solely
for use of the intended recipient(s). If you are not the intended recipient(s) or believe you
received this message in error, notify the sender immediately and then delete this message. Any
other use, retention, dissemination or copying is prohibited and may be a violation of law,
including the Electronic Communication Privacy Act of 1986.
Arlone Marco Nov. 15, 2016, 1:21 p.m. | #4
No problem for me, also.

Marco Arlone

-----Messaggio originale-----
Da: Nicola Smaldone [mailto:nsmaldone@tierratelematics.com] 
Inviato: martedì 15 novembre 2016 14:18
A: Gianfranco Costamagna; Kalle Valo
Cc: Arend Van Spriel; brcm80211-dev-list@broadcom.com; linux-wireless@vger.kernel.org; Arlone Marco
Oggetto: RE: [PATCH] broadcom/brcm80211/brcmfmac/cfg80211 driver, bad regulatory domain frequency value

No problem for me, thanks.

Nicola SMALDONE
www.tierratelematics.com

-----Original Message-----
From: Gianfranco Costamagna [mailto:locutusofborg@debian.org]

Sent: martedì 15 novembre 2016 14:14
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Arend Van Spriel <arend.vanspriel@broadcom.com>; brcm80211-dev-list@broadcom.com; linux-wireless@vger.kernel.org; Nicola Smaldone <nsmaldone@tierratelematics.com>; Marco.Arlone@roj.com
Subject: Re: [PATCH] broadcom/brcm80211/brcmfmac/cfg80211 driver, bad regulatory domain frequency value

Hi,


> Signed-off-by: Nicola Smaldone <nicola.smaldone@tierraservice.com>


> Signed-off-by: Arlone Marco <marco.arlone@roj.com>


>Please note that you cannot add Signed-off-by for other people without 

>their explicit approval (see Documentation/SubmittingPatches). I don't 

>know if they did it in this case or not, but wanted to point out this 

>anyway.



The first signoff is myself, with the company email, the other two signoffs are from: the author, and Nicola, who did work with me to test it (even if a typo fix is not "testable").

Nicola, Marco, is it ok to add your two names in the signoff part?
(that was a verbal talk, I don't have anything written)

Gianfranco

Confidentiality Notice: This message (including attachments) is a private communication solely for use of the intended recipient(s). If you are not the intended recipient(s) or believe you received this message in error, notify the sender immediately and then delete this message. Any other use, retention, dissemination or copying is prohibited and may be a violation of law, including the Electronic Communication Privacy Act of 1986.

Follow us on YouTube: https://www.youtube.com/channel/UC9nTKjeq8UdxExKnCNXDPmA

Prima di stampare, pensa all'ambiente ** Think about the environment before printing


ROJ S.r.l. - Biella - Italy  (www.roj.com) 
Tel: +39.015.8480111   Fax: +39.015.405815/8480209

This e-mail and any files transmitted with it is confidential and intended only for the stated addressee(s). Any unauthorised disclosure, use or dissemination, either whole or partial, by person or entities other than the addressee(s) is prohibited. Please notify the sender immediately by e-mail if you have received this e-mail by mistake and delete this e-mail from your system. 
Please note that any views or opinions presented in this e-mail are solely those of the author and are not necessarily endorsed by the company. Although the company has taken reasonable precautions to ensure no viruses are present in this e-mail, the company cannot accept responsibility for any loss or damage arising from the use of this e-mail or attachments.
Kalle Valo Nov. 15, 2016, 1:52 p.m. | #5
Gianfranco Costamagna <locutusofborg@debian.org> writes:

>> Signed-off-by: Nicola Smaldone <nicola.smaldone@tierraservice.com>

>

>> Signed-off-by: Arlone Marco <marco.arlone@roj.com>

>

>>Please note that you cannot add Signed-off-by for other people without

>>their explicit approval (see Documentation/SubmittingPatches). I don't

>>know if they did it in this case or not, but wanted to point out this

>>anyway.

>

>

> The first signoff is myself, with the company email, the other two signoffs

> are from: the author, and Nicola, who did work with me to test it

> (even if a typo fix is not "testable").

>

> Nicola, Marco, is it ok to add your two names in the signoff part?

> (that was a verbal talk, I don't have anything written)


Good, so we got now approvals from both of them. Thanks.

-- 
Kalle Valo
Arend Van Spriel Nov. 16, 2016, 10:38 a.m. | #6
On 15-11-2016 12:10, Kalle Valo wrote:
> Gianfranco Costamagna <locutusofborg@debian.org> writes:

> 

>>> Well, not before you pointed it out ;-). You are welcome to send a patch

>>> fixing it. Otherwise, I will take care of it.

>>

>> attaching a format-patch like version.

>> I don't think we need a Tested-by or whatever, because it is just a typo in a comment.

>> (this is my first contribution, feel free to rebase or change whatever you prefer

>> to make it in line with other styles)

>>

>> (I gave authorship to Marco, the first one who discovered such typo)

> 

> [...]

> 

>> Signed-off-by: Gianfranco Costamagna <gianfranco.costamagna@abinsula.com>

>> Signed-off-by: Nicola Smaldone <nicola.smaldone@tierraservice.com>

>> Signed-off-by: Arlone Marco <marco.arlone@roj.com>

> 

> Please note that you cannot add Signed-off-by for other people without

> their explicit approval (see Documentation/SubmittingPatches). I don't

> know if they did it in this case or not, but wanted to point out this

> anyway.


Thanks, Kalle

It was on my list to give a contrib boot camp here. So let's go over
things here albeit it late.

Hi Gianfrance,

A couple of things from which you may benefit for future contributions.
Basic info can be found in Documentation/SubmittingPatches as Kalle
indicated.

Patches should not be submitted as attachments. After doing 'git
format-patch' the easiest way is using 'git send-email' (which requires
you to have sendmail on your system properly setup). I tend to send
patches to Kalle and Cc: linux-wireless, but that is my personal
preference. Sending it to the list should be sufficient as patchwork
will pick it up [1].

When it comes to attribution of others you should have their approval
for Signed-off-by. However, reading your remarks it seems a proper way
is below:

Reported-by: Arlone Marco <marco.arlone@roj.com>
Tested-by: Nicola Smaldone <nicola.smaldone@tierraservice.com>

Signed-off-by: Gianfranco Costamagna <gianfranco.costamagna@abinsula.com>


Regards,
Arend

[1] https://patchwork.kernel.org/project/linux-wireless/list/

Patch hide | download patch | download mbox

From bf0cdd8ad27833639447a3071d662f79a7219b1d Mon Sep 17 00:00:00 2001
From: Arlone Marco <marco.arlone@roj.com>
Date: Sat, 22 Oct 2016 15:08:35 +0200
Subject: [PATCH] broadcom cfg80211: fix typo in REG channel frequency comment

frequency 2472 corresponds to channel 13, not channel 11

Signed-off-by: Gianfranco Costamagna <gianfranco.costamagna@abinsula.com>
Signed-off-by: Nicola Smaldone <nicola.smaldone@tierraservice.com>
Signed-off-by: Arlone Marco <marco.arlone@roj.com>
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
index b777e1b..b4d8b1b 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
@@ -203,7 +203,7 @@  static const struct ieee80211_regdomain brcmf_regdom = {
 	.n_reg_rules = 4,
 	.alpha2 =  "99",
 	.reg_rules = {
-		/* IEEE 802.11b/g, channels 1..11 */
+		/* IEEE 802.11b/g, channels 1..13 */
 		REG_RULE(2412-10, 2472+10, 40, 6, 20, 0),
 		/* If any */
 		/* IEEE 802.11 channel 14 - Only JP enables
-- 
2.7.4