diff mbox

[2/2] arm64: dts: juno: fix cluster sleep state entry latency on all SoC versions

Message ID 1479317491-7435-2-git-send-email-sudeep.holla@arm.com
State New
Headers show

Commit Message

Sudeep Holla Nov. 16, 2016, 5:31 p.m. UTC
The core and the cluster sleep state entry latencies can't be same as
cluster sleep involves more work compared to core level e.g. shared
cache maintenance.

Experiments have shown on an average about 100us more latency for the
cluster sleep state compared to the core level sleep. This patch fixes
the entry latency for the cluster sleep state.

Fixes: 28e10a8f3a03 ("arm64: dts: juno: Add idle-states to device tree")
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: "Jon Medhurst (Tixy)" <tixy@linaro.org>
Reviewed-by: Liviu Dudau <Liviu.Dudau@arm.com>

Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>

---
 arch/arm64/boot/dts/arm/juno-r1.dts | 2 +-
 arch/arm64/boot/dts/arm/juno-r2.dts | 2 +-
 arch/arm64/boot/dts/arm/juno.dts    | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

--
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Comments

Sudeep Holla Dec. 1, 2016, 10:11 a.m. UTC | #1
On 16/11/16 17:31, Sudeep Holla wrote:
> The core and the cluster sleep state entry latencies can't be same as

> cluster sleep involves more work compared to core level e.g. shared

> cache maintenance.

>

> Experiments have shown on an average about 100us more latency for the

> cluster sleep state compared to the core level sleep. This patch fixes

> the entry latency for the cluster sleep state.

>

> Fixes: 28e10a8f3a03 ("arm64: dts: juno: Add idle-states to device tree")

> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>

> Cc: "Jon Medhurst (Tixy)" <tixy@linaro.org>

> Reviewed-by: Liviu Dudau <Liviu.Dudau@arm.com>

> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>


You missed to pick up this, I posted this along with vexpress config bus
fix. Sorry for the confusion, I feel pull request are better/easier to
track than single patches. I will send PR from next time if also prefer
that. Let me know.

-- 
Regards,
Sudeep

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Arnd Bergmann Dec. 2, 2016, 4:30 p.m. UTC | #2
On Thursday, December 1, 2016 10:11:24 AM CET Sudeep Holla wrote:
> On 16/11/16 17:31, Sudeep Holla wrote:

> > The core and the cluster sleep state entry latencies can't be same as

> > cluster sleep involves more work compared to core level e.g. shared

> > cache maintenance.

> >

> > Experiments have shown on an average about 100us more latency for the

> > cluster sleep state compared to the core level sleep. This patch fixes

> > the entry latency for the cluster sleep state.

> >

> > Fixes: 28e10a8f3a03 ("arm64: dts: juno: Add idle-states to device tree")

> > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>

> > Cc: "Jon Medhurst (Tixy)" <tixy@linaro.org>

> > Reviewed-by: Liviu Dudau <Liviu.Dudau@arm.com>

> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>

> 

> You missed to pick up this, I posted this along with vexpress config bus

> fix. Sorry for the confusion, I feel pull request are better/easier to

> track than single patches. I will send PR from next time if also prefer

> that. Let me know.


Ok, I've applied that to the 4.9-fixes branch. Thanks for double-checking.

	Arnd


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff mbox

Patch

diff --git a/arch/arm64/boot/dts/arm/juno-r1.dts b/arch/arm64/boot/dts/arm/juno-r1.dts
index 123a58b29cbd..f0b857d6d73c 100644
--- a/arch/arm64/boot/dts/arm/juno-r1.dts
+++ b/arch/arm64/boot/dts/arm/juno-r1.dts
@@ -76,7 +76,7 @@ 
 				compatible = "arm,idle-state";
 				arm,psci-suspend-param = <0x1010000>;
 				local-timer-stop;
-				entry-latency-us = <300>;
+				entry-latency-us = <400>;
 				exit-latency-us = <1200>;
 				min-residency-us = <2500>;
 			};
diff --git a/arch/arm64/boot/dts/arm/juno-r2.dts b/arch/arm64/boot/dts/arm/juno-r2.dts
index 007be826efce..26aaa6a7670f 100644
--- a/arch/arm64/boot/dts/arm/juno-r2.dts
+++ b/arch/arm64/boot/dts/arm/juno-r2.dts
@@ -76,7 +76,7 @@ 
 				compatible = "arm,idle-state";
 				arm,psci-suspend-param = <0x1010000>;
 				local-timer-stop;
-				entry-latency-us = <300>;
+				entry-latency-us = <400>;
 				exit-latency-us = <1200>;
 				min-residency-us = <2500>;
 			};
diff --git a/arch/arm64/boot/dts/arm/juno.dts b/arch/arm64/boot/dts/arm/juno.dts
index a7270eff6939..6e154d948a80 100644
--- a/arch/arm64/boot/dts/arm/juno.dts
+++ b/arch/arm64/boot/dts/arm/juno.dts
@@ -76,7 +76,7 @@ 
 				compatible = "arm,idle-state";
 				arm,psci-suspend-param = <0x1010000>;
 				local-timer-stop;
-				entry-latency-us = <300>;
+				entry-latency-us = <400>;
 				exit-latency-us = <1200>;
 				min-residency-us = <2500>;
 			};