[Linaro-uefi,2/2] Platforms/ARM/Juno: Fix Watchdog Timer interrupt mode

Message ID 20161116214311.12328-3-evan.lloyd@arm.com
State New
Headers show

Commit Message

Evan Lloyd Nov. 16, 2016, 9:43 p.m.
From: Girish Pathak <girish.pathak@arm.com>

The SBSA Generic Watchog Timer interrupt is edge triggered.
However the interrupt setting in the GTDT ACPI table was not specified,
defaulting to a level trigger interrupt.
This patch configures the ACPI interrupt description as edge triggered.

Change-Id: Id6767d318519da7e141a55b7bacd5ef291f0a9c9
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Girish Pathak <girish.pathak@arm.com>
Signed-off-by: Evan Lloyd <evan.lloyd@arm.com>
---
 Platforms/ARM/Juno/AcpiTables/Gtdt.aslc | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Patch hide | download patch | download mbox

diff --git a/Platforms/ARM/Juno/AcpiTables/Gtdt.aslc b/Platforms/ARM/Juno/AcpiTables/Gtdt.aslc
index afffd4ac8e92888a554f60dda926c64132976229..79675d37462b3827212eb66b700b00ac0e107665 100644
--- a/Platforms/ARM/Juno/AcpiTables/Gtdt.aslc
+++ b/Platforms/ARM/Juno/AcpiTables/Gtdt.aslc
@@ -94,12 +94,13 @@  GENERIC_TIMER_DESCRIPTION_TABLE  Gtdt = {
       FixedPcdGet32 (PcdGenericWatchdogRefreshBase),
       FixedPcdGet32 (PcdGenericWatchdogControlBase),
       93,
-      0),
+      EFI_ACPI_5_1_GTDT_SBSA_GENERIC_WATCHDOG_FLAG_TIMER_INTERRUPT_MODE),
     EFI_ACPI_5_1_SBSA_GENERIC_WATCHDOG_STRUCTURE_INIT (
       FixedPcdGet32 (PcdGenericWatchdogRefreshBase),
       FixedPcdGet32 (PcdGenericWatchdogControlBase),
       94,
-      EFI_ACPI_5_1_GTDT_SBSA_GENERIC_WATCHDOG_FLAG_SECURE_TIMER)
+      (EFI_ACPI_5_1_GTDT_SBSA_GENERIC_WATCHDOG_FLAG_SECURE_TIMER
+       | EFI_ACPI_5_1_GTDT_SBSA_GENERIC_WATCHDOG_FLAG_TIMER_INTERRUPT_MODE))
   }
 #endif
   };