diff mbox series

[v2,46/48] qom: remove return after g_assert_not_reached()

Message ID 20240912161150.483515-3-pierrick.bouvier@linaro.org
State Superseded
Headers show
Series None | expand

Commit Message

Pierrick Bouvier Sept. 12, 2024, 4:11 p.m. UTC 
This patch is part of a series that moves towards a consistent use of
g_assert_not_reached() rather than an ad hoc mix of different
assertion mechanisms.

Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
 qom/object.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Richard Henderson Sept. 12, 2024, 6:20 p.m. UTC | #1 
On 9/12/24 09:11, Pierrick Bouvier wrote:
> This patch is part of a series that moves towards a consistent use of
> g_assert_not_reached() rather than an ad hoc mix of different
> assertion mechanisms.
> 
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>   qom/object.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/qom/object.c b/qom/object.c
> index 157a45c5f8b..28c5b66eab5 100644
> --- a/qom/object.c
> +++ b/qom/object.c
> @@ -2079,7 +2079,6 @@ const char *object_get_canonical_path_component(const Object *obj)
>   
>       /* obj had a parent but was not a child, should never happen */
>       g_assert_not_reached();
> -    return NULL;
>   }
>   
>   char *object_get_canonical_path(const Object *obj)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~
diff mbox series

Patch

diff --git a/qom/object.c b/qom/object.c
index 157a45c5f8b..28c5b66eab5 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -2079,7 +2079,6 @@  const char *object_get_canonical_path_component(const Object *obj)
 
     /* obj had a parent but was not a child, should never happen */
     g_assert_not_reached();
-    return NULL;
 }
 
 char *object_get_canonical_path(const Object *obj)