| Message ID | 1479544691-59575-38-git-send-email-heyi.guo@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
On Sat, Nov 19, 2016 at 04:37:52PM +0800, Heyi Guo wrote: > The UART on Hip05 soc is not 16550 compatible, use appropriate ACPI ID > for Hisi uart instead of APM one, and delete the wrong comments. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> > Review-by: Graeme Gregory <graeme.gregory@linaro.org> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> (Apart from Graeme's "Review-by" instead of "Reviewed-by" :) I can fix those on commit. / Leif > --- > Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/Com.asl | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/Com.asl b/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/Com.asl > index d7350cf..e3fc0d3 100644 > --- a/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/Com.asl > +++ b/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/Com.asl > @@ -18,13 +18,12 @@ > > Scope(_SB) > { > - // UART 8250 > Device(COM0) { > - Name(_HID, "APMC0D08") //Or AMD0020, trick to use dw8250 serial driver > + Name(_HID, "HISI0031") //it is not 16550 compatible > Name(_CID, "8250dw") > Name(_UID, Zero) > Name(_CRS, ResourceTemplate() { > - Memory32Fixed(ReadWrite, 0x80300000, 0x1000) //0x7FF80000, 0x1000 > + Memory32Fixed(ReadWrite, 0x80300000, 0x1000) > Interrupt(ResourceConsumer, Level, ActiveHigh, Exclusive) { 349 } > }) > Name (_DSD, Package () { > -- > 1.9.1 >
diff --git a/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/Com.asl b/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/Com.asl index d7350cf..e3fc0d3 100644 --- a/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/Com.asl +++ b/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/Com.asl @@ -18,13 +18,12 @@ Scope(_SB) { - // UART 8250 Device(COM0) { - Name(_HID, "APMC0D08") //Or AMD0020, trick to use dw8250 serial driver + Name(_HID, "HISI0031") //it is not 16550 compatible Name(_CID, "8250dw") Name(_UID, Zero) Name(_CRS, ResourceTemplate() { - Memory32Fixed(ReadWrite, 0x80300000, 0x1000) //0x7FF80000, 0x1000 + Memory32Fixed(ReadWrite, 0x80300000, 0x1000) Interrupt(ResourceConsumer, Level, ActiveHigh, Exclusive) { 349 } }) Name (_DSD, Package () {
The UART on Hip05 soc is not 16550 compatible, use appropriate ACPI ID for Hisi uart instead of APM one, and delete the wrong comments. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> Review-by: Graeme Gregory <graeme.gregory@linaro.org> --- Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/Com.asl | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)