diff mbox series

media: ipu6: remove redundant dependency in Kconfig

Message ID 20240927021613.2158020-1-bingbu.cao@intel.com
State New
Headers show
Series media: ipu6: remove redundant dependency in Kconfig | expand

Commit Message

Bingbu Cao Sept. 27, 2024, 2:16 a.m. UTC 
From: Bingbu Cao <bingbu.cao@intel.com>

IPU6 driver simply depends on X86, X86 and 64BIT cover the
X86_64, redundant X86_64 dependency in Kconfig could be removed.

Fixes: c70281cc83d6 ("media: intel/ipu6: add Kconfig and Makefile")
Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
---
 drivers/media/pci/intel/ipu6/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andy Shevchenko Sept. 30, 2024, 1:16 p.m. UTC | #1 
On Fri, Sep 27, 2024 at 10:16:12AM +0800, bingbu.cao@intel.com wrote:
> From: Bingbu Cao <bingbu.cao@intel.com>
> 
> IPU6 driver simply depends on X86, X86 and 64BIT cover the
> X86_64, redundant X86_64 dependency in Kconfig could be removed.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

Thanks!
Andy Shevchenko Oct. 1, 2024, 12:22 p.m. UTC | #2 
On Sat, Sep 28, 2024 at 03:33:21AM +0800, kernel test robot wrote:

...

>    drivers/media/pci/intel/ipu6/ipu6.c: In function 'ipu6_pkg_dir_configure_spc':
> >> drivers/media/pci/intel/ipu6/ipu6.c:250:45: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>      250 |         prog = (struct ipu6_cell_program *)((u64)isp->cpd_fw->data + pg_offset);
>          |                                             ^
> >> drivers/media/pci/intel/ipu6/ipu6.c:250:16: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>      250 |         prog = (struct ipu6_cell_program *)((u64)isp->cpd_fw->data + pg_offset);
>          |                ^

Yes, someone should become familiar with uintptr_t.

> --

>    drivers/media/pci/intel/ipu6/ipu6-cpd.c:48:33: note: in expansion of macro 'GENMASK'
>       48 | #define PKG_DIR_TYPE_MASK       GENMASK(54, 48)

Somebody should learn about _ULL() variants of BIT() and GENMASK()
diff mbox series

Patch

diff --git a/drivers/media/pci/intel/ipu6/Kconfig b/drivers/media/pci/intel/ipu6/Kconfig
index 49e4fb696573..624d8e44c53b 100644
--- a/drivers/media/pci/intel/ipu6/Kconfig
+++ b/drivers/media/pci/intel/ipu6/Kconfig
@@ -2,7 +2,7 @@  config VIDEO_INTEL_IPU6
 	tristate "Intel IPU6 driver"
 	depends on ACPI || COMPILE_TEST
 	depends on VIDEO_DEV
-	depends on X86 && X86_64 && HAS_DMA
+	depends on X86 && HAS_DMA
 	depends on IPU_BRIDGE || !IPU_BRIDGE
 	#
 	# This driver incorrectly tries to override the dma_ops.  It should