diff mbox series

tests/qtest: Bump qmp-cmd-test timeout to 120s

Message ID 20241008141337.2790423-1-peter.maydell@linaro.org
State Accepted
Commit c9beb029b5bd8cc028411db2270995f5e0dc3567
Headers show
Series tests/qtest: Bump qmp-cmd-test timeout to 120s | expand

Commit Message

Peter Maydell Oct. 8, 2024, 2:13 p.m. UTC
The qmp-cmd-test test takes typically about 15s on my local machine.
On the k8s runners it takes usually 20s but sometimes about 60s,
because the k8s runners have wildly variable execution time.  If
they're running slow, we hit the default timeout.  Bump the
qmp-cmd-test timeout to 120s to avoid this.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 tests/qtest/meson.build | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Huth Oct. 8, 2024, 2:16 p.m. UTC | #1
On 08/10/2024 16.13, Peter Maydell wrote:
> The qmp-cmd-test test takes typically about 15s on my local machine.
> On the k8s runners it takes usually 20s but sometimes about 60s,
> because the k8s runners have wildly variable execution time.  If
> they're running slow, we hit the default timeout.  Bump the
> qmp-cmd-test timeout to 120s to avoid this.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>   tests/qtest/meson.build | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
> index 2b90abf0007..b207e386965 100644
> --- a/tests/qtest/meson.build
> +++ b/tests/qtest/meson.build
> @@ -7,6 +7,7 @@ slow_qtests = {
>     'migration-test' : 480,
>     'npcm7xx_pwm-test': 300,
>     'npcm7xx_watchdog_timer-test': 120,
> +  'qmp-cmd-test' : 120,
>     'qom-test' : 900,
>     'stm32l4x5_usart-test' : 600,
>     'test-hmp' : 240,

Reviewed-by: Thomas Huth <thuth@redhat.com>
Peter Maydell Oct. 9, 2024, 7:11 p.m. UTC | #2
On Tue, 8 Oct 2024 at 15:16, Thomas Huth <thuth@redhat.com> wrote:
>
> On 08/10/2024 16.13, Peter Maydell wrote:
> > The qmp-cmd-test test takes typically about 15s on my local machine.
> > On the k8s runners it takes usually 20s but sometimes about 60s,
> > because the k8s runners have wildly variable execution time.  If
> > they're running slow, we hit the default timeout.  Bump the
> > qmp-cmd-test timeout to 120s to avoid this.
> >
> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> > ---
> >   tests/qtest/meson.build | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
> > index 2b90abf0007..b207e386965 100644
> > --- a/tests/qtest/meson.build
> > +++ b/tests/qtest/meson.build
> > @@ -7,6 +7,7 @@ slow_qtests = {
> >     'migration-test' : 480,
> >     'npcm7xx_pwm-test': 300,
> >     'npcm7xx_watchdog_timer-test': 120,
> > +  'qmp-cmd-test' : 120,
> >     'qom-test' : 900,
> >     'stm32l4x5_usart-test' : 600,
> >     'test-hmp' : 240,
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>

Applied directly to hopefully reduce CI flakiness.

thanks
-- PMM
diff mbox series

Patch

diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
index 2b90abf0007..b207e386965 100644
--- a/tests/qtest/meson.build
+++ b/tests/qtest/meson.build
@@ -7,6 +7,7 @@  slow_qtests = {
   'migration-test' : 480,
   'npcm7xx_pwm-test': 300,
   'npcm7xx_watchdog_timer-test': 120,
+  'qmp-cmd-test' : 120,
   'qom-test' : 900,
   'stm32l4x5_usart-test' : 600,
   'test-hmp' : 240,