[Linaro-uefi] Platform/Hisilicon/HiKey: add PcdLib dependancy in UiApp

Message ID 1479950943-25702-1-git-send-email-haojian.zhuang@linaro.org
State New
Headers show

Commit Message

Haojian Zhuang Nov. 24, 2016, 1:29 a.m.
UiApp needs to access MdeModulePkg/Universal/PCD/Dxe/Pcd.inf.
Otherwise, boot manager menu can't display when ESC key value
is inputed.

Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>
---
 Platforms/Hisilicon/HiKey/HiKey.dsc | 3 +++
 Platforms/Hisilicon/HiKey/HiKey.fdf | 2 ++
 2 files changed, 5 insertions(+)

Comments

Haojian Zhuang Nov. 24, 2016, 1:32 a.m. | #1
On 24 November 2016 at 09:29, Haojian Zhuang <haojian.zhuang@linaro.org> wrote:
> UiApp needs to access MdeModulePkg/Universal/PCD/Dxe/Pcd.inf.
> Otherwise, boot manager menu can't display when ESC key value
> is inputed.
>
> Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>
> ---
>  Platforms/Hisilicon/HiKey/HiKey.dsc | 3 +++
>  Platforms/Hisilicon/HiKey/HiKey.fdf | 2 ++
>  2 files changed, 5 insertions(+)
>
> diff --git a/Platforms/Hisilicon/HiKey/HiKey.dsc b/Platforms/Hisilicon/HiKey/HiKey.dsc
> index 4fcc939..cab361e 100644
> --- a/Platforms/Hisilicon/HiKey/HiKey.dsc
> +++ b/Platforms/Hisilicon/HiKey/HiKey.dsc
> @@ -388,6 +388,8 @@
>
>    MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf
>
> +  MdeModulePkg/Universal/PCD/Dxe/Pcd.inf
> +
>    #
>    # GPIO
>    #
> @@ -460,6 +462,7 @@
>        NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf
>        NULL|MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf
>        NULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf
> +      PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf

This line is the key. But I can't find it in ArmVExpress-CTA15-A7.dsc.
I doubt there's the same
ASSERT issue when ESC key is input.

With this fix, we could get the boot manager after ESC key input.

>    }
>    ShellPkg/Application/Shell/Shell.inf {
>      <LibraryClasses>
> diff --git a/Platforms/Hisilicon/HiKey/HiKey.fdf b/Platforms/Hisilicon/HiKey/HiKey.fdf
> index b89a1b6..dcb4440 100644
> --- a/Platforms/Hisilicon/HiKey/HiKey.fdf
> +++ b/Platforms/Hisilicon/HiKey/HiKey.fdf
> @@ -111,6 +111,8 @@ READ_LOCK_STATUS   = TRUE
>
>    INF MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf
>
> +  INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf
> +
>    #
>    # GPIO
>    #
> --
> 2.7.4
>

Patch hide | download patch | download mbox

diff --git a/Platforms/Hisilicon/HiKey/HiKey.dsc b/Platforms/Hisilicon/HiKey/HiKey.dsc
index 4fcc939..cab361e 100644
--- a/Platforms/Hisilicon/HiKey/HiKey.dsc
+++ b/Platforms/Hisilicon/HiKey/HiKey.dsc
@@ -388,6 +388,8 @@ 
 
   MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf
 
+  MdeModulePkg/Universal/PCD/Dxe/Pcd.inf
+
   #
   # GPIO
   #
@@ -460,6 +462,7 @@ 
       NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf
       NULL|MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf
       NULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf
+      PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
   }
   ShellPkg/Application/Shell/Shell.inf {
     <LibraryClasses>
diff --git a/Platforms/Hisilicon/HiKey/HiKey.fdf b/Platforms/Hisilicon/HiKey/HiKey.fdf
index b89a1b6..dcb4440 100644
--- a/Platforms/Hisilicon/HiKey/HiKey.fdf
+++ b/Platforms/Hisilicon/HiKey/HiKey.fdf
@@ -111,6 +111,8 @@  READ_LOCK_STATUS   = TRUE
 
   INF MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf
 
+  INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf
+
   #
   # GPIO
   #