cpufreq: schedutil: Rectify comment in sugov_irq_work() function

Message ID 94dc68617a6c8e42de4f225b1860d9d65d11b4aa.1479975620.git.viresh.kumar@linaro.org
State Accepted
Commit d06e622d3d9206e6a2cc45a0f9a3256da8773ff4
Headers show

Commit Message

Viresh Kumar Nov. 24, 2016, 8:21 a.m.
This patch rectifies a comment present in sugov_irq_work() function to
follow proper grammar.

Suggested-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

---
 kernel/sched/cpufreq_schedutil.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

-- 
2.7.1.410.g6faf27b

--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Ingo Molnar Nov. 24, 2016, 8:45 a.m. | #1
* Viresh Kumar <viresh.kumar@linaro.org> wrote:

> This patch rectifies a comment present in sugov_irq_work() function to

> follow proper grammar.

> 

> Suggested-by: Ingo Molnar <mingo@kernel.org>

> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

> ---

>  kernel/sched/cpufreq_schedutil.c | 12 ++++++------

>  1 file changed, 6 insertions(+), 6 deletions(-)

> 

> diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c

> index 42a220e78f00..71e1a980d40a 100644

> --- a/kernel/sched/cpufreq_schedutil.c

> +++ b/kernel/sched/cpufreq_schedutil.c

> @@ -315,15 +315,15 @@ static void sugov_irq_work(struct irq_work *irq_work)

>  	sg_policy = container_of(irq_work, struct sugov_policy, irq_work);

>  

>  	/*

> +	 * For Real Time and Deadline tasks, the schedutil governor shoots the

> +	 * frequency to maximum. Special care must be taken to ensure that this

> +	 * kthread doesn't result in the same behavior.

>  	 *

>  	 * This is (mostly) guaranteed by the work_in_progress flag. The flag is

> +	 * updated only at the end of the sugov_work() function and before that

> +	 * the schedutil governor rejects all other frequency scaling requests.

>  	 *

> +	 * There is a very rare case though, where the RT thread yields right

>  	 * after the work_in_progress flag is cleared. The effects of that are

>  	 * neglected for now.

>  	 */


Also:

  s/Real Time task/RT task
  s/Deadline task/deadline task

With those:

  Acked-by: Ingo Molnar <mingo@kernel.org>


Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
index 42a220e78f00..71e1a980d40a 100644
--- a/kernel/sched/cpufreq_schedutil.c
+++ b/kernel/sched/cpufreq_schedutil.c
@@ -315,15 +315,15 @@  static void sugov_irq_work(struct irq_work *irq_work)
 	sg_policy = container_of(irq_work, struct sugov_policy, irq_work);
 
 	/*
-	 * For Real Time and Deadline tasks, schedutil governor shoots the
-	 * frequency to maximum. And special care must be taken to ensure that
-	 * this kthread doesn't result in that.
+	 * For Real Time and Deadline tasks, the schedutil governor shoots the
+	 * frequency to maximum. Special care must be taken to ensure that this
+	 * kthread doesn't result in the same behavior.
 	 *
 	 * This is (mostly) guaranteed by the work_in_progress flag. The flag is
-	 * updated only at the end of the sugov_work() and before that schedutil
-	 * rejects all other frequency scaling requests.
+	 * updated only at the end of the sugov_work() function and before that
+	 * the schedutil governor rejects all other frequency scaling requests.
 	 *
-	 * Though there is a very rare case where the RT thread yields right
+	 * There is a very rare case though, where the RT thread yields right
 	 * after the work_in_progress flag is cleared. The effects of that are
 	 * neglected for now.
 	 */