[1/2] exynos5: pinmux: Added default pinumx settings

Message ID 1336114597-11852-1-git-send-email-rajeshwari.s@samsung.com
State New
Headers show

Commit Message

Rajeshwari Shinde May 4, 2012, 6:56 a.m.
This patch performs the pinmux configuration in a common file.
As of now only Exynos5 pinmux for SDMMC, UART and Ethernet is
supported.

Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
Signed-off-by: Che-Liang Chiou <clchiou@chromium.org>
Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
---
 arch/arm/cpu/armv7/exynos/pinmux.c        |  189 +++++++++++++++++++++++++++++
 arch/arm/include/asm/arch-exynos/pinmux.h |   77 ++++++++++++
 2 files changed, 266 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/cpu/armv7/exynos/pinmux.c
 create mode 100644 arch/arm/include/asm/arch-exynos/pinmux.h

Comments

Rajeshwari Birje May 18, 2012, 6:46 a.m. | #1
Hi All,

Please do let me know if any updates on the this patchset.

On Fri, May 4, 2012 at 12:26 PM, Rajeshwari Shinde
<rajeshwari.s@samsung.com> wrote:
> This patch performs the pinmux configuration in a common file.
> As of now only Exynos5 pinmux for SDMMC, UART and Ethernet is
> supported.
>
> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
> Signed-off-by: Che-Liang Chiou <clchiou@chromium.org>
> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
> ---
>  arch/arm/cpu/armv7/exynos/pinmux.c        |  189 +++++++++++++++++++++++++++++
>  arch/arm/include/asm/arch-exynos/pinmux.h |   77 ++++++++++++
>  2 files changed, 266 insertions(+), 0 deletions(-)
>  create mode 100644 arch/arm/cpu/armv7/exynos/pinmux.c
>  create mode 100644 arch/arm/include/asm/arch-exynos/pinmux.h
>
> diff --git a/arch/arm/cpu/armv7/exynos/pinmux.c b/arch/arm/cpu/armv7/exynos/pinmux.c
> new file mode 100644
> index 0000000..11f4b71
> --- /dev/null
> +++ b/arch/arm/cpu/armv7/exynos/pinmux.c
> @@ -0,0 +1,189 @@
> +/*
> + * Copyright (c) 2012 Samsung Electronics.
> + * Abhilash Kesavan <a.kesavan@samsung.com>
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +#include <common.h>
> +#include <asm/arch/cpu.h>
> +#include <asm/arch/gpio.h>
> +#include <asm/arch/pinmux.h>
> +#include <asm/arch/sromc.h>
> +
> +int exynos5_pinmux_config(int peripheral, int flags)
> +{
> +       struct exynos5_gpio_part1 *gpio1 =
> +               (struct exynos5_gpio_part1 *) samsung_get_base_gpio_part1();
> +       struct s5p_gpio_bank *bank, *bank_ext;
> +       int i, start, count;
> +
> +       switch (peripheral) {
> +       case PERIPH_ID_UART0:
> +       case PERIPH_ID_UART1:
> +       case PERIPH_ID_UART2:
> +       case PERIPH_ID_UART3:
> +               switch (peripheral) {
> +               case PERIPH_ID_UART0:
> +                       bank = &gpio1->a0;
> +                       start = 0; count = 4;
> +                       break;
> +               case PERIPH_ID_UART1:
> +                       bank = &gpio1->a0;
> +                       start = 4; count = 4;
> +                       break;
> +               case PERIPH_ID_UART2:
> +                       bank = &gpio1->a1;
> +                       start = 0; count = 4;
> +                       break;
> +               case PERIPH_ID_UART3:
> +                       bank = &gpio1->a1;
> +                       start = 4; count = 2;
> +                       break;
> +               }
> +               for (i = start; i < start + count; i++) {
> +                       s5p_gpio_set_pull(bank, i, GPIO_PULL_NONE);
> +                       s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2));
> +               }
> +               break;
> +       case PERIPH_ID_SDMMC0:
> +       case PERIPH_ID_SDMMC1:
> +       case PERIPH_ID_SDMMC2:
> +       case PERIPH_ID_SDMMC3:
> +               switch (peripheral) {
> +               case PERIPH_ID_SDMMC0:
> +                       bank = &gpio1->c0; bank_ext = &gpio1->c1;
> +                       break;
> +               case PERIPH_ID_SDMMC1:
> +                       bank = &gpio1->c1; bank_ext = NULL;
> +                       break;
> +               case PERIPH_ID_SDMMC2:
> +                       bank = &gpio1->c2; bank_ext = &gpio1->c3;
> +                       break;
> +               case PERIPH_ID_SDMMC3:
> +                       bank = &gpio1->c3; bank_ext = NULL;
> +                       break;
> +               }
> +               if ((flags & PINMUX_FLAG_8BIT_MODE) && !bank_ext) {
> +                       debug("SDMMC device %d does not support 8bit mode",
> +                                       peripheral);
> +                       return -1;
> +               }
> +               if (flags & PINMUX_FLAG_8BIT_MODE) {
> +                       for (i = 3; i <= 6; i++) {
> +                               s5p_gpio_cfg_pin(bank_ext, i, GPIO_FUNC(0x3));
> +                               s5p_gpio_set_pull(bank_ext, i, GPIO_PULL_UP);
> +                               s5p_gpio_set_drv(bank_ext, i, GPIO_DRV_4X);
> +                       }
> +               }
> +               for (i = 0; i < 2; i++) {
> +                       s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2));
> +                       s5p_gpio_set_pull(bank, i, GPIO_PULL_NONE);
> +                       s5p_gpio_set_drv(bank, i, GPIO_DRV_4X);
> +               }
> +               for (i = 3; i <= 6; i++) {
> +                       s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2));
> +                       s5p_gpio_set_pull(bank, i, GPIO_PULL_UP);
> +                       s5p_gpio_set_drv(bank, i, GPIO_DRV_4X);
> +               }
> +               break;
> +       case PERIPH_ID_SROMC:
> +               /*
> +                * SROM:CS1 and EBI
> +                *
> +                * GPY0[0]      SROM_CSn[0]
> +                * GPY0[1]      SROM_CSn[1](2)
> +                * GPY0[2]      SROM_CSn[2]
> +                * GPY0[3]      SROM_CSn[3]
> +                * GPY0[4]      EBI_OEn(2)
> +                * GPY0[5]      EBI_EEn(2)
> +                *
> +                * GPY1[0]      EBI_BEn[0](2)
> +                * GPY1[1]      EBI_BEn[1](2)
> +                * GPY1[2]      SROM_WAIT(2)
> +                * GPY1[3]      EBI_DATA_RDn(2)
> +                */
> +               s5p_gpio_cfg_pin(&gpio1->y0, (flags & PINMUX_FLAG_BANK),
> +                                       GPIO_FUNC(2));
> +               s5p_gpio_cfg_pin(&gpio1->y0, 4, GPIO_FUNC(2));
> +               s5p_gpio_cfg_pin(&gpio1->y0, 5, GPIO_FUNC(2));
> +
> +               for (i = 0; i < 4; i++)
> +                       s5p_gpio_cfg_pin(&gpio1->y1, i, GPIO_FUNC(2));
> +
> +               /*
> +                * EBI: 8 Addrss Lines
> +                *
> +                * GPY3[0]      EBI_ADDR[0](2)
> +                * GPY3[1]      EBI_ADDR[1](2)
> +                * GPY3[2]      EBI_ADDR[2](2)
> +                * GPY3[3]      EBI_ADDR[3](2)
> +                * GPY3[4]      EBI_ADDR[4](2)
> +                * GPY3[5]      EBI_ADDR[5](2)
> +                * GPY3[6]      EBI_ADDR[6](2)
> +                * GPY3[7]      EBI_ADDR[7](2)
> +                *
> +                * EBI: 16 Data Lines
> +                *
> +                * GPY5[0]      EBI_DATA[0](2)
> +                * GPY5[1]      EBI_DATA[1](2)
> +                * GPY5[2]      EBI_DATA[2](2)
> +                * GPY5[3]      EBI_DATA[3](2)
> +                * GPY5[4]      EBI_DATA[4](2)
> +                * GPY5[5]      EBI_DATA[5](2)
> +                * GPY5[6]      EBI_DATA[6](2)
> +                * GPY5[7]      EBI_DATA[7](2)
> +                *
> +                * GPY6[0]      EBI_DATA[8](2)
> +                * GPY6[1]      EBI_DATA[9](2)
> +                * GPY6[2]      EBI_DATA[10](2)
> +                * GPY6[3]      EBI_DATA[11](2)
> +                * GPY6[4]      EBI_DATA[12](2)
> +                * GPY6[5]      EBI_DATA[13](2)
> +                * GPY6[6]      EBI_DATA[14](2)
> +                * GPY6[7]      EBI_DATA[15](2)
> +                */
> +               for (i = 0; i < 8; i++) {
> +                       s5p_gpio_cfg_pin(&gpio1->y3, i, GPIO_FUNC(2));
> +                       s5p_gpio_set_pull(&gpio1->y3, i, GPIO_PULL_UP);
> +
> +                       s5p_gpio_cfg_pin(&gpio1->y5, i, GPIO_FUNC(2));
> +                       s5p_gpio_set_pull(&gpio1->y5, i, GPIO_PULL_UP);
> +
> +                       s5p_gpio_cfg_pin(&gpio1->y6, i, GPIO_FUNC(2));
> +                       s5p_gpio_set_pull(&gpio1->y6, i, GPIO_PULL_UP);
> +               }
> +               break;
> +       default:
> +               debug("%s: invalid peripheral %d", __func__, peripheral);
> +               return -1;
> +       }
> +
> +       return 0;
> +}
> +
> +int exynos_pinmux_config(int peripheral, int flags)
> +{
> +       if (cpu_is_exynos5())
> +               return exynos5_pinmux_config(peripheral, flags);
> +       else{
> +               debug("pinmux functionality not supported\n");
> +               return -1;
> +       }
> +}
> diff --git a/arch/arm/include/asm/arch-exynos/pinmux.h b/arch/arm/include/asm/arch-exynos/pinmux.h
> new file mode 100644
> index 0000000..306f521
> --- /dev/null
> +++ b/arch/arm/include/asm/arch-exynos/pinmux.h
> @@ -0,0 +1,77 @@
> +/*
> + * Copyright (C) 2012 Samsung Electronics
> + * Abhilash Kesavan <a.kesavan@samsung.com>
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +#ifndef __ASM_ARM_ARCH_PINMUX_H
> +#define __ASM_ARM_ARCH_PINMUX_H
> +
> +/*
> + * Peripherals requiring clock/pinmux configuration. List will
> + * grow with support for more devices getting added.
> + *
> + */
> +enum periph_id {
> +       PERIPH_ID_SDMMC0,
> +       PERIPH_ID_SDMMC1,
> +       PERIPH_ID_SDMMC2,
> +       PERIPH_ID_SDMMC3,
> +       PERIPH_ID_SDMMC4,
> +       PERIPH_ID_SROMC,
> +       PERIPH_ID_UART0,
> +       PERIPH_ID_UART1,
> +       PERIPH_ID_UART2,
> +       PERIPH_ID_UART3,
> +
> +       PERIPH_ID_COUNT,
> +       PERIPH_ID_NONE = -1,
> +};
> +
> +/*
> + * Flags for setting specific configarations of peripherals.
> + * List will grow with support for more devices getting added.
> + */
> +enum {
> +       PINMUX_FLAG_NONE        = 0x00000000,
> +
> +       /* Flags for eMMC */
> +       PINMUX_FLAG_8BIT_MODE   = 1 << 0,       /* SDMMC 8-bit mode */
> +
> +       /* Flags for SROM controller */
> +       PINMUX_FLAG_BANK        = 3 << 0,       /* bank number (0-3) */
> +       PINMUX_FLAG_16BIT       = 1 << 2,       /* 16-bit width */
> +};
> +
> +/**
> + * Configures the pinmux for a particular peripheral.
> + *
> + * Each gpio can be configured in many different ways (4 bits on exynos)
> + * such as "input", "output", "special function", "external interrupt"
> + * etc. This function will configure the peripheral pinmux along with
> + * pull-up/down and drive strength.
> + *
> + * @param peripheral   peripheral to be configured
> + * @param flags                configure flags
> + * @return 0 if ok, -1 on error (e.g. unsupported peripheral)
> + */
> +int exynos_pinmux_config(int peripheral, int flags);
> +
> +#endif
> --
> 1.7.4.4
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

Regards,
Rajeshwari Shinde.
Chander Kashyap May 18, 2012, 8:58 a.m. | #2
ccng to Minkyu

---------- Forwarded message ----------
From: Rajeshwari Birje <rajeshwari.birje@gmail.com>
Date: 18 May 2012 12:16
Subject: Re: [U-Boot] [PATCH 1/2] exynos5: pinmux: Added default pinumx settings
To: Rajeshwari Shinde <rajeshwari.s@samsung.com>
Cc: marex@denx.de, k.chander@samsung.com, patches@linaro.org,
u-boot@lists.denx.de


Hi All,

Please do let me know if any updates on the this patchset.

On Fri, May 4, 2012 at 12:26 PM, Rajeshwari Shinde
<rajeshwari.s@samsung.com> wrote:
> This patch performs the pinmux configuration in a common file.
> As of now only Exynos5 pinmux for SDMMC, UART and Ethernet is
> supported.
>
> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
> Signed-off-by: Che-Liang Chiou <clchiou@chromium.org>
> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
> ---
>  arch/arm/cpu/armv7/exynos/pinmux.c        |  189 +++++++++++++++++++++++++++++
>  arch/arm/include/asm/arch-exynos/pinmux.h |   77 ++++++++++++
>  2 files changed, 266 insertions(+), 0 deletions(-)
>  create mode 100644 arch/arm/cpu/armv7/exynos/pinmux.c
>  create mode 100644 arch/arm/include/asm/arch-exynos/pinmux.h
>
> diff --git a/arch/arm/cpu/armv7/exynos/pinmux.c b/arch/arm/cpu/armv7/exynos/pinmux.c
> new file mode 100644
> index 0000000..11f4b71
> --- /dev/null
> +++ b/arch/arm/cpu/armv7/exynos/pinmux.c
> @@ -0,0 +1,189 @@
> +/*
> + * Copyright (c) 2012 Samsung Electronics.
> + * Abhilash Kesavan <a.kesavan@samsung.com>
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +#include <common.h>
> +#include <asm/arch/cpu.h>
> +#include <asm/arch/gpio.h>
> +#include <asm/arch/pinmux.h>
> +#include <asm/arch/sromc.h>
> +
> +int exynos5_pinmux_config(int peripheral, int flags)
> +{
> +       struct exynos5_gpio_part1 *gpio1 =
> +               (struct exynos5_gpio_part1 *) samsung_get_base_gpio_part1();
> +       struct s5p_gpio_bank *bank, *bank_ext;
> +       int i, start, count;
> +
> +       switch (peripheral) {
> +       case PERIPH_ID_UART0:
> +       case PERIPH_ID_UART1:
> +       case PERIPH_ID_UART2:
> +       case PERIPH_ID_UART3:
> +               switch (peripheral) {
> +               case PERIPH_ID_UART0:
> +                       bank = &gpio1->a0;
> +                       start = 0; count = 4;
> +                       break;
> +               case PERIPH_ID_UART1:
> +                       bank = &gpio1->a0;
> +                       start = 4; count = 4;
> +                       break;
> +               case PERIPH_ID_UART2:
> +                       bank = &gpio1->a1;
> +                       start = 0; count = 4;
> +                       break;
> +               case PERIPH_ID_UART3:
> +                       bank = &gpio1->a1;
> +                       start = 4; count = 2;
> +                       break;
> +               }
> +               for (i = start; i < start + count; i++) {
> +                       s5p_gpio_set_pull(bank, i, GPIO_PULL_NONE);
> +                       s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2));
> +               }
> +               break;
> +       case PERIPH_ID_SDMMC0:
> +       case PERIPH_ID_SDMMC1:
> +       case PERIPH_ID_SDMMC2:
> +       case PERIPH_ID_SDMMC3:
> +               switch (peripheral) {
> +               case PERIPH_ID_SDMMC0:
> +                       bank = &gpio1->c0; bank_ext = &gpio1->c1;
> +                       break;
> +               case PERIPH_ID_SDMMC1:
> +                       bank = &gpio1->c1; bank_ext = NULL;
> +                       break;
> +               case PERIPH_ID_SDMMC2:
> +                       bank = &gpio1->c2; bank_ext = &gpio1->c3;
> +                       break;
> +               case PERIPH_ID_SDMMC3:
> +                       bank = &gpio1->c3; bank_ext = NULL;
> +                       break;
> +               }
> +               if ((flags & PINMUX_FLAG_8BIT_MODE) && !bank_ext) {
> +                       debug("SDMMC device %d does not support 8bit mode",
> +                                       peripheral);
> +                       return -1;
> +               }
> +               if (flags & PINMUX_FLAG_8BIT_MODE) {
> +                       for (i = 3; i <= 6; i++) {
> +                               s5p_gpio_cfg_pin(bank_ext, i, GPIO_FUNC(0x3));
> +                               s5p_gpio_set_pull(bank_ext, i, GPIO_PULL_UP);
> +                               s5p_gpio_set_drv(bank_ext, i, GPIO_DRV_4X);
> +                       }
> +               }
> +               for (i = 0; i < 2; i++) {
> +                       s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2));
> +                       s5p_gpio_set_pull(bank, i, GPIO_PULL_NONE);
> +                       s5p_gpio_set_drv(bank, i, GPIO_DRV_4X);
> +               }
> +               for (i = 3; i <= 6; i++) {
> +                       s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2));
> +                       s5p_gpio_set_pull(bank, i, GPIO_PULL_UP);
> +                       s5p_gpio_set_drv(bank, i, GPIO_DRV_4X);
> +               }
> +               break;
> +       case PERIPH_ID_SROMC:
> +               /*
> +                * SROM:CS1 and EBI
> +                *
> +                * GPY0[0]      SROM_CSn[0]
> +                * GPY0[1]      SROM_CSn[1](2)
> +                * GPY0[2]      SROM_CSn[2]
> +                * GPY0[3]      SROM_CSn[3]
> +                * GPY0[4]      EBI_OEn(2)
> +                * GPY0[5]      EBI_EEn(2)
> +                *
> +                * GPY1[0]      EBI_BEn[0](2)
> +                * GPY1[1]      EBI_BEn[1](2)
> +                * GPY1[2]      SROM_WAIT(2)
> +                * GPY1[3]      EBI_DATA_RDn(2)
> +                */
> +               s5p_gpio_cfg_pin(&gpio1->y0, (flags & PINMUX_FLAG_BANK),
> +                                       GPIO_FUNC(2));
> +               s5p_gpio_cfg_pin(&gpio1->y0, 4, GPIO_FUNC(2));
> +               s5p_gpio_cfg_pin(&gpio1->y0, 5, GPIO_FUNC(2));
> +
> +               for (i = 0; i < 4; i++)
> +                       s5p_gpio_cfg_pin(&gpio1->y1, i, GPIO_FUNC(2));
> +
> +               /*
> +                * EBI: 8 Addrss Lines
> +                *
> +                * GPY3[0]      EBI_ADDR[0](2)
> +                * GPY3[1]      EBI_ADDR[1](2)
> +                * GPY3[2]      EBI_ADDR[2](2)
> +                * GPY3[3]      EBI_ADDR[3](2)
> +                * GPY3[4]      EBI_ADDR[4](2)
> +                * GPY3[5]      EBI_ADDR[5](2)
> +                * GPY3[6]      EBI_ADDR[6](2)
> +                * GPY3[7]      EBI_ADDR[7](2)
> +                *
> +                * EBI: 16 Data Lines
> +                *
> +                * GPY5[0]      EBI_DATA[0](2)
> +                * GPY5[1]      EBI_DATA[1](2)
> +                * GPY5[2]      EBI_DATA[2](2)
> +                * GPY5[3]      EBI_DATA[3](2)
> +                * GPY5[4]      EBI_DATA[4](2)
> +                * GPY5[5]      EBI_DATA[5](2)
> +                * GPY5[6]      EBI_DATA[6](2)
> +                * GPY5[7]      EBI_DATA[7](2)
> +                *
> +                * GPY6[0]      EBI_DATA[8](2)
> +                * GPY6[1]      EBI_DATA[9](2)
> +                * GPY6[2]      EBI_DATA[10](2)
> +                * GPY6[3]      EBI_DATA[11](2)
> +                * GPY6[4]      EBI_DATA[12](2)
> +                * GPY6[5]      EBI_DATA[13](2)
> +                * GPY6[6]      EBI_DATA[14](2)
> +                * GPY6[7]      EBI_DATA[15](2)
> +                */
> +               for (i = 0; i < 8; i++) {
> +                       s5p_gpio_cfg_pin(&gpio1->y3, i, GPIO_FUNC(2));
> +                       s5p_gpio_set_pull(&gpio1->y3, i, GPIO_PULL_UP);
> +
> +                       s5p_gpio_cfg_pin(&gpio1->y5, i, GPIO_FUNC(2));
> +                       s5p_gpio_set_pull(&gpio1->y5, i, GPIO_PULL_UP);
> +
> +                       s5p_gpio_cfg_pin(&gpio1->y6, i, GPIO_FUNC(2));
> +                       s5p_gpio_set_pull(&gpio1->y6, i, GPIO_PULL_UP);
> +               }
> +               break;
> +       default:
> +               debug("%s: invalid peripheral %d", __func__, peripheral);
> +               return -1;
> +       }
> +
> +       return 0;
> +}
> +
> +int exynos_pinmux_config(int peripheral, int flags)
> +{
> +       if (cpu_is_exynos5())
> +               return exynos5_pinmux_config(peripheral, flags);
> +       else{
> +               debug("pinmux functionality not supported\n");
> +               return -1;
> +       }
> +}
> diff --git a/arch/arm/include/asm/arch-exynos/pinmux.h b/arch/arm/include/asm/arch-exynos/pinmux.h
> new file mode 100644
> index 0000000..306f521
> --- /dev/null
> +++ b/arch/arm/include/asm/arch-exynos/pinmux.h
> @@ -0,0 +1,77 @@
> +/*
> + * Copyright (C) 2012 Samsung Electronics
> + * Abhilash Kesavan <a.kesavan@samsung.com>
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +#ifndef __ASM_ARM_ARCH_PINMUX_H
> +#define __ASM_ARM_ARCH_PINMUX_H
> +
> +/*
> + * Peripherals requiring clock/pinmux configuration. List will
> + * grow with support for more devices getting added.
> + *
> + */
> +enum periph_id {
> +       PERIPH_ID_SDMMC0,
> +       PERIPH_ID_SDMMC1,
> +       PERIPH_ID_SDMMC2,
> +       PERIPH_ID_SDMMC3,
> +       PERIPH_ID_SDMMC4,
> +       PERIPH_ID_SROMC,
> +       PERIPH_ID_UART0,
> +       PERIPH_ID_UART1,
> +       PERIPH_ID_UART2,
> +       PERIPH_ID_UART3,
> +
> +       PERIPH_ID_COUNT,
> +       PERIPH_ID_NONE = -1,
> +};
> +
> +/*
> + * Flags for setting specific configarations of peripherals.
> + * List will grow with support for more devices getting added.
> + */
> +enum {
> +       PINMUX_FLAG_NONE        = 0x00000000,
> +
> +       /* Flags for eMMC */
> +       PINMUX_FLAG_8BIT_MODE   = 1 << 0,       /* SDMMC 8-bit mode */
> +
> +       /* Flags for SROM controller */
> +       PINMUX_FLAG_BANK        = 3 << 0,       /* bank number (0-3) */
> +       PINMUX_FLAG_16BIT       = 1 << 2,       /* 16-bit width */
> +};
> +
> +/**
> + * Configures the pinmux for a particular peripheral.
> + *
> + * Each gpio can be configured in many different ways (4 bits on exynos)
> + * such as "input", "output", "special function", "external interrupt"
> + * etc. This function will configure the peripheral pinmux along with
> + * pull-up/down and drive strength.
> + *
> + * @param peripheral   peripheral to be configured
> + * @param flags                configure flags
> + * @return 0 if ok, -1 on error (e.g. unsupported peripheral)
> + */
> +int exynos_pinmux_config(int peripheral, int flags);
> +
> +#endif
> --
> 1.7.4.4
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

Regards,
Rajeshwari Shinde.
Chander Kashyap May 23, 2012, 6:12 a.m. | #3
Hi,

On 4 May 2012 12:26, Rajeshwari Shinde <rajeshwari.s@samsung.com> wrote:
> This patch performs the pinmux configuration in a common file.
> As of now only Exynos5 pinmux for SDMMC, UART and Ethernet is
> supported.
>
> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
> Signed-off-by: Che-Liang Chiou <clchiou@chromium.org>
> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
> ---
>  arch/arm/cpu/armv7/exynos/pinmux.c        |  189 +++++++++++++++++++++++++++++
>  arch/arm/include/asm/arch-exynos/pinmux.h |   77 ++++++++++++
>  2 files changed, 266 insertions(+), 0 deletions(-)
>  create mode 100644 arch/arm/cpu/armv7/exynos/pinmux.c
>  create mode 100644 arch/arm/include/asm/arch-exynos/pinmux.h
>
> diff --git a/arch/arm/cpu/armv7/exynos/pinmux.c b/arch/arm/cpu/armv7/exynos/pinmux.c
> new file mode 100644
> index 0000000..11f4b71
> --- /dev/null
> +++ b/arch/arm/cpu/armv7/exynos/pinmux.c
> @@ -0,0 +1,189 @@
> +/*
> + * Copyright (c) 2012 Samsung Electronics.
> + * Abhilash Kesavan <a.kesavan@samsung.com>
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +#include <common.h>
> +#include <asm/arch/cpu.h>
> +#include <asm/arch/gpio.h>
> +#include <asm/arch/pinmux.h>
> +#include <asm/arch/sromc.h>
> +
> +int exynos5_pinmux_config(int peripheral, int flags)
It should be static
> +{
> +       struct exynos5_gpio_part1 *gpio1 =
> +               (struct exynos5_gpio_part1 *) samsung_get_base_gpio_part1();
> +       struct s5p_gpio_bank *bank, *bank_ext;
> +       int i, start, count;
> +
> +       switch (peripheral) {
> +       case PERIPH_ID_UART0:
> +       case PERIPH_ID_UART1:
> +       case PERIPH_ID_UART2:
> +       case PERIPH_ID_UART3:
> +               switch (peripheral) {
> +               case PERIPH_ID_UART0:
> +                       bank = &gpio1->a0;
> +                       start = 0; count = 4;
> +                       break;
> +               case PERIPH_ID_UART1:
> +                       bank = &gpio1->a0;
> +                       start = 4; count = 4;
> +                       break;
> +               case PERIPH_ID_UART2:
> +                       bank = &gpio1->a1;
> +                       start = 0; count = 4;
> +                       break;
> +               case PERIPH_ID_UART3:
> +                       bank = &gpio1->a1;
> +                       start = 4; count = 2;
> +                       break;
> +               }
> +               for (i = start; i < start + count; i++) {
> +                       s5p_gpio_set_pull(bank, i, GPIO_PULL_NONE);
> +                       s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2));
> +               }
> +               break;
> +       case PERIPH_ID_SDMMC0:
> +       case PERIPH_ID_SDMMC1:
> +       case PERIPH_ID_SDMMC2:
> +       case PERIPH_ID_SDMMC3:
> +               switch (peripheral) {
> +               case PERIPH_ID_SDMMC0:
> +                       bank = &gpio1->c0; bank_ext = &gpio1->c1;
> +                       break;
> +               case PERIPH_ID_SDMMC1:
> +                       bank = &gpio1->c1; bank_ext = NULL;
> +                       break;
> +               case PERIPH_ID_SDMMC2:
> +                       bank = &gpio1->c2; bank_ext = &gpio1->c3;
> +                       break;
> +               case PERIPH_ID_SDMMC3:
> +                       bank = &gpio1->c3; bank_ext = NULL;
> +                       break;
> +               }
> +               if ((flags & PINMUX_FLAG_8BIT_MODE) && !bank_ext) {
> +                       debug("SDMMC device %d does not support 8bit mode",
> +                                       peripheral);
> +                       return -1;
> +               }
> +               if (flags & PINMUX_FLAG_8BIT_MODE) {
> +                       for (i = 3; i <= 6; i++) {
> +                               s5p_gpio_cfg_pin(bank_ext, i, GPIO_FUNC(0x3));
> +                               s5p_gpio_set_pull(bank_ext, i, GPIO_PULL_UP);
> +                               s5p_gpio_set_drv(bank_ext, i, GPIO_DRV_4X);
> +                       }
> +               }
> +               for (i = 0; i < 2; i++) {
> +                       s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2));
> +                       s5p_gpio_set_pull(bank, i, GPIO_PULL_NONE);
> +                       s5p_gpio_set_drv(bank, i, GPIO_DRV_4X);
> +               }
> +               for (i = 3; i <= 6; i++) {
> +                       s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2));
> +                       s5p_gpio_set_pull(bank, i, GPIO_PULL_UP);
> +                       s5p_gpio_set_drv(bank, i, GPIO_DRV_4X);
> +               }
> +               break;
> +       case PERIPH_ID_SROMC:
> +               /*
> +                * SROM:CS1 and EBI
> +                *
> +                * GPY0[0]      SROM_CSn[0]
> +                * GPY0[1]      SROM_CSn[1](2)
> +                * GPY0[2]      SROM_CSn[2]
> +                * GPY0[3]      SROM_CSn[3]
> +                * GPY0[4]      EBI_OEn(2)
> +                * GPY0[5]      EBI_EEn(2)
> +                *
> +                * GPY1[0]      EBI_BEn[0](2)
> +                * GPY1[1]      EBI_BEn[1](2)
> +                * GPY1[2]      SROM_WAIT(2)
> +                * GPY1[3]      EBI_DATA_RDn(2)
> +                */
> +               s5p_gpio_cfg_pin(&gpio1->y0, (flags & PINMUX_FLAG_BANK),
> +                                       GPIO_FUNC(2));
> +               s5p_gpio_cfg_pin(&gpio1->y0, 4, GPIO_FUNC(2));
> +               s5p_gpio_cfg_pin(&gpio1->y0, 5, GPIO_FUNC(2));
> +
> +               for (i = 0; i < 4; i++)
> +                       s5p_gpio_cfg_pin(&gpio1->y1, i, GPIO_FUNC(2));
> +
> +               /*
> +                * EBI: 8 Addrss Lines
> +                *
> +                * GPY3[0]      EBI_ADDR[0](2)
> +                * GPY3[1]      EBI_ADDR[1](2)
> +                * GPY3[2]      EBI_ADDR[2](2)
> +                * GPY3[3]      EBI_ADDR[3](2)
> +                * GPY3[4]      EBI_ADDR[4](2)
> +                * GPY3[5]      EBI_ADDR[5](2)
> +                * GPY3[6]      EBI_ADDR[6](2)
> +                * GPY3[7]      EBI_ADDR[7](2)
> +                *
> +                * EBI: 16 Data Lines
> +                *
> +                * GPY5[0]      EBI_DATA[0](2)
> +                * GPY5[1]      EBI_DATA[1](2)
> +                * GPY5[2]      EBI_DATA[2](2)
> +                * GPY5[3]      EBI_DATA[3](2)
> +                * GPY5[4]      EBI_DATA[4](2)
> +                * GPY5[5]      EBI_DATA[5](2)
> +                * GPY5[6]      EBI_DATA[6](2)
> +                * GPY5[7]      EBI_DATA[7](2)
> +                *
> +                * GPY6[0]      EBI_DATA[8](2)
> +                * GPY6[1]      EBI_DATA[9](2)
> +                * GPY6[2]      EBI_DATA[10](2)
> +                * GPY6[3]      EBI_DATA[11](2)
> +                * GPY6[4]      EBI_DATA[12](2)
> +                * GPY6[5]      EBI_DATA[13](2)
> +                * GPY6[6]      EBI_DATA[14](2)
> +                * GPY6[7]      EBI_DATA[15](2)
> +                */
> +               for (i = 0; i < 8; i++) {
> +                       s5p_gpio_cfg_pin(&gpio1->y3, i, GPIO_FUNC(2));
> +                       s5p_gpio_set_pull(&gpio1->y3, i, GPIO_PULL_UP);
> +
> +                       s5p_gpio_cfg_pin(&gpio1->y5, i, GPIO_FUNC(2));
> +                       s5p_gpio_set_pull(&gpio1->y5, i, GPIO_PULL_UP);
> +
> +                       s5p_gpio_cfg_pin(&gpio1->y6, i, GPIO_FUNC(2));
> +                       s5p_gpio_set_pull(&gpio1->y6, i, GPIO_PULL_UP);
> +               }
> +               break;
> +       default:
> +               debug("%s: invalid peripheral %d", __func__, peripheral);
> +               return -1;
> +       }
> +
> +       return 0;
> +}
> +
> +int exynos_pinmux_config(int peripheral, int flags)
> +{
> +       if (cpu_is_exynos5())
> +               return exynos5_pinmux_config(peripheral, flags);
> +       else{
> +               debug("pinmux functionality not supported\n");
> +               return -1;
> +       }
> +}
> diff --git a/arch/arm/include/asm/arch-exynos/pinmux.h b/arch/arm/include/asm/arch-exynos/pinmux.h
> new file mode 100644
> index 0000000..306f521
> --- /dev/null
> +++ b/arch/arm/include/asm/arch-exynos/pinmux.h
> @@ -0,0 +1,77 @@
> +/*
> + * Copyright (C) 2012 Samsung Electronics
> + * Abhilash Kesavan <a.kesavan@samsung.com>
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +#ifndef __ASM_ARM_ARCH_PINMUX_H
> +#define __ASM_ARM_ARCH_PINMUX_H
> +
> +/*
> + * Peripherals requiring clock/pinmux configuration. List will
> + * grow with support for more devices getting added.
> + *
> + */
> +enum periph_id {
> +       PERIPH_ID_SDMMC0,
> +       PERIPH_ID_SDMMC1,
> +       PERIPH_ID_SDMMC2,
> +       PERIPH_ID_SDMMC3,
> +       PERIPH_ID_SDMMC4,
> +       PERIPH_ID_SROMC,
> +       PERIPH_ID_UART0,
> +       PERIPH_ID_UART1,
> +       PERIPH_ID_UART2,
> +       PERIPH_ID_UART3,
> +
> +       PERIPH_ID_COUNT,
> +       PERIPH_ID_NONE = -1,
> +};
> +
> +/*
> + * Flags for setting specific configarations of peripherals.
> + * List will grow with support for more devices getting added.
> + */
> +enum {
> +       PINMUX_FLAG_NONE        = 0x00000000,
> +
> +       /* Flags for eMMC */
> +       PINMUX_FLAG_8BIT_MODE   = 1 << 0,       /* SDMMC 8-bit mode */
> +
> +       /* Flags for SROM controller */
> +       PINMUX_FLAG_BANK        = 3 << 0,       /* bank number (0-3) */
> +       PINMUX_FLAG_16BIT       = 1 << 2,       /* 16-bit width */
> +};
> +
> +/**
> + * Configures the pinmux for a particular peripheral.
> + *
> + * Each gpio can be configured in many different ways (4 bits on exynos)
> + * such as "input", "output", "special function", "external interrupt"
> + * etc. This function will configure the peripheral pinmux along with
> + * pull-up/down and drive strength.
> + *
> + * @param peripheral   peripheral to be configured
> + * @param flags                configure flags
> + * @return 0 if ok, -1 on error (e.g. unsupported peripheral)
> + */
> +int exynos_pinmux_config(int peripheral, int flags);
> +
> +#endif
> --
> 1.7.4.4
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
Simon Glass June 1, 2012, 12:33 a.m. | #4
Hi,

On Tue, May 22, 2012 at 11:12 PM, Chander Kashyap <
chander.kashyap@linaro.org> wrote:

> Hi,
>
> On 4 May 2012 12:26, Rajeshwari Shinde <rajeshwari.s@samsung.com> wrote:
> > This patch performs the pinmux configuration in a common file.
> > As of now only Exynos5 pinmux for SDMMC, UART and Ethernet is
> > supported.
> >
> > Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
> > Signed-off-by: Che-Liang Chiou <clchiou@chromium.org>
> > Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
> > ---
> >  arch/arm/cpu/armv7/exynos/pinmux.c        |  189
> +++++++++++++++++++++++++++++
> >  arch/arm/include/asm/arch-exynos/pinmux.h |   77 ++++++++++++
> >  2 files changed, 266 insertions(+), 0 deletions(-)
> >  create mode 100644 arch/arm/cpu/armv7/exynos/pinmux.c
> >  create mode 100644 arch/arm/include/asm/arch-exynos/pinmux.h
> >
> > diff --git a/arch/arm/cpu/armv7/exynos/pinmux.c
> b/arch/arm/cpu/armv7/exynos/pinmux.c
> > new file mode 100644
> > index 0000000..11f4b71
> > --- /dev/null
> > +++ b/arch/arm/cpu/armv7/exynos/pinmux.c
> > @@ -0,0 +1,189 @@
> > +/*
> > + * Copyright (c) 2012 Samsung Electronics.
> > + * Abhilash Kesavan <a.kesavan@samsung.com>
> > + *
> > + * See file CREDITS for list of people who contributed to this
> > + * project.
> > + *
> > + * This program is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU General Public License as
> > + * published by the Free Software Foundation; either version 2 of
> > + * the License, or (at your option) any later version.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > + * GNU General Public License for more details.
> > + *
> > + * You should have received a copy of the GNU General Public License
> > + * along with this program; if not, write to the Free Software
> > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> > + * MA 02111-1307 USA
> > + */
> > +
> > +#include <common.h>
> > +#include <asm/arch/cpu.h>
> > +#include <asm/arch/gpio.h>
> > +#include <asm/arch/pinmux.h>
> > +#include <asm/arch/sromc.h>
> > +
> > +int exynos5_pinmux_config(int peripheral, int flags)
> It should be static
>

It can't be static, as it is called from board files, drivers, etc.



> > +{
> > +       struct exynos5_gpio_part1 *gpio1 =
> > +               (struct exynos5_gpio_part1 *)
> samsung_get_base_gpio_part1();
> > +       struct s5p_gpio_bank *bank, *bank_ext;
> > +       int i, start, count;
> > +
> > +       switch (peripheral) {
> > +       case PERIPH_ID_UART0:
> > +       case PERIPH_ID_UART1:
> > +       case PERIPH_ID_UART2:
> > +       case PERIPH_ID_UART3:
> > +               switch (peripheral) {
> > +               case PERIPH_ID_UART0:
> > +                       bank = &gpio1->a0;
> > +                       start = 0; count = 4;
> > +                       break;
> > +               case PERIPH_ID_UART1:
> > +                       bank = &gpio1->a0;
> > +                       start = 4; count = 4;
> > +                       break;
> > +               case PERIPH_ID_UART2:
> > +                       bank = &gpio1->a1;
> > +                       start = 0; count = 4;
> > +                       break;
> > +               case PERIPH_ID_UART3:
> > +                       bank = &gpio1->a1;
> > +                       start = 4; count = 2;
> > +                       break;
> > +               }
> > +               for (i = start; i < start + count; i++) {
> > +                       s5p_gpio_set_pull(bank, i, GPIO_PULL_NONE);
> > +                       s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2));
> > +               }
> > +               break;
> > +       case PERIPH_ID_SDMMC0:
> > +       case PERIPH_ID_SDMMC1:
> > +       case PERIPH_ID_SDMMC2:
> > +       case PERIPH_ID_SDMMC3:
> > +               switch (peripheral) {
> > +               case PERIPH_ID_SDMMC0:
> > +                       bank = &gpio1->c0; bank_ext = &gpio1->c1;
> > +                       break;
> > +               case PERIPH_ID_SDMMC1:
> > +                       bank = &gpio1->c1; bank_ext = NULL;
> > +                       break;
> > +               case PERIPH_ID_SDMMC2:
> > +                       bank = &gpio1->c2; bank_ext = &gpio1->c3;
> > +                       break;
> > +               case PERIPH_ID_SDMMC3:
> > +                       bank = &gpio1->c3; bank_ext = NULL;
> > +                       break;
> > +               }
> > +               if ((flags & PINMUX_FLAG_8BIT_MODE) && !bank_ext) {
> > +                       debug("SDMMC device %d does not support 8bit
> mode",
> > +                                       peripheral);
> > +                       return -1;
> > +               }
> > +               if (flags & PINMUX_FLAG_8BIT_MODE) {
> > +                       for (i = 3; i <= 6; i++) {
> > +                               s5p_gpio_cfg_pin(bank_ext, i,
> GPIO_FUNC(0x3));
> > +                               s5p_gpio_set_pull(bank_ext, i,
> GPIO_PULL_UP);
> > +                               s5p_gpio_set_drv(bank_ext, i,
> GPIO_DRV_4X);
> > +                       }
> > +               }
> > +               for (i = 0; i < 2; i++) {
> > +                       s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2));
> > +                       s5p_gpio_set_pull(bank, i, GPIO_PULL_NONE);
> > +                       s5p_gpio_set_drv(bank, i, GPIO_DRV_4X);
> > +               }
> > +               for (i = 3; i <= 6; i++) {
> > +                       s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2));
> > +                       s5p_gpio_set_pull(bank, i, GPIO_PULL_UP);
> > +                       s5p_gpio_set_drv(bank, i, GPIO_DRV_4X);
> > +               }
> > +               break;
> > +       case PERIPH_ID_SROMC:
> > +               /*
> > +                * SROM:CS1 and EBI
> > +                *
> > +                * GPY0[0]      SROM_CSn[0]
> > +                * GPY0[1]      SROM_CSn[1](2)
> > +                * GPY0[2]      SROM_CSn[2]
> > +                * GPY0[3]      SROM_CSn[3]
> > +                * GPY0[4]      EBI_OEn(2)
> > +                * GPY0[5]      EBI_EEn(2)
> > +                *
> > +                * GPY1[0]      EBI_BEn[0](2)
> > +                * GPY1[1]      EBI_BEn[1](2)
> > +                * GPY1[2]      SROM_WAIT(2)
> > +                * GPY1[3]      EBI_DATA_RDn(2)
> > +                */
> > +               s5p_gpio_cfg_pin(&gpio1->y0, (flags & PINMUX_FLAG_BANK),
> > +                                       GPIO_FUNC(2));
> > +               s5p_gpio_cfg_pin(&gpio1->y0, 4, GPIO_FUNC(2));
> > +               s5p_gpio_cfg_pin(&gpio1->y0, 5, GPIO_FUNC(2));
> > +
> > +               for (i = 0; i < 4; i++)
> > +                       s5p_gpio_cfg_pin(&gpio1->y1, i, GPIO_FUNC(2));
> > +
> > +               /*
> > +                * EBI: 8 Addrss Lines
> > +                *
> > +                * GPY3[0]      EBI_ADDR[0](2)
> > +                * GPY3[1]      EBI_ADDR[1](2)
> > +                * GPY3[2]      EBI_ADDR[2](2)
> > +                * GPY3[3]      EBI_ADDR[3](2)
> > +                * GPY3[4]      EBI_ADDR[4](2)
> > +                * GPY3[5]      EBI_ADDR[5](2)
> > +                * GPY3[6]      EBI_ADDR[6](2)
> > +                * GPY3[7]      EBI_ADDR[7](2)
> > +                *
> > +                * EBI: 16 Data Lines
> > +                *
> > +                * GPY5[0]      EBI_DATA[0](2)
> > +                * GPY5[1]      EBI_DATA[1](2)
> > +                * GPY5[2]      EBI_DATA[2](2)
> > +                * GPY5[3]      EBI_DATA[3](2)
> > +                * GPY5[4]      EBI_DATA[4](2)
> > +                * GPY5[5]      EBI_DATA[5](2)
> > +                * GPY5[6]      EBI_DATA[6](2)
> > +                * GPY5[7]      EBI_DATA[7](2)
> > +                *
> > +                * GPY6[0]      EBI_DATA[8](2)
> > +                * GPY6[1]      EBI_DATA[9](2)
> > +                * GPY6[2]      EBI_DATA[10](2)
> > +                * GPY6[3]      EBI_DATA[11](2)
> > +                * GPY6[4]      EBI_DATA[12](2)
> > +                * GPY6[5]      EBI_DATA[13](2)
> > +                * GPY6[6]      EBI_DATA[14](2)
> > +                * GPY6[7]      EBI_DATA[15](2)
> > +                */
> > +               for (i = 0; i < 8; i++) {
> > +                       s5p_gpio_cfg_pin(&gpio1->y3, i, GPIO_FUNC(2));
> > +                       s5p_gpio_set_pull(&gpio1->y3, i, GPIO_PULL_UP);
> > +
> > +                       s5p_gpio_cfg_pin(&gpio1->y5, i, GPIO_FUNC(2));
> > +                       s5p_gpio_set_pull(&gpio1->y5, i, GPIO_PULL_UP);
> > +
> > +                       s5p_gpio_cfg_pin(&gpio1->y6, i, GPIO_FUNC(2));
> > +                       s5p_gpio_set_pull(&gpio1->y6, i, GPIO_PULL_UP);
> > +               }
> > +               break;
> > +       default:
> > +               debug("%s: invalid peripheral %d", __func__, peripheral);
> > +               return -1;
> > +       }
> > +
> > +       return 0;
> > +}
> > +
> > +int exynos_pinmux_config(int peripheral, int flags)
> > +{
> > +       if (cpu_is_exynos5())
> > +               return exynos5_pinmux_config(peripheral, flags);
> > +       else{
> > +               debug("pinmux functionality not supported\n");
> > +               return -1;
> > +       }
> > +}
> > diff --git a/arch/arm/include/asm/arch-exynos/pinmux.h
> b/arch/arm/include/asm/arch-exynos/pinmux.h
> > new file mode 100644
> > index 0000000..306f521
> > --- /dev/null
> > +++ b/arch/arm/include/asm/arch-exynos/pinmux.h
> > @@ -0,0 +1,77 @@
> > +/*
> > + * Copyright (C) 2012 Samsung Electronics
> > + * Abhilash Kesavan <a.kesavan@samsung.com>
> > + *
> > + * See file CREDITS for list of people who contributed to this
> > + * project.
> > + *
> > + * This program is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU General Public License as
> > + * published by the Free Software Foundation; either version 2 of
> > + * the License, or (at your option) any later version.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > + * GNU General Public License for more details.
> > + *
> > + * You should have received a copy of the GNU General Public License
> > + * along with this program; if not, write to the Free Software
> > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> > + * MA 02111-1307 USA
> > + */
> > +
> > +#ifndef __ASM_ARM_ARCH_PINMUX_H
> > +#define __ASM_ARM_ARCH_PINMUX_H
> > +
> > +/*
> > + * Peripherals requiring clock/pinmux configuration. List will
> > + * grow with support for more devices getting added.
> > + *
> > + */
> > +enum periph_id {
> > +       PERIPH_ID_SDMMC0,
> > +       PERIPH_ID_SDMMC1,
> > +       PERIPH_ID_SDMMC2,
> > +       PERIPH_ID_SDMMC3,
> > +       PERIPH_ID_SDMMC4,
> > +       PERIPH_ID_SROMC,
> > +       PERIPH_ID_UART0,
> > +       PERIPH_ID_UART1,
> > +       PERIPH_ID_UART2,
> > +       PERIPH_ID_UART3,
> > +
> > +       PERIPH_ID_COUNT,
> > +       PERIPH_ID_NONE = -1,
> > +};
> > +
> > +/*
> > + * Flags for setting specific configarations of peripherals.
> > + * List will grow with support for more devices getting added.
> > + */
> > +enum {
> > +       PINMUX_FLAG_NONE        = 0x00000000,
> > +
> > +       /* Flags for eMMC */
> > +       PINMUX_FLAG_8BIT_MODE   = 1 << 0,       /* SDMMC 8-bit mode */
> > +
> > +       /* Flags for SROM controller */
> > +       PINMUX_FLAG_BANK        = 3 << 0,       /* bank number (0-3) */
> > +       PINMUX_FLAG_16BIT       = 1 << 2,       /* 16-bit width */
> > +};
> > +
> > +/**
> > + * Configures the pinmux for a particular peripheral.
> > + *
> > + * Each gpio can be configured in many different ways (4 bits on exynos)
> > + * such as "input", "output", "special function", "external interrupt"
> > + * etc. This function will configure the peripheral pinmux along with
> > + * pull-up/down and drive strength.
> > + *
> > + * @param peripheral   peripheral to be configured
> > + * @param flags                configure flags
> > + * @return 0 if ok, -1 on error (e.g. unsupported peripheral)
> > + */
> > +int exynos_pinmux_config(int peripheral, int flags);
> > +
> > +#endif
> > --
> > 1.7.4.4
> >
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot@lists.denx.de
> > http://lists.denx.de/mailman/listinfo/u-boot
>
>
>
> --
> with warm regards,
> Chander Kashyap
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>

Regards,
Simon
Simon Glass June 1, 2012, 12:35 a.m. | #5
Hi,

On Thu, May 3, 2012 at 11:56 PM, Rajeshwari Shinde <rajeshwari.s@samsung.com
> wrote:

> This patch performs the pinmux configuration in a common file.
> As of now only Exynos5 pinmux for SDMMC, UART and Ethernet is
> supported.
>
> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
> Signed-off-by: Che-Liang Chiou <clchiou@chromium.org>
> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
> ---
>  arch/arm/cpu/armv7/exynos/pinmux.c        |  189
> +++++++++++++++++++++++++++++
>  arch/arm/include/asm/arch-exynos/pinmux.h |   77 ++++++++++++
>  2 files changed, 266 insertions(+), 0 deletions(-)
>  create mode 100644 arch/arm/cpu/armv7/exynos/pinmux.c
>  create mode 100644 arch/arm/include/asm/arch-exynos/pinmux.h
>
> diff --git a/arch/arm/cpu/armv7/exynos/pinmux.c
> b/arch/arm/cpu/armv7/exynos/pinmux.c
> new file mode 100644
> index 0000000..11f4b71
> --- /dev/null
> +++ b/arch/arm/cpu/armv7/exynos/pinmux.c
> @@ -0,0 +1,189 @@
> +/*
> + * Copyright (c) 2012 Samsung Electronics.
> + * Abhilash Kesavan <a.kesavan@samsung.com>
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +#include <common.h>
> +#include <asm/arch/cpu.h>
> +#include <asm/arch/gpio.h>
> +#include <asm/arch/pinmux.h>
> +#include <asm/arch/sromc.h>
> +
> +int exynos5_pinmux_config(int peripheral, int flags)
> +{
> +       struct exynos5_gpio_part1 *gpio1 =
> +               (struct exynos5_gpio_part1 *)
> samsung_get_base_gpio_part1();
> +       struct s5p_gpio_bank *bank, *bank_ext;
> +       int i, start, count;
> +
> +       switch (peripheral) {
> +       case PERIPH_ID_UART0:
> +       case PERIPH_ID_UART1:
> +       case PERIPH_ID_UART2:
> +       case PERIPH_ID_UART3:
> +               switch (peripheral) {
> +               case PERIPH_ID_UART0:
> +                       bank = &gpio1->a0;
> +                       start = 0; count = 4;
> +                       break;
> +               case PERIPH_ID_UART1:
> +                       bank = &gpio1->a0;
> +                       start = 4; count = 4;
> +                       break;
> +               case PERIPH_ID_UART2:
> +                       bank = &gpio1->a1;
> +                       start = 0; count = 4;
> +                       break;
> +               case PERIPH_ID_UART3:
> +                       bank = &gpio1->a1;
> +                       start = 4; count = 2;
> +                       break;
> +               }
> +               for (i = start; i < start + count; i++) {
> +                       s5p_gpio_set_pull(bank, i, GPIO_PULL_NONE);
> +                       s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2));
> +               }
> +               break;
> +       case PERIPH_ID_SDMMC0:
> +       case PERIPH_ID_SDMMC1:
> +       case PERIPH_ID_SDMMC2:
> +       case PERIPH_ID_SDMMC3:
> +               switch (peripheral) {
> +               case PERIPH_ID_SDMMC0:
> +                       bank = &gpio1->c0; bank_ext = &gpio1->c1;
> +                       break;
> +               case PERIPH_ID_SDMMC1:
> +                       bank = &gpio1->c1; bank_ext = NULL;
> +                       break;
> +               case PERIPH_ID_SDMMC2:
> +                       bank = &gpio1->c2; bank_ext = &gpio1->c3;
> +                       break;
> +               case PERIPH_ID_SDMMC3:
> +                       bank = &gpio1->c3; bank_ext = NULL;
> +                       break;
> +               }
> +               if ((flags & PINMUX_FLAG_8BIT_MODE) && !bank_ext) {
> +                       debug("SDMMC device %d does not support 8bit mode",
> +                                       peripheral);
> +                       return -1;
> +               }
> +               if (flags & PINMUX_FLAG_8BIT_MODE) {
> +                       for (i = 3; i <= 6; i++) {
> +                               s5p_gpio_cfg_pin(bank_ext, i,
> GPIO_FUNC(0x3));
> +                               s5p_gpio_set_pull(bank_ext, i,
> GPIO_PULL_UP);
> +                               s5p_gpio_set_drv(bank_ext, i, GPIO_DRV_4X);
> +                       }
> +               }
> +               for (i = 0; i < 2; i++) {
> +                       s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2));
> +                       s5p_gpio_set_pull(bank, i, GPIO_PULL_NONE);
> +                       s5p_gpio_set_drv(bank, i, GPIO_DRV_4X);
> +               }
> +               for (i = 3; i <= 6; i++) {
> +                       s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2));
> +                       s5p_gpio_set_pull(bank, i, GPIO_PULL_UP);
> +                       s5p_gpio_set_drv(bank, i, GPIO_DRV_4X);
> +               }
> +               break;
> +       case PERIPH_ID_SROMC:
> +               /*
> +                * SROM:CS1 and EBI
> +                *
> +                * GPY0[0]      SROM_CSn[0]
> +                * GPY0[1]      SROM_CSn[1](2)
> +                * GPY0[2]      SROM_CSn[2]
> +                * GPY0[3]      SROM_CSn[3]
> +                * GPY0[4]      EBI_OEn(2)
> +                * GPY0[5]      EBI_EEn(2)
> +                *
> +                * GPY1[0]      EBI_BEn[0](2)
> +                * GPY1[1]      EBI_BEn[1](2)
> +                * GPY1[2]      SROM_WAIT(2)
> +                * GPY1[3]      EBI_DATA_RDn(2)
> +                */
> +               s5p_gpio_cfg_pin(&gpio1->y0, (flags & PINMUX_FLAG_BANK),
> +                                       GPIO_FUNC(2));
> +               s5p_gpio_cfg_pin(&gpio1->y0, 4, GPIO_FUNC(2));
> +               s5p_gpio_cfg_pin(&gpio1->y0, 5, GPIO_FUNC(2));
> +
> +               for (i = 0; i < 4; i++)
> +                       s5p_gpio_cfg_pin(&gpio1->y1, i, GPIO_FUNC(2));
> +
> +               /*
> +                * EBI: 8 Addrss Lines
> +                *
> +                * GPY3[0]      EBI_ADDR[0](2)
> +                * GPY3[1]      EBI_ADDR[1](2)
> +                * GPY3[2]      EBI_ADDR[2](2)
> +                * GPY3[3]      EBI_ADDR[3](2)
> +                * GPY3[4]      EBI_ADDR[4](2)
> +                * GPY3[5]      EBI_ADDR[5](2)
> +                * GPY3[6]      EBI_ADDR[6](2)
> +                * GPY3[7]      EBI_ADDR[7](2)
> +                *
> +                * EBI: 16 Data Lines
> +                *
> +                * GPY5[0]      EBI_DATA[0](2)
> +                * GPY5[1]      EBI_DATA[1](2)
> +                * GPY5[2]      EBI_DATA[2](2)
> +                * GPY5[3]      EBI_DATA[3](2)
> +                * GPY5[4]      EBI_DATA[4](2)
> +                * GPY5[5]      EBI_DATA[5](2)
> +                * GPY5[6]      EBI_DATA[6](2)
> +                * GPY5[7]      EBI_DATA[7](2)
> +                *
> +                * GPY6[0]      EBI_DATA[8](2)
> +                * GPY6[1]      EBI_DATA[9](2)
> +                * GPY6[2]      EBI_DATA[10](2)
> +                * GPY6[3]      EBI_DATA[11](2)
> +                * GPY6[4]      EBI_DATA[12](2)
> +                * GPY6[5]      EBI_DATA[13](2)
> +                * GPY6[6]      EBI_DATA[14](2)
> +                * GPY6[7]      EBI_DATA[15](2)
> +                */
> +               for (i = 0; i < 8; i++) {
> +                       s5p_gpio_cfg_pin(&gpio1->y3, i, GPIO_FUNC(2));
> +                       s5p_gpio_set_pull(&gpio1->y3, i, GPIO_PULL_UP);
> +
> +                       s5p_gpio_cfg_pin(&gpio1->y5, i, GPIO_FUNC(2));
> +                       s5p_gpio_set_pull(&gpio1->y5, i, GPIO_PULL_UP);
> +
> +                       s5p_gpio_cfg_pin(&gpio1->y6, i, GPIO_FUNC(2));
> +                       s5p_gpio_set_pull(&gpio1->y6, i, GPIO_PULL_UP);
> +               }
> +               break;
> +       default:
> +               debug("%s: invalid peripheral %d", __func__, peripheral);
> +               return -1;
> +       }
> +
> +       return 0;
> +}
> +
> +int exynos_pinmux_config(int peripheral, int flags)
> +{
> +       if (cpu_is_exynos5())
> +               return exynos5_pinmux_config(peripheral, flags);
>

Oh I see.

You could perhaps put this check in the above function, but it seems odd
that this function is in the exynos directory instead of exynos5. It seems
like this code would be specific to a particular chip, but I don't know
much about it.

If you do want this, then {} around the if() bit also.


+       else{
>

space


> +               debug("pinmux functionality not supported\n");
> +               return -1;
> +       }
> +}
> diff --git a/arch/arm/include/asm/arch-exynos/pinmux.h
> b/arch/arm/include/asm/arch-exynos/pinmux.h
> new file mode 100644
> index 0000000..306f521
> --- /dev/null
> +++ b/arch/arm/include/asm/arch-exynos/pinmux.h
> @@ -0,0 +1,77 @@
> +/*
> + * Copyright (C) 2012 Samsung Electronics
> + * Abhilash Kesavan <a.kesavan@samsung.com>
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +#ifndef __ASM_ARM_ARCH_PINMUX_H
> +#define __ASM_ARM_ARCH_PINMUX_H
> +
> +/*
> + * Peripherals requiring clock/pinmux configuration. List will
> + * grow with support for more devices getting added.
> + *
> + */
> +enum periph_id {
> +       PERIPH_ID_SDMMC0,
> +       PERIPH_ID_SDMMC1,
> +       PERIPH_ID_SDMMC2,
> +       PERIPH_ID_SDMMC3,
> +       PERIPH_ID_SDMMC4,
> +       PERIPH_ID_SROMC,
> +       PERIPH_ID_UART0,
> +       PERIPH_ID_UART1,
> +       PERIPH_ID_UART2,
> +       PERIPH_ID_UART3,
> +
> +       PERIPH_ID_COUNT,
> +       PERIPH_ID_NONE = -1,
> +};
> +
> +/*
> + * Flags for setting specific configarations of peripherals.
> + * List will grow with support for more devices getting added.
> + */
> +enum {
> +       PINMUX_FLAG_NONE        = 0x00000000,
> +
> +       /* Flags for eMMC */
> +       PINMUX_FLAG_8BIT_MODE   = 1 << 0,       /* SDMMC 8-bit mode */
> +
> +       /* Flags for SROM controller */
> +       PINMUX_FLAG_BANK        = 3 << 0,       /* bank number (0-3) */
> +       PINMUX_FLAG_16BIT       = 1 << 2,       /* 16-bit width */
> +};
> +
> +/**
> + * Configures the pinmux for a particular peripheral.
> + *
> + * Each gpio can be configured in many different ways (4 bits on exynos)
> + * such as "input", "output", "special function", "external interrupt"
> + * etc. This function will configure the peripheral pinmux along with
> + * pull-up/down and drive strength.
> + *
> + * @param peripheral   peripheral to be configured
> + * @param flags                configure flags
> + * @return 0 if ok, -1 on error (e.g. unsupported peripheral)
> + */
> +int exynos_pinmux_config(int peripheral, int flags);
> +
> +#endif
> --
> 1.7.4.4
>
>
Regards,
Simon
Rajeshwari Birje June 1, 2012, 6:10 a.m. | #6
Hi Simon,

Thank you for comments.

On Fri, Jun 1, 2012 at 6:05 AM, Simon Glass <sjg@chromium.org> wrote:
> Hi,
>
> On Thu, May 3, 2012 at 11:56 PM, Rajeshwari Shinde <rajeshwari.s@samsung.com
>> wrote:
>
>> This patch performs the pinmux configuration in a common file.
>> As of now only Exynos5 pinmux for SDMMC, UART and Ethernet is
>> supported.
>>
>> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
>> Signed-off-by: Che-Liang Chiou <clchiou@chromium.org>
>> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
>> ---
>>  arch/arm/cpu/armv7/exynos/pinmux.c        |  189
>> +++++++++++++++++++++++++++++
>>  arch/arm/include/asm/arch-exynos/pinmux.h |   77 ++++++++++++
>>  2 files changed, 266 insertions(+), 0 deletions(-)
>>  create mode 100644 arch/arm/cpu/armv7/exynos/pinmux.c
>>  create mode 100644 arch/arm/include/asm/arch-exynos/pinmux.h
>>
>> diff --git a/arch/arm/cpu/armv7/exynos/pinmux.c
>> b/arch/arm/cpu/armv7/exynos/pinmux.c
>> new file mode 100644
>> index 0000000..11f4b71
>> --- /dev/null
>> +++ b/arch/arm/cpu/armv7/exynos/pinmux.c
>> @@ -0,0 +1,189 @@
>> +/*
>> + * Copyright (c) 2012 Samsung Electronics.
>> + * Abhilash Kesavan <a.kesavan@samsung.com>
>> + *
>> + * See file CREDITS for list of people who contributed to this
>> + * project.
>> + *
>> + * This program is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU General Public License as
>> + * published by the Free Software Foundation; either version 2 of
>> + * the License, or (at your option) any later version.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> + * GNU General Public License for more details.
>> + *
>> + * You should have received a copy of the GNU General Public License
>> + * along with this program; if not, write to the Free Software
>> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
>> + * MA 02111-1307 USA
>> + */
>> +
>> +#include <common.h>
>> +#include <asm/arch/cpu.h>
>> +#include <asm/arch/gpio.h>
>> +#include <asm/arch/pinmux.h>
>> +#include <asm/arch/sromc.h>
>> +
>> +int exynos5_pinmux_config(int peripheral, int flags)
>> +{
>> +       struct exynos5_gpio_part1 *gpio1 =
>> +               (struct exynos5_gpio_part1 *)
>> samsung_get_base_gpio_part1();
>> +       struct s5p_gpio_bank *bank, *bank_ext;
>> +       int i, start, count;
>> +
>> +       switch (peripheral) {
>> +       case PERIPH_ID_UART0:
>> +       case PERIPH_ID_UART1:
>> +       case PERIPH_ID_UART2:
>> +       case PERIPH_ID_UART3:
>> +               switch (peripheral) {
>> +               case PERIPH_ID_UART0:
>> +                       bank = &gpio1->a0;
>> +                       start = 0; count = 4;
>> +                       break;
>> +               case PERIPH_ID_UART1:
>> +                       bank = &gpio1->a0;
>> +                       start = 4; count = 4;
>> +                       break;
>> +               case PERIPH_ID_UART2:
>> +                       bank = &gpio1->a1;
>> +                       start = 0; count = 4;
>> +                       break;
>> +               case PERIPH_ID_UART3:
>> +                       bank = &gpio1->a1;
>> +                       start = 4; count = 2;
>> +                       break;
>> +               }
>> +               for (i = start; i < start + count; i++) {
>> +                       s5p_gpio_set_pull(bank, i, GPIO_PULL_NONE);
>> +                       s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2));
>> +               }
>> +               break;
>> +       case PERIPH_ID_SDMMC0:
>> +       case PERIPH_ID_SDMMC1:
>> +       case PERIPH_ID_SDMMC2:
>> +       case PERIPH_ID_SDMMC3:
>> +               switch (peripheral) {
>> +               case PERIPH_ID_SDMMC0:
>> +                       bank = &gpio1->c0; bank_ext = &gpio1->c1;
>> +                       break;
>> +               case PERIPH_ID_SDMMC1:
>> +                       bank = &gpio1->c1; bank_ext = NULL;
>> +                       break;
>> +               case PERIPH_ID_SDMMC2:
>> +                       bank = &gpio1->c2; bank_ext = &gpio1->c3;
>> +                       break;
>> +               case PERIPH_ID_SDMMC3:
>> +                       bank = &gpio1->c3; bank_ext = NULL;
>> +                       break;
>> +               }
>> +               if ((flags & PINMUX_FLAG_8BIT_MODE) && !bank_ext) {
>> +                       debug("SDMMC device %d does not support 8bit mode",
>> +                                       peripheral);
>> +                       return -1;
>> +               }
>> +               if (flags & PINMUX_FLAG_8BIT_MODE) {
>> +                       for (i = 3; i <= 6; i++) {
>> +                               s5p_gpio_cfg_pin(bank_ext, i,
>> GPIO_FUNC(0x3));
>> +                               s5p_gpio_set_pull(bank_ext, i,
>> GPIO_PULL_UP);
>> +                               s5p_gpio_set_drv(bank_ext, i, GPIO_DRV_4X);
>> +                       }
>> +               }
>> +               for (i = 0; i < 2; i++) {
>> +                       s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2));
>> +                       s5p_gpio_set_pull(bank, i, GPIO_PULL_NONE);
>> +                       s5p_gpio_set_drv(bank, i, GPIO_DRV_4X);
>> +               }
>> +               for (i = 3; i <= 6; i++) {
>> +                       s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2));
>> +                       s5p_gpio_set_pull(bank, i, GPIO_PULL_UP);
>> +                       s5p_gpio_set_drv(bank, i, GPIO_DRV_4X);
>> +               }
>> +               break;
>> +       case PERIPH_ID_SROMC:
>> +               /*
>> +                * SROM:CS1 and EBI
>> +                *
>> +                * GPY0[0]      SROM_CSn[0]
>> +                * GPY0[1]      SROM_CSn[1](2)
>> +                * GPY0[2]      SROM_CSn[2]
>> +                * GPY0[3]      SROM_CSn[3]
>> +                * GPY0[4]      EBI_OEn(2)
>> +                * GPY0[5]      EBI_EEn(2)
>> +                *
>> +                * GPY1[0]      EBI_BEn[0](2)
>> +                * GPY1[1]      EBI_BEn[1](2)
>> +                * GPY1[2]      SROM_WAIT(2)
>> +                * GPY1[3]      EBI_DATA_RDn(2)
>> +                */
>> +               s5p_gpio_cfg_pin(&gpio1->y0, (flags & PINMUX_FLAG_BANK),
>> +                                       GPIO_FUNC(2));
>> +               s5p_gpio_cfg_pin(&gpio1->y0, 4, GPIO_FUNC(2));
>> +               s5p_gpio_cfg_pin(&gpio1->y0, 5, GPIO_FUNC(2));
>> +
>> +               for (i = 0; i < 4; i++)
>> +                       s5p_gpio_cfg_pin(&gpio1->y1, i, GPIO_FUNC(2));
>> +
>> +               /*
>> +                * EBI: 8 Addrss Lines
>> +                *
>> +                * GPY3[0]      EBI_ADDR[0](2)
>> +                * GPY3[1]      EBI_ADDR[1](2)
>> +                * GPY3[2]      EBI_ADDR[2](2)
>> +                * GPY3[3]      EBI_ADDR[3](2)
>> +                * GPY3[4]      EBI_ADDR[4](2)
>> +                * GPY3[5]      EBI_ADDR[5](2)
>> +                * GPY3[6]      EBI_ADDR[6](2)
>> +                * GPY3[7]      EBI_ADDR[7](2)
>> +                *
>> +                * EBI: 16 Data Lines
>> +                *
>> +                * GPY5[0]      EBI_DATA[0](2)
>> +                * GPY5[1]      EBI_DATA[1](2)
>> +                * GPY5[2]      EBI_DATA[2](2)
>> +                * GPY5[3]      EBI_DATA[3](2)
>> +                * GPY5[4]      EBI_DATA[4](2)
>> +                * GPY5[5]      EBI_DATA[5](2)
>> +                * GPY5[6]      EBI_DATA[6](2)
>> +                * GPY5[7]      EBI_DATA[7](2)
>> +                *
>> +                * GPY6[0]      EBI_DATA[8](2)
>> +                * GPY6[1]      EBI_DATA[9](2)
>> +                * GPY6[2]      EBI_DATA[10](2)
>> +                * GPY6[3]      EBI_DATA[11](2)
>> +                * GPY6[4]      EBI_DATA[12](2)
>> +                * GPY6[5]      EBI_DATA[13](2)
>> +                * GPY6[6]      EBI_DATA[14](2)
>> +                * GPY6[7]      EBI_DATA[15](2)
>> +                */
>> +               for (i = 0; i < 8; i++) {
>> +                       s5p_gpio_cfg_pin(&gpio1->y3, i, GPIO_FUNC(2));
>> +                       s5p_gpio_set_pull(&gpio1->y3, i, GPIO_PULL_UP);
>> +
>> +                       s5p_gpio_cfg_pin(&gpio1->y5, i, GPIO_FUNC(2));
>> +                       s5p_gpio_set_pull(&gpio1->y5, i, GPIO_PULL_UP);
>> +
>> +                       s5p_gpio_cfg_pin(&gpio1->y6, i, GPIO_FUNC(2));
>> +                       s5p_gpio_set_pull(&gpio1->y6, i, GPIO_PULL_UP);
>> +               }
>> +               break;
>> +       default:
>> +               debug("%s: invalid peripheral %d", __func__, peripheral);
>> +               return -1;
>> +       }
>> +
>> +       return 0;
>> +}
>> +
>> +int exynos_pinmux_config(int peripheral, int flags)
>> +{
>> +       if (cpu_is_exynos5())
>> +               return exynos5_pinmux_config(peripheral, flags);
>>
>
> Oh I see.
>
> You could perhaps put this check in the above function, but it seems odd
> that this function is in the exynos directory instead of exynos5. It seems
> like this code would be specific to a particular chip, but I don't know
> much about it.
-- Currently in the mainline code we have a common directory for both
exynos4 and exynos5
hence we have put this check. There are no separate directories for
exynos4 and exynos5.
>
> If you do want this, then {} around the if() bit also.
-- will correct this
>
>
> +       else{
>>
>
> space
>
>
>> +               debug("pinmux functionality not supported\n");
>> +               return -1;
>> +       }
>> +}
>> diff --git a/arch/arm/include/asm/arch-exynos/pinmux.h
>> b/arch/arm/include/asm/arch-exynos/pinmux.h
>> new file mode 100644
>> index 0000000..306f521
>> --- /dev/null
>> +++ b/arch/arm/include/asm/arch-exynos/pinmux.h
>> @@ -0,0 +1,77 @@
>> +/*
>> + * Copyright (C) 2012 Samsung Electronics
>> + * Abhilash Kesavan <a.kesavan@samsung.com>
>> + *
>> + * See file CREDITS for list of people who contributed to this
>> + * project.
>> + *
>> + * This program is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU General Public License as
>> + * published by the Free Software Foundation; either version 2 of
>> + * the License, or (at your option) any later version.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> + * GNU General Public License for more details.
>> + *
>> + * You should have received a copy of the GNU General Public License
>> + * along with this program; if not, write to the Free Software
>> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
>> + * MA 02111-1307 USA
>> + */
>> +
>> +#ifndef __ASM_ARM_ARCH_PINMUX_H
>> +#define __ASM_ARM_ARCH_PINMUX_H
>> +
>> +/*
>> + * Peripherals requiring clock/pinmux configuration. List will
>> + * grow with support for more devices getting added.
>> + *
>> + */
>> +enum periph_id {
>> +       PERIPH_ID_SDMMC0,
>> +       PERIPH_ID_SDMMC1,
>> +       PERIPH_ID_SDMMC2,
>> +       PERIPH_ID_SDMMC3,
>> +       PERIPH_ID_SDMMC4,
>> +       PERIPH_ID_SROMC,
>> +       PERIPH_ID_UART0,
>> +       PERIPH_ID_UART1,
>> +       PERIPH_ID_UART2,
>> +       PERIPH_ID_UART3,
>> +
>> +       PERIPH_ID_COUNT,
>> +       PERIPH_ID_NONE = -1,
>> +};
>> +
>> +/*
>> + * Flags for setting specific configarations of peripherals.
>> + * List will grow with support for more devices getting added.
>> + */
>> +enum {
>> +       PINMUX_FLAG_NONE        = 0x00000000,
>> +
>> +       /* Flags for eMMC */
>> +       PINMUX_FLAG_8BIT_MODE   = 1 << 0,       /* SDMMC 8-bit mode */
>> +
>> +       /* Flags for SROM controller */
>> +       PINMUX_FLAG_BANK        = 3 << 0,       /* bank number (0-3) */
>> +       PINMUX_FLAG_16BIT       = 1 << 2,       /* 16-bit width */
>> +};
>> +
>> +/**
>> + * Configures the pinmux for a particular peripheral.
>> + *
>> + * Each gpio can be configured in many different ways (4 bits on exynos)
>> + * such as "input", "output", "special function", "external interrupt"
>> + * etc. This function will configure the peripheral pinmux along with
>> + * pull-up/down and drive strength.
>> + *
>> + * @param peripheral   peripheral to be configured
>> + * @param flags                configure flags
>> + * @return 0 if ok, -1 on error (e.g. unsupported peripheral)
>> + */
>> +int exynos_pinmux_config(int peripheral, int flags);
>> +
>> +#endif
>> --
>> 1.7.4.4
>>
>>
> Regards,
> Simon
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>

Regards,
Rajeshwari Shinde.

Patch

diff --git a/arch/arm/cpu/armv7/exynos/pinmux.c b/arch/arm/cpu/armv7/exynos/pinmux.c
new file mode 100644
index 0000000..11f4b71
--- /dev/null
+++ b/arch/arm/cpu/armv7/exynos/pinmux.c
@@ -0,0 +1,189 @@ 
+/*
+ * Copyright (c) 2012 Samsung Electronics.
+ * Abhilash Kesavan <a.kesavan@samsung.com>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include <common.h>
+#include <asm/arch/cpu.h>
+#include <asm/arch/gpio.h>
+#include <asm/arch/pinmux.h>
+#include <asm/arch/sromc.h>
+
+int exynos5_pinmux_config(int peripheral, int flags)
+{
+	struct exynos5_gpio_part1 *gpio1 =
+		(struct exynos5_gpio_part1 *) samsung_get_base_gpio_part1();
+	struct s5p_gpio_bank *bank, *bank_ext;
+	int i, start, count;
+
+	switch (peripheral) {
+	case PERIPH_ID_UART0:
+	case PERIPH_ID_UART1:
+	case PERIPH_ID_UART2:
+	case PERIPH_ID_UART3:
+		switch (peripheral) {
+		case PERIPH_ID_UART0:
+			bank = &gpio1->a0;
+			start = 0; count = 4;
+			break;
+		case PERIPH_ID_UART1:
+			bank = &gpio1->a0;
+			start = 4; count = 4;
+			break;
+		case PERIPH_ID_UART2:
+			bank = &gpio1->a1;
+			start = 0; count = 4;
+			break;
+		case PERIPH_ID_UART3:
+			bank = &gpio1->a1;
+			start = 4; count = 2;
+			break;
+		}
+		for (i = start; i < start + count; i++) {
+			s5p_gpio_set_pull(bank, i, GPIO_PULL_NONE);
+			s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2));
+		}
+		break;
+	case PERIPH_ID_SDMMC0:
+	case PERIPH_ID_SDMMC1:
+	case PERIPH_ID_SDMMC2:
+	case PERIPH_ID_SDMMC3:
+		switch (peripheral) {
+		case PERIPH_ID_SDMMC0:
+			bank = &gpio1->c0; bank_ext = &gpio1->c1;
+			break;
+		case PERIPH_ID_SDMMC1:
+			bank = &gpio1->c1; bank_ext = NULL;
+			break;
+		case PERIPH_ID_SDMMC2:
+			bank = &gpio1->c2; bank_ext = &gpio1->c3;
+			break;
+		case PERIPH_ID_SDMMC3:
+			bank = &gpio1->c3; bank_ext = NULL;
+			break;
+		}
+		if ((flags & PINMUX_FLAG_8BIT_MODE) && !bank_ext) {
+			debug("SDMMC device %d does not support 8bit mode",
+					peripheral);
+			return -1;
+		}
+		if (flags & PINMUX_FLAG_8BIT_MODE) {
+			for (i = 3; i <= 6; i++) {
+				s5p_gpio_cfg_pin(bank_ext, i, GPIO_FUNC(0x3));
+				s5p_gpio_set_pull(bank_ext, i, GPIO_PULL_UP);
+				s5p_gpio_set_drv(bank_ext, i, GPIO_DRV_4X);
+			}
+		}
+		for (i = 0; i < 2; i++) {
+			s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2));
+			s5p_gpio_set_pull(bank, i, GPIO_PULL_NONE);
+			s5p_gpio_set_drv(bank, i, GPIO_DRV_4X);
+		}
+		for (i = 3; i <= 6; i++) {
+			s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2));
+			s5p_gpio_set_pull(bank, i, GPIO_PULL_UP);
+			s5p_gpio_set_drv(bank, i, GPIO_DRV_4X);
+		}
+		break;
+	case PERIPH_ID_SROMC:
+		/*
+		 * SROM:CS1 and EBI
+		 *
+		 * GPY0[0]	SROM_CSn[0]
+		 * GPY0[1]	SROM_CSn[1](2)
+		 * GPY0[2]	SROM_CSn[2]
+		 * GPY0[3]	SROM_CSn[3]
+		 * GPY0[4]	EBI_OEn(2)
+		 * GPY0[5]	EBI_EEn(2)
+		 *
+		 * GPY1[0]	EBI_BEn[0](2)
+		 * GPY1[1]	EBI_BEn[1](2)
+		 * GPY1[2]	SROM_WAIT(2)
+		 * GPY1[3]	EBI_DATA_RDn(2)
+		 */
+		s5p_gpio_cfg_pin(&gpio1->y0, (flags & PINMUX_FLAG_BANK),
+					GPIO_FUNC(2));
+		s5p_gpio_cfg_pin(&gpio1->y0, 4, GPIO_FUNC(2));
+		s5p_gpio_cfg_pin(&gpio1->y0, 5, GPIO_FUNC(2));
+
+		for (i = 0; i < 4; i++)
+			s5p_gpio_cfg_pin(&gpio1->y1, i, GPIO_FUNC(2));
+
+		/*
+		 * EBI: 8 Addrss Lines
+		 *
+		 * GPY3[0]	EBI_ADDR[0](2)
+		 * GPY3[1]	EBI_ADDR[1](2)
+		 * GPY3[2]	EBI_ADDR[2](2)
+		 * GPY3[3]	EBI_ADDR[3](2)
+		 * GPY3[4]	EBI_ADDR[4](2)
+		 * GPY3[5]	EBI_ADDR[5](2)
+		 * GPY3[6]	EBI_ADDR[6](2)
+		 * GPY3[7]	EBI_ADDR[7](2)
+		 *
+		 * EBI: 16 Data Lines
+		 *
+		 * GPY5[0]	EBI_DATA[0](2)
+		 * GPY5[1]	EBI_DATA[1](2)
+		 * GPY5[2]	EBI_DATA[2](2)
+		 * GPY5[3]	EBI_DATA[3](2)
+		 * GPY5[4]	EBI_DATA[4](2)
+		 * GPY5[5]	EBI_DATA[5](2)
+		 * GPY5[6]	EBI_DATA[6](2)
+		 * GPY5[7]	EBI_DATA[7](2)
+		 *
+		 * GPY6[0]	EBI_DATA[8](2)
+		 * GPY6[1]	EBI_DATA[9](2)
+		 * GPY6[2]	EBI_DATA[10](2)
+		 * GPY6[3]	EBI_DATA[11](2)
+		 * GPY6[4]	EBI_DATA[12](2)
+		 * GPY6[5]	EBI_DATA[13](2)
+		 * GPY6[6]	EBI_DATA[14](2)
+		 * GPY6[7]	EBI_DATA[15](2)
+		 */
+		for (i = 0; i < 8; i++) {
+			s5p_gpio_cfg_pin(&gpio1->y3, i, GPIO_FUNC(2));
+			s5p_gpio_set_pull(&gpio1->y3, i, GPIO_PULL_UP);
+
+			s5p_gpio_cfg_pin(&gpio1->y5, i, GPIO_FUNC(2));
+			s5p_gpio_set_pull(&gpio1->y5, i, GPIO_PULL_UP);
+
+			s5p_gpio_cfg_pin(&gpio1->y6, i, GPIO_FUNC(2));
+			s5p_gpio_set_pull(&gpio1->y6, i, GPIO_PULL_UP);
+		}
+		break;
+	default:
+		debug("%s: invalid peripheral %d", __func__, peripheral);
+		return -1;
+	}
+
+	return 0;
+}
+
+int exynos_pinmux_config(int peripheral, int flags)
+{
+	if (cpu_is_exynos5())
+		return exynos5_pinmux_config(peripheral, flags);
+	else{
+		debug("pinmux functionality not supported\n");
+		return -1;
+	}
+}
diff --git a/arch/arm/include/asm/arch-exynos/pinmux.h b/arch/arm/include/asm/arch-exynos/pinmux.h
new file mode 100644
index 0000000..306f521
--- /dev/null
+++ b/arch/arm/include/asm/arch-exynos/pinmux.h
@@ -0,0 +1,77 @@ 
+/*
+ * Copyright (C) 2012 Samsung Electronics
+ * Abhilash Kesavan <a.kesavan@samsung.com>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#ifndef __ASM_ARM_ARCH_PINMUX_H
+#define __ASM_ARM_ARCH_PINMUX_H
+
+/*
+ * Peripherals requiring clock/pinmux configuration. List will
+ * grow with support for more devices getting added.
+ *
+ */
+enum periph_id {
+	PERIPH_ID_SDMMC0,
+	PERIPH_ID_SDMMC1,
+	PERIPH_ID_SDMMC2,
+	PERIPH_ID_SDMMC3,
+	PERIPH_ID_SDMMC4,
+	PERIPH_ID_SROMC,
+	PERIPH_ID_UART0,
+	PERIPH_ID_UART1,
+	PERIPH_ID_UART2,
+	PERIPH_ID_UART3,
+
+	PERIPH_ID_COUNT,
+	PERIPH_ID_NONE = -1,
+};
+
+/*
+ * Flags for setting specific configarations of peripherals.
+ * List will grow with support for more devices getting added.
+ */
+enum {
+	PINMUX_FLAG_NONE	= 0x00000000,
+
+	/* Flags for eMMC */
+	PINMUX_FLAG_8BIT_MODE	= 1 << 0,       /* SDMMC 8-bit mode */
+
+	/* Flags for SROM controller */
+	PINMUX_FLAG_BANK	= 3 << 0,       /* bank number (0-3) */
+	PINMUX_FLAG_16BIT	= 1 << 2,       /* 16-bit width */
+};
+
+/**
+ * Configures the pinmux for a particular peripheral.
+ *
+ * Each gpio can be configured in many different ways (4 bits on exynos)
+ * such as "input", "output", "special function", "external interrupt"
+ * etc. This function will configure the peripheral pinmux along with
+ * pull-up/down and drive strength.
+ *
+ * @param peripheral	peripheral to be configured
+ * @param flags		configure flags
+ * @return 0 if ok, -1 on error (e.g. unsupported peripheral)
+ */
+int exynos_pinmux_config(int peripheral, int flags);
+
+#endif