| Message ID | 20241105130431.22564-7-philmd@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
On Tue, Nov 5, 2024 at 11:07 PM Philippe Mathieu-Daudé <philmd@linaro.org> wrote: > > Fix few MemoryRegionOps style before adding new fields > in the following commits. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > hw/char/xilinx_uartlite.c | 4 ++-- > hw/intc/xilinx_intc.c | 4 ++-- > hw/net/xilinx_ethlite.c | 4 ++-- > hw/timer/xilinx_timer.c | 4 ++-- > 4 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/hw/char/xilinx_uartlite.c b/hw/char/xilinx_uartlite.c > index f325084f8b9..a69ad769cc4 100644 > --- a/hw/char/xilinx_uartlite.c > +++ b/hw/char/xilinx_uartlite.c > @@ -172,8 +172,8 @@ static const MemoryRegionOps uart_ops = { > .endianness = DEVICE_NATIVE_ENDIAN, > .valid = { > .min_access_size = 1, > - .max_access_size = 4 > - } > + .max_access_size = 4, > + }, > }; > > static Property xilinx_uartlite_properties[] = { > diff --git a/hw/intc/xilinx_intc.c b/hw/intc/xilinx_intc.c > index 6e5012e66eb..2b8246f6206 100644 > --- a/hw/intc/xilinx_intc.c > +++ b/hw/intc/xilinx_intc.c > @@ -146,8 +146,8 @@ static const MemoryRegionOps pic_ops = { > .endianness = DEVICE_NATIVE_ENDIAN, > .valid = { > .min_access_size = 4, > - .max_access_size = 4 > - } > + .max_access_size = 4, > + }, > }; > > static void irq_handler(void *opaque, int irq, int level) > diff --git a/hw/net/xilinx_ethlite.c b/hw/net/xilinx_ethlite.c > index bd812908085..11eb53c4d60 100644 > --- a/hw/net/xilinx_ethlite.c > +++ b/hw/net/xilinx_ethlite.c > @@ -172,8 +172,8 @@ static const MemoryRegionOps eth_ops = { > .endianness = DEVICE_NATIVE_ENDIAN, > .valid = { > .min_access_size = 4, > - .max_access_size = 4 > - } > + .max_access_size = 4, > + }, > }; > > static bool eth_can_rx(NetClientState *nc) > diff --git a/hw/timer/xilinx_timer.c b/hw/timer/xilinx_timer.c > index 32a9df69e0b..0822345779c 100644 > --- a/hw/timer/xilinx_timer.c > +++ b/hw/timer/xilinx_timer.c > @@ -195,8 +195,8 @@ static const MemoryRegionOps timer_ops = { > .endianness = DEVICE_NATIVE_ENDIAN, > .valid = { > .min_access_size = 4, > - .max_access_size = 4 > - } > + .max_access_size = 4, > + }, > }; > > static void timer_hit(void *opaque) > -- > 2.45.2 > >
On Tue, Nov 05, 2024 at 02:04:18PM +0100, Philippe Mathieu-Daudé wrote: > Fix few MemoryRegionOps style before adding new fields > in the following commits. Wasn't aware of this style rule :-) Reviewed-by: Edgar E. Iglesias <edgar.iglesias@amd.com> > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > hw/char/xilinx_uartlite.c | 4 ++-- > hw/intc/xilinx_intc.c | 4 ++-- > hw/net/xilinx_ethlite.c | 4 ++-- > hw/timer/xilinx_timer.c | 4 ++-- > 4 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/hw/char/xilinx_uartlite.c b/hw/char/xilinx_uartlite.c > index f325084f8b9..a69ad769cc4 100644 > --- a/hw/char/xilinx_uartlite.c > +++ b/hw/char/xilinx_uartlite.c > @@ -172,8 +172,8 @@ static const MemoryRegionOps uart_ops = { > .endianness = DEVICE_NATIVE_ENDIAN, > .valid = { > .min_access_size = 1, > - .max_access_size = 4 > - } > + .max_access_size = 4, > + }, > }; > > static Property xilinx_uartlite_properties[] = { > diff --git a/hw/intc/xilinx_intc.c b/hw/intc/xilinx_intc.c > index 6e5012e66eb..2b8246f6206 100644 > --- a/hw/intc/xilinx_intc.c > +++ b/hw/intc/xilinx_intc.c > @@ -146,8 +146,8 @@ static const MemoryRegionOps pic_ops = { > .endianness = DEVICE_NATIVE_ENDIAN, > .valid = { > .min_access_size = 4, > - .max_access_size = 4 > - } > + .max_access_size = 4, > + }, > }; > > static void irq_handler(void *opaque, int irq, int level) > diff --git a/hw/net/xilinx_ethlite.c b/hw/net/xilinx_ethlite.c > index bd812908085..11eb53c4d60 100644 > --- a/hw/net/xilinx_ethlite.c > +++ b/hw/net/xilinx_ethlite.c > @@ -172,8 +172,8 @@ static const MemoryRegionOps eth_ops = { > .endianness = DEVICE_NATIVE_ENDIAN, > .valid = { > .min_access_size = 4, > - .max_access_size = 4 > - } > + .max_access_size = 4, > + }, > }; > > static bool eth_can_rx(NetClientState *nc) > diff --git a/hw/timer/xilinx_timer.c b/hw/timer/xilinx_timer.c > index 32a9df69e0b..0822345779c 100644 > --- a/hw/timer/xilinx_timer.c > +++ b/hw/timer/xilinx_timer.c > @@ -195,8 +195,8 @@ static const MemoryRegionOps timer_ops = { > .endianness = DEVICE_NATIVE_ENDIAN, > .valid = { > .min_access_size = 4, > - .max_access_size = 4 > - } > + .max_access_size = 4, > + }, > }; > > static void timer_hit(void *opaque) > -- > 2.45.2 >
diff --git a/hw/char/xilinx_uartlite.c b/hw/char/xilinx_uartlite.c index f325084f8b9..a69ad769cc4 100644 --- a/hw/char/xilinx_uartlite.c +++ b/hw/char/xilinx_uartlite.c @@ -172,8 +172,8 @@ static const MemoryRegionOps uart_ops = { .endianness = DEVICE_NATIVE_ENDIAN, .valid = { .min_access_size = 1, - .max_access_size = 4 - } + .max_access_size = 4, + }, }; static Property xilinx_uartlite_properties[] = { diff --git a/hw/intc/xilinx_intc.c b/hw/intc/xilinx_intc.c index 6e5012e66eb..2b8246f6206 100644 --- a/hw/intc/xilinx_intc.c +++ b/hw/intc/xilinx_intc.c @@ -146,8 +146,8 @@ static const MemoryRegionOps pic_ops = { .endianness = DEVICE_NATIVE_ENDIAN, .valid = { .min_access_size = 4, - .max_access_size = 4 - } + .max_access_size = 4, + }, }; static void irq_handler(void *opaque, int irq, int level) diff --git a/hw/net/xilinx_ethlite.c b/hw/net/xilinx_ethlite.c index bd812908085..11eb53c4d60 100644 --- a/hw/net/xilinx_ethlite.c +++ b/hw/net/xilinx_ethlite.c @@ -172,8 +172,8 @@ static const MemoryRegionOps eth_ops = { .endianness = DEVICE_NATIVE_ENDIAN, .valid = { .min_access_size = 4, - .max_access_size = 4 - } + .max_access_size = 4, + }, }; static bool eth_can_rx(NetClientState *nc) diff --git a/hw/timer/xilinx_timer.c b/hw/timer/xilinx_timer.c index 32a9df69e0b..0822345779c 100644 --- a/hw/timer/xilinx_timer.c +++ b/hw/timer/xilinx_timer.c @@ -195,8 +195,8 @@ static const MemoryRegionOps timer_ops = { .endianness = DEVICE_NATIVE_ENDIAN, .valid = { .min_access_size = 4, - .max_access_size = 4 - } + .max_access_size = 4, + }, }; static void timer_hit(void *opaque)
Fix few MemoryRegionOps style before adding new fields in the following commits. Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- hw/char/xilinx_uartlite.c | 4 ++-- hw/intc/xilinx_intc.c | 4 ++-- hw/net/xilinx_ethlite.c | 4 ++-- hw/timer/xilinx_timer.c | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-)