[v2] ethernet :mellanox :mlx4: Replace pci_pool_alloc by pci_pool_zalloc

Message ID CAFqt6za4QG30cArRE+F2DNS5VnpLbkP7jMGeauBRjTqMJwna2A@mail.gmail.com
State New
Headers show

Commit Message

Souptick Joarder Nov. 29, 2016, 8:25 a.m.
While sending the patch using "mutt" , alignment is getting changed.
In original patch file alignment is proper and
I have tested the patch with "checkpatch.pl". Attach is the original patch file.

I am using mutt -H < patch-file>

Any suggestion will be helpful?

On Tue, Nov 29, 2016 at 12:55 PM, Souptick Joarder <jrdr.linux@gmail.com> wrote:
> Please ignore this v2 patch.

>

> On Tue, Nov 29, 2016 at 12:29 PM, Souptick Joarder <jrdr.linux@gmail.com> wrote:

>> In mlx4_alloc_cmd_mailbox(), pci_pool_alloc() followed by memset will be

>> replaced by pci_pool_zalloc().

>>

>> Signed-off-by: Souptick joarder <jrdr.linux@gmail.com>

>> ---

>> v2:

>>   - Address comment from sergei

>>     Alignment was not proper

>>

>>  drivers/net/ethernet/mellanox/mlx4/cmd.c | 5 ++---

>>  1 file changed, 2 insertions(+), 3 deletions(-)

>>

>> diff --git a/drivers/net/ethernet/mellanox/mlx4/cmd.c b/drivers/net/ethernet/mellanox/mlx4/cmd.c

>> index e36bebc..96cdf9a 100644

>> --- a/drivers/net/ethernet/mellanox/mlx4/cmd.c

>> +++ b/drivers/net/ethernet/mellanox/mlx4/cmd.c

>> @@ -2679,14 +2679,13 @@ struct mlx4_cmd_mailbox *mlx4_alloc_cmd_mailbox(struct mlx4_dev *dev)

>>         if (!mailbox)

>>                 return ERR_PTR(-ENOMEM);

>>

>> -       mailbox->buf = pci_pool_alloc(mlx4_priv(dev)->cmd.pool, GFP_KERNEL,

>> -                                     &mailbox->dma);

>> +       mailbox->buf = pci_pool_zalloc(mlx4_priv(dev)->cmd.pool, GFP_KERNEL,

>> +                                      &mailbox->dma);

>>         if (!mailbox->buf) {

>>                 kfree(mailbox);

>>                 return ERR_PTR(-ENOMEM);

>>         }

>>

>> -       memset(mailbox->buf, 0, MLX4_MAILBOX_SIZE);

>>

>>         return mailbox;

>>  }

>> --

>> 1.9.1

>>


Regards
Souptick

Patch

From 3621eac92d271332ecc95b6f09ce25b7c6846137 Mon Sep 17 00:00:00 2001
From: Souptick Joarder <jrdr.linux@gmail.com>
Date: Tue, 29 Nov 2016 12:15:39 +0530
Subject: [PATCH v2] ethernet :mellanox :mlx4: Replace pci_pool_alloc by
 pci_pool_zalloc

In mlx4_alloc_cmd_mailbox(), pci_pool_alloc() followed by memset will be
replaced by pci_pool_zalloc().

Signed-off-by: Souptick joarder <jrdr.linux@gmail.com>
---
v2:
  - Address comment from sergei
    Alignment was not proper

 drivers/net/ethernet/mellanox/mlx4/cmd.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx4/cmd.c b/drivers/net/ethernet/mellanox/mlx4/cmd.c
index e36bebc..96cdf9a 100644
--- a/drivers/net/ethernet/mellanox/mlx4/cmd.c
+++ b/drivers/net/ethernet/mellanox/mlx4/cmd.c
@@ -2679,14 +2679,13 @@  struct mlx4_cmd_mailbox *mlx4_alloc_cmd_mailbox(struct mlx4_dev *dev)
 	if (!mailbox)
 		return ERR_PTR(-ENOMEM);
 
-	mailbox->buf = pci_pool_alloc(mlx4_priv(dev)->cmd.pool, GFP_KERNEL,
-				      &mailbox->dma);
+	mailbox->buf = pci_pool_zalloc(mlx4_priv(dev)->cmd.pool, GFP_KERNEL,
+				       &mailbox->dma);
 	if (!mailbox->buf) {
 		kfree(mailbox);
 		return ERR_PTR(-ENOMEM);
 	}
 
-	memset(mailbox->buf, 0, MLX4_MAILBOX_SIZE);
 
 	return mailbox;
 }
-- 
1.9.1