[1/6,V3] EXYNOS5: Fix system register structure

Message ID 1336471922-19336-2-git-send-email-rajeshwari.s@samsung.com
State Superseded
Headers show

Commit Message

Rajeshwari Shinde May 8, 2012, 10:11 a.m.
This patch corrects the SYSREG structure.
We have removed the sysreg.h added in the previous patchset
version as the sysreg structure is already defined in system.h.

Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
Acked-by: Minkyu Kang <mk7.kang@samsung.com>
---
Changes for v2:
	- Removed the definitions added for SYSREG registers as they were 
	already defined in system.h
	- Corrected the already exsisted exynos5_sysreg as per the user manual. 
 arch/arm/include/asm/arch-exynos/system.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Comments

Marek Vasut May 9, 2012, 8:49 a.m. | #1
Dear Rajeshwari Shinde,

> This patch corrects the SYSREG structure.
> We have removed the sysreg.h added in the previous patchset
> version as the sysreg structure is already defined in system.h.
> 
> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
> Acked-by: Minkyu Kang <mk7.kang@samsung.com>
> ---
> Changes for v2:
> 	- Removed the definitions added for SYSREG registers as they were
> 	already defined in system.h
> 	- Corrected the already exsisted exynos5_sysreg as per the user manual.
>  arch/arm/include/asm/arch-exynos/system.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/include/asm/arch-exynos/system.h
> b/arch/arm/include/asm/arch-exynos/system.h index c85f949..c1d880f 100644
> --- a/arch/arm/include/asm/arch-exynos/system.h
> +++ b/arch/arm/include/asm/arch-exynos/system.h

Ok, I tried applying this, but system.h is missing in my tree ... did I miss any 
other patchset?

> @@ -42,6 +42,7 @@ struct exynos5_sysreg {
>  	unsigned int	reserved;
>  	unsigned int	ispblk_cfg;
>  	unsigned int	usb20phy_cfg;
> +	unsigned char	res2[0x29c];
>  	unsigned int	mipi_dphy;
>  	unsigned int	dptx_dphy;
>  	unsigned int	phyclk_sel;

Best regards,
Marek Vasut
Chander Kashyap May 9, 2012, 9:47 a.m. | #2
Dear Marek,


On 9 May 2012 14:19, Marek Vasut <marex@denx.de> wrote:
> Dear Rajeshwari Shinde,
>
>> This patch corrects the SYSREG structure.
>> We have removed the sysreg.h added in the previous patchset
>> version as the sysreg structure is already defined in system.h.
>>
>> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
>> Acked-by: Minkyu Kang <mk7.kang@samsung.com>
>> ---
>> Changes for v2:
>>       - Removed the definitions added for SYSREG registers as they were
>>       already defined in system.h
>>       - Corrected the already exsisted exynos5_sysreg as per the user manual.
>>  arch/arm/include/asm/arch-exynos/system.h |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/include/asm/arch-exynos/system.h
>> b/arch/arm/include/asm/arch-exynos/system.h index c85f949..c1d880f 100644
>> --- a/arch/arm/include/asm/arch-exynos/system.h
>> +++ b/arch/arm/include/asm/arch-exynos/system.h
>
> Ok, I tried applying this, but system.h is missing in my tree ... did I miss any
> other patchset?
>

Well patches are already availabel at u-boot-arm tree.
http://git.denx.de/?p=u-boot/u-boot-arm.git;a=summary

>> @@ -42,6 +42,7 @@ struct exynos5_sysreg {
>>       unsigned int    reserved;
>>       unsigned int    ispblk_cfg;
>>       unsigned int    usb20phy_cfg;
>> +     unsigned char   res2[0x29c];
>>       unsigned int    mipi_dphy;
>>       unsigned int    dptx_dphy;
>>       unsigned int    phyclk_sel;
>
> Best regards,
> Marek Vasut
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
Chander Kashyap May 9, 2012, 9:48 a.m. | #3
On 9 May 2012 15:17, Chander Kashyap <chander.kashyap@linaro.org> wrote:
> Dear Marek,
>
>
> On 9 May 2012 14:19, Marek Vasut <marex@denx.de> wrote:
>> Dear Rajeshwari Shinde,
>>
>>> This patch corrects the SYSREG structure.
>>> We have removed the sysreg.h added in the previous patchset
>>> version as the sysreg structure is already defined in system.h.
>>>
>>> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
>>> Acked-by: Minkyu Kang <mk7.kang@samsung.com>
>>> ---
>>> Changes for v2:
>>>       - Removed the definitions added for SYSREG registers as they were
>>>       already defined in system.h
>>>       - Corrected the already exsisted exynos5_sysreg as per the user manual.
>>>  arch/arm/include/asm/arch-exynos/system.h |    1 +
>>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/include/asm/arch-exynos/system.h
>>> b/arch/arm/include/asm/arch-exynos/system.h index c85f949..c1d880f 100644
>>> --- a/arch/arm/include/asm/arch-exynos/system.h
>>> +++ b/arch/arm/include/asm/arch-exynos/system.h
>>
>> Ok, I tried applying this, but system.h is missing in my tree ... did I miss any
>> other patchset?
>>
>
> Well patches are already availabel at u-boot-arm tree.
> http://git.denx.de/?p=u-boot/u-boot-arm.git;a=summary

EXYNOS: definitions of system resgister and power management registers.

>
>>> @@ -42,6 +42,7 @@ struct exynos5_sysreg {
>>>       unsigned int    reserved;
>>>       unsigned int    ispblk_cfg;
>>>       unsigned int    usb20phy_cfg;
>>> +     unsigned char   res2[0x29c];
>>>       unsigned int    mipi_dphy;
>>>       unsigned int    dptx_dphy;
>>>       unsigned int    phyclk_sel;
>>
>> Best regards,
>> Marek Vasut
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot@lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
>
>
>
> --
> with warm regards,
> Chander Kashyap
Marek Vasut May 9, 2012, 10:19 a.m. | #4
Dear Chander Kashyap,

> On 9 May 2012 15:17, Chander Kashyap <chander.kashyap@linaro.org> wrote:
> > Dear Marek,
> > 
> > On 9 May 2012 14:19, Marek Vasut <marex@denx.de> wrote:
> >> Dear Rajeshwari Shinde,
> >> 
> >>> This patch corrects the SYSREG structure.
> >>> We have removed the sysreg.h added in the previous patchset
> >>> version as the sysreg structure is already defined in system.h.
> >>> 
> >>> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
> >>> Acked-by: Minkyu Kang <mk7.kang@samsung.com>
> >>> ---
> >>> Changes for v2:
> >>>       - Removed the definitions added for SYSREG registers as they were
> >>>       already defined in system.h
> >>>       - Corrected the already exsisted exynos5_sysreg as per the user
> >>> manual. arch/arm/include/asm/arch-exynos/system.h |    1 +
> >>>  1 files changed, 1 insertions(+), 0 deletions(-)
> >>> 
> >>> diff --git a/arch/arm/include/asm/arch-exynos/system.h
> >>> b/arch/arm/include/asm/arch-exynos/system.h index c85f949..c1d880f
> >>> 100644 --- a/arch/arm/include/asm/arch-exynos/system.h
> >>> +++ b/arch/arm/include/asm/arch-exynos/system.h
> >> 
> >> Ok, I tried applying this, but system.h is missing in my tree ... did I
> >> miss any other patchset?
> > 
> > Well patches are already availabel at u-boot-arm tree.
> > http://git.denx.de/?p=u-boot/u-boot-arm.git;a=summary
> 
> EXYNOS: definitions of system resgister and power management registers.

I see ... I'll wait until these are mainline then.

> 
> >>> @@ -42,6 +42,7 @@ struct exynos5_sysreg {
> >>>       unsigned int    reserved;
> >>>       unsigned int    ispblk_cfg;
> >>>       unsigned int    usb20phy_cfg;
> >>> +     unsigned char   res2[0x29c];
> >>>       unsigned int    mipi_dphy;
> >>>       unsigned int    dptx_dphy;
> >>>       unsigned int    phyclk_sel;
> >> 
> >> Best regards,
> >> Marek Vasut
> > 
> > --
> > with warm regards,
> > Chander Kashyap

Best regards,
Marek Vasut

Patch

diff --git a/arch/arm/include/asm/arch-exynos/system.h b/arch/arm/include/asm/arch-exynos/system.h
index c85f949..c1d880f 100644
--- a/arch/arm/include/asm/arch-exynos/system.h
+++ b/arch/arm/include/asm/arch-exynos/system.h
@@ -42,6 +42,7 @@  struct exynos5_sysreg {
 	unsigned int	reserved;
 	unsigned int	ispblk_cfg;
 	unsigned int	usb20phy_cfg;
+	unsigned char	res2[0x29c];
 	unsigned int	mipi_dphy;
 	unsigned int	dptx_dphy;
 	unsigned int	phyclk_sel;