| Message ID | 20241125105240.44219-1-cgoettsche@seltendoof.de |
|---|---|
| State | New |
| Headers | show |
| Series | kunit: constify return of string literals | expand |
On Tue, 26 Nov 2024 at 12:36, Christian Göttsche <cgoettsche@seltendoof.de> wrote: > > From: Christian Göttsche <cgzones@googlemail.com> > > The function kunit_status_to_ok_not_ok() returns string literals, thus > declare the return value as such. > > Reported by clang: > > ./include/kunit/test.h:143:10: warning: returning 'const char[3]' from a function with result type 'char *' discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers] > 143 | return "ok"; > | ^~~~ > ./include/kunit/test.h:145:10: warning: returning 'const char[7]' from a function with result type 'char *' discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers] > 145 | return "not ok"; > | ^~~~~~~~ > ./include/kunit/test.h:147:9: warning: returning 'const char[8]' from a function with result type 'char *' discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers] > 147 | return "invalid"; > | ^~~~~~~~~ > > Signed-off-by: Christian Göttsche <cgzones@googlemail.com> Kindly ping. > --- > include/kunit/test.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/kunit/test.h b/include/kunit/test.h > index 34b71e42fb10..ae1b57578476 100644 > --- a/include/kunit/test.h > +++ b/include/kunit/test.h > @@ -135,7 +135,7 @@ struct kunit_case { > struct string_stream *log; > }; > > -static inline char *kunit_status_to_ok_not_ok(enum kunit_status status) > +static inline const char *kunit_status_to_ok_not_ok(enum kunit_status status) > { > switch (status) { > case KUNIT_SKIPPED: > -- > 2.45.2 >
diff --git a/include/kunit/test.h b/include/kunit/test.h index 34b71e42fb10..ae1b57578476 100644 --- a/include/kunit/test.h +++ b/include/kunit/test.h @@ -135,7 +135,7 @@ struct kunit_case { struct string_stream *log; }; -static inline char *kunit_status_to_ok_not_ok(enum kunit_status status) +static inline const char *kunit_status_to_ok_not_ok(enum kunit_status status) { switch (status) { case KUNIT_SKIPPED: