From patchwork Tue Nov 29 14:45:49 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Milard X-Patchwork-Id: 84837 Delivered-To: patch@linaro.org Received: by 10.140.20.101 with SMTP id 92csp1628736qgi; Tue, 29 Nov 2016 06:52:26 -0800 (PST) X-Received: by 10.200.48.143 with SMTP id v15mr25393965qta.61.1480431146913; Tue, 29 Nov 2016 06:52:26 -0800 (PST) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id i46si27679549qta.29.2016.11.29.06.52.26; Tue, 29 Nov 2016 06:52:26 -0800 (PST) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 8587D60908; Tue, 29 Nov 2016 14:52:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 1830C60720; Tue, 29 Nov 2016 14:52:21 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 3D0BC60699; Tue, 29 Nov 2016 14:51:56 +0000 (UTC) Received: from mail-lf0-f52.google.com (mail-lf0-f52.google.com [209.85.215.52]) by lists.linaro.org (Postfix) with ESMTPS id A6A6360918 for ; Tue, 29 Nov 2016 14:46:01 +0000 (UTC) Received: by mail-lf0-f52.google.com with SMTP id t196so123502581lff.3 for ; Tue, 29 Nov 2016 06:46:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=hn+0rd41YkyV8Q+NX0ICzSkyD30XMuT4+hNEEUKGD3I=; b=mWwztT7k9OAkm9N/uNbsdrY097Pz64HhI0jCouEX7v+pSlb2FV11zhg2aB2IMYBGmn HrMTTiv1482DXb6YmIiWNavIcuQxvimDePHZp/b1MRcIVpdAMJBJDkuubR151KZ4+ovV F7CkaGULQUsx1O2rh1TLocycfztkr3PxfG85Kexf5AE1Z3SDWUDyyJpygPGx0+BDxwuq mHKXK4FFkm0Ka2J3E9Zqt2GR1gxsGQGfm5h4jCDX/ixdhMRIzYejj9G+mDAjtCH8ibdi 9jQtuclaK1s62Njy6plsY8XH7wQy7k4DlOoy2sAm2LvC7qF1oCmgI37xOkZbxlDfzE7v eFkA== X-Gm-Message-State: AKaTC01l5PpIlwOr+UnKjBlke5/ZskpFWXtZKfW1uLH/b2ZYCJ9YPT1JKIQRFJjncOpfWjbhn8s= X-Received: by 10.25.29.8 with SMTP id d8mr8519694lfd.18.1480430760493; Tue, 29 Nov 2016 06:46:00 -0800 (PST) Received: from localhost.localdomain (c-83-233-76-66.cust.bredband2.com. [83.233.76.66]) by smtp.gmail.com with ESMTPSA id n124sm13723227lfb.33.2016.11.29.06.45.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 29 Nov 2016 06:45:59 -0800 (PST) From: Christophe Milard To: maxim.uvarov@linaro.com, petri.savolainen@nokia.com, bill.fischofer@linaro.org, lng-odp@lists.linaro.org Date: Tue, 29 Nov 2016 15:45:49 +0100 Message-Id: <1480430749-4804-1-git-send-email-christophe.milard@linaro.org> X-Mailer: git-send-email 2.7.4 Subject: [lng-odp] [API-NEXT PATCH] test: drvshm: removing invalid test X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" The test trying to free a unallocated address is now erroneous since ODP is using ishm too: unknown drvshm addresses may well be valid ODP addresses, in which case the test frees someone else memory! The test is simply suppressed. Signed-off-by: Christophe Milard --- test/common_plat/validation/drv/drvshmem/drvshmem.c | 2 -- 1 file changed, 2 deletions(-) -- 2.7.4 Reviewed-by: Petri Savolainen diff --git a/test/common_plat/validation/drv/drvshmem/drvshmem.c b/test/common_plat/validation/drv/drvshmem/drvshmem.c index 559c55d..0247a03 100644 --- a/test/common_plat/validation/drv/drvshmem/drvshmem.c +++ b/test/common_plat/validation/drv/drvshmem/drvshmem.c @@ -135,8 +135,6 @@ void drvshmem_test_basic(void) shared_test_data->foo = TEST_SHARE_FOO; shared_test_data->bar = TEST_SHARE_BAR; - CU_ASSERT(odpdrv_shm_free_by_address((char *)shared_test_data - 1) < 0); - thrdarg.numthrds = odp_cpumask_default_worker(&unused, 0); if (thrdarg.numthrds > MAX_WORKERS)