[1/2] ARM: DAVINCI: cpuidle - remove useless state count initialization

Message ID 1336639485-26955-2-git-send-email-daniel.lezcano@linaro.org
State New
Headers show

Commit Message

Daniel Lezcano May 10, 2012, 8:44 a.m.
The state count is initialized in the driver structure, the cpuidle
core uses it to initialize the device state count.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 arch/arm/mach-davinci/cpuidle.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

Comments

Sekhar Nori May 20, 2012, 9:24 a.m. | #1
Hi Daniel,

On 5/10/2012 2:14 PM, Daniel Lezcano wrote:
> The state count is initialized in the driver structure, the cpuidle
> core uses it to initialize the device state count.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>

Looks good to me. Will queue for v3.6

Nit: In future, please use davinci in small case in subject line to keep
it consistent with other DaVinci patches.

Thanks,
Sekhar

Patch

diff --git a/arch/arm/mach-davinci/cpuidle.c b/arch/arm/mach-davinci/cpuidle.c
index 9107691..f0f179c 100644
--- a/arch/arm/mach-davinci/cpuidle.c
+++ b/arch/arm/mach-davinci/cpuidle.c
@@ -128,8 +128,6 @@  static int __init davinci_cpuidle_probe(struct platform_device *pdev)
 		davinci_states[1].flags |= DAVINCI_CPUIDLE_FLAGS_DDR2_PWDN;
 	cpuidle_set_statedata(&device->states_usage[1], &davinci_states[1]);
 
-	device->state_count = DAVINCI_CPUIDLE_MAX_STATES;
-
 	ret = cpuidle_register_driver(&davinci_idle_driver);
 	if (ret) {
 		dev_err(&pdev->dev, "failed to register driver\n");