[PATCHv10,3/3] configure.ac update version numbers

Message ID 1480537973-7830-4-git-send-email-maxim.uvarov@linaro.org
State New
Headers show

Commit Message

Maxim Uvarov Nov. 30, 2016, 8:32 p.m.
Default is abi compat mode, all interface functions changed,
so increase first number of .so

Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>

---
 configure.ac | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

-- 
2.7.1.250.gff4ea60

Comments

Mike Holmes Nov. 30, 2016, 9:02 p.m. | #1
I just CC'ed you in Steve.

My head is spinning but I think we have this straight now, perhaps you have
time to sync with Maxim and  possibly Anders if he has time to check this
from ytour Debian background?

I think if we can get the next couple of release out correctly the pattern
will establish and it will be easier by the time we get to TigerMoth.

Mike

On 30 November 2016 at 15:32, Maxim Uvarov <maxim.uvarov@linaro.org> wrote:

> Default is abi compat mode, all interface functions changed,

> so increase first number of .so

>

> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>

> ---

>  configure.ac | 6 +++---

>  1 file changed, 3 insertions(+), 3 deletions(-)

>

> diff --git a/configure.ac b/configure.ac

> index b460a65..fe7e47d 100644

> --- a/configure.ac

> +++ b/configure.ac

> @@ -3,7 +3,7 @@ AC_PREREQ([2.5])

>  # Set correct API version

>  ############################################################

> ##############

>  m4_define([odpapi_generation_version], [1])

> -m4_define([odpapi_major_version], [11])

> +m4_define([odpapi_major_version], [12])

>  m4_define([odpapi_minor_version], [0])

>  m4_define([odpapi_point_version], [0])

>  m4_define([odpapi_version],

> @@ -30,10 +30,10 @@ AM_SILENT_RULES([yes])

>  ############################################################

> ##############

>  # Set correct platform library version

>  ############################################################

> ##############

> -ODP_LIBSO_VERSION=111:0:0

> +ODP_LIBSO_VERSION=112:0:0

>  AC_SUBST(ODP_LIBSO_VERSION)

>

> -ODPHELPER_LIBSO_VERSION=110:0:1

> +ODPHELPER_LIBSO_VERSION=110:1:2

>  AC_SUBST(ODPHELPER_LIBSO_VERSION)

>

>  # Checks for programs.

> --

> 2.7.1.250.gff4ea60

>

>



-- 
Mike Holmes
Program Manager - Linaro Networking Group
Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs
"Work should be fun and collaborative, the rest follows"
Anders Roxell Nov. 30, 2016, 10:09 p.m. | #2
On 30 November 2016 at 22:02, Mike Holmes <mike.holmes@linaro.org> wrote:
> I just CC'ed you in Steve.

>

> My head is spinning but I think we have this straight now, perhaps you have

> time to sync with Maxim and  possibly Anders if he has time to check this

> from ytour Debian background?

>

> I think if we can get the next couple of release out correctly the pattern

> will establish and it will be easier by the time we get to TigerMoth.

>

> Mike

>

> On 30 November 2016 at 15:32, Maxim Uvarov <maxim.uvarov@linaro.org> wrote:

>

>> Default is abi compat mode, all interface functions changed,

>> so increase first number of .so

>>

>> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>

>> ---

>>  configure.ac | 6 +++---

>>  1 file changed, 3 insertions(+), 3 deletions(-)

>>

>> diff --git a/configure.ac b/configure.ac

>> index b460a65..fe7e47d 100644

>> --- a/configure.ac

>> +++ b/configure.ac

>> @@ -3,7 +3,7 @@ AC_PREREQ([2.5])

>>  # Set correct API version

>>  ############################################################

>> ##############

>>  m4_define([odpapi_generation_version], [1])

>> -m4_define([odpapi_major_version], [11])

>> +m4_define([odpapi_major_version], [12])

>>  m4_define([odpapi_minor_version], [0])

>>  m4_define([odpapi_point_version], [0])

>>  m4_define([odpapi_version],

>> @@ -30,10 +30,10 @@ AM_SILENT_RULES([yes])

>>  ############################################################

>> ##############

>>  # Set correct platform library version

>>  ############################################################

>> ##############

>> -ODP_LIBSO_VERSION=111:0:0

>> +ODP_LIBSO_VERSION=112:0:0

>>  AC_SUBST(ODP_LIBSO_VERSION)

>>

>> -ODPHELPER_LIBSO_VERSION=110:0:1

>> +ODPHELPER_LIBSO_VERSION=110:1:2


Since the ABI isn't changed we shouldn't bump the age only the revision.
The curl project [1] describes the rules in a easier way.

Cheers,
Anders
[1] https://github.com/curl/curl/blob/master/lib/Makefile.am#L95

>>  AC_SUBST(ODPHELPER_LIBSO_VERSION)

>>

>>  # Checks for programs.

>> --

>> 2.7.1.250.gff4ea60

>>

>>

>

>

> --

> Mike Holmes

> Program Manager - Linaro Networking Group

> Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs

> "Work should be fun and collaborative, the rest follows"
Maxim Uvarov Dec. 1, 2016, 1:05 p.m. | #3
On 12/01/16 01:09, Anders Roxell wrote:
> On 30 November 2016 at 22:02, Mike Holmes <mike.holmes@linaro.org> wrote:

>> I just CC'ed you in Steve.

>>

>> My head is spinning but I think we have this straight now, perhaps you have

>> time to sync with Maxim and  possibly Anders if he has time to check this

>> from ytour Debian background?

>>

>> I think if we can get the next couple of release out correctly the pattern

>> will establish and it will be easier by the time we get to TigerMoth.

>>

>> Mike

>>

>> On 30 November 2016 at 15:32, Maxim Uvarov <maxim.uvarov@linaro.org> wrote:

>>

>>> Default is abi compat mode, all interface functions changed,

>>> so increase first number of .so

>>>

>>> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>

>>> ---

>>>   configure.ac | 6 +++---

>>>   1 file changed, 3 insertions(+), 3 deletions(-)

>>>

>>> diff --git a/configure.ac b/configure.ac

>>> index b460a65..fe7e47d 100644

>>> --- a/configure.ac

>>> +++ b/configure.ac

>>> @@ -3,7 +3,7 @@ AC_PREREQ([2.5])

>>>   # Set correct API version

>>>   ############################################################

>>> ##############

>>>   m4_define([odpapi_generation_version], [1])

>>> -m4_define([odpapi_major_version], [11])

>>> +m4_define([odpapi_major_version], [12])

>>>   m4_define([odpapi_minor_version], [0])

>>>   m4_define([odpapi_point_version], [0])

>>>   m4_define([odpapi_version],

>>> @@ -30,10 +30,10 @@ AM_SILENT_RULES([yes])

>>>   ############################################################

>>> ##############

>>>   # Set correct platform library version

>>>   ############################################################

>>> ##############

>>> -ODP_LIBSO_VERSION=111:0:0

>>> +ODP_LIBSO_VERSION=112:0:0

>>>   AC_SUBST(ODP_LIBSO_VERSION)

>>>

>>> -ODPHELPER_LIBSO_VERSION=110:0:1

>>> +ODPHELPER_LIBSO_VERSION=110:1:2

> Since the ABI isn't changed we shouldn't bump the age only the revision.

> The curl project [1] describes the rules in a easier way.

>

> Cheers,

> Anders

> [1] https://github.com/curl/curl/blob/master/lib/Makefile.am#L95


curl project is not official documentation for autotools. So we can take 
this under account but can not just follow it.

So we have 2 official links describing that numbers:

1. https://autotools.io/libtool/version.html
2. 
https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html

 From link 1:
"Always increase the revision value. "

 From link 2:
"If the library source code has changed at all since the last update, 
then increment revision (‘c:r:a’ becomes ‘c:/r+1/:a’). "


So I think we understood document right.

Maxim.

>>>   AC_SUBST(ODPHELPER_LIBSO_VERSION)

>>>

>>>   # Checks for programs.

>>> --

>>> 2.7.1.250.gff4ea60

>>>

>>>

>>

>> --

>> Mike Holmes

>> Program Manager - Linaro Networking Group

>> Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs

>> "Work should be fun and collaborative, the rest follows"
Steve McIntyre Dec. 1, 2016, 2:17 p.m. | #4
On Thu, Dec 01, 2016 at 04:05:14PM +0300, Maxim Uvarov wrote:
>On 12/01/16 01:09, Anders Roxell wrote:

>> Since the ABI isn't changed we shouldn't bump the age only the revision.

>> The curl project [1] describes the rules in a easier way.

>>

>>[1] https://github.com/curl/curl/blob/master/lib/Makefile.am#L95

>

>curl project is not official documentation for autotools. So we can take this

>under account but can not just follow it.

>

>So we have 2 official links describing that numbers:

>

>1. https://autotools.io/libtool/version.html

>2. https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html

>

>From link 1:

>"Always increase the revision value. "

>

>From link 2:

>"If the library source code has changed at all since the last update, then

>increment revision (‘c:r:a’ becomes ‘c:/r+1/:a’). "


Hi guys,

Two things here...

1. Maxim's two docs say exactly what the curl doc says - just in
   different language. Also from link 1:

   """
   Warning

   A common mistake is to assume that the three values passed to
   -version-info map directly into the three numbers at the end of the
   library name. This is not the case, and indeed, current, revision
   and age are applied differently depending on the operating system
   that one is using.
   """

   The libtool -version_info stuff is *horrendously* confusing for
   many people precisely because of this awful mismatch :-( WTF
   they've defined things this way I have no idea...

2. That just describes the *revision*, however. You've also increased
   the *age* by 2, and that's what Anders was complaining about. From
   the doc you have referenced here (link 1), increasing the *age* but
   not touching *current* makes no sense:

   * Increase the current value whenever an interface has been added, removed or changed.
   * Increase the age value only if the changes made to the ABI are backward compatible.

   The curl doc again agrees with that.

Do these two points make sense to people?

Cheers,
-- 
Steve McIntyre                                steve.mcintyre@linaro.org
<http://www.linaro.org/> Linaro.org | Open source software for ARM SoCs
Mike Holmes Dec. 1, 2016, 2:25 p.m. | #5
Thanks Steve

In an effort to close on this

Steve and Anders both say it should be

-ODPHELPER_LIBSO_VERSION=110:0:1
+ODPHELPER_LIBSO_VERSION=110:1:1

And they are our best resourse I consider my self educated :)
Maxim / Anders can we take the CURL  text and add any extra explanation we
need before  adding it to our docs ?

Mike

On 1 December 2016 at 09:17, Steve McIntyre <steve.mcintyre@linaro.org>
wrote:

> On Thu, Dec 01, 2016 at 04:05:14PM +0300, Maxim Uvarov wrote:

> >On 12/01/16 01:09, Anders Roxell wrote:

> >> Since the ABI isn't changed we shouldn't bump the age only the revision.

> >> The curl project [1] describes the rules in a easier way.

> >>

> >>[1] https://github.com/curl/curl/blob/master/lib/Makefile.am#L95

> >

> >curl project is not official documentation for autotools. So we can take

> this

> >under account but can not just follow it.

> >

> >So we have 2 official links describing that numbers:

> >

> >1. https://autotools.io/libtool/version.html

> >2. https://www.gnu.org/software/libtool/manual/html_node/

> Updating-version-info.html

> >

> >From link 1:

> >"Always increase the revision value. "

> >

> >From link 2:

> >"If the library source code has changed at all since the last update, then

> >increment revision (‘c:r:a’ becomes ‘c:/r+1/:a’). "

>

> Hi guys,

>

> Two things here...

>

> 1. Maxim's two docs say exactly what the curl doc says - just in

>    different language. Also from link 1:

>

>    """

>    Warning

>

>    A common mistake is to assume that the three values passed to

>    -version-info map directly into the three numbers at the end of the

>    library name. This is not the case, and indeed, current, revision

>    and age are applied differently depending on the operating system

>    that one is using.

>    """

>

>    The libtool -version_info stuff is *horrendously* confusing for

>    many people precisely because of this awful mismatch :-( WTF

>    they've defined things this way I have no idea...

>

> 2. That just describes the *revision*, however. You've also increased

>    the *age* by 2, and that's what Anders was complaining about. From

>    the doc you have referenced here (link 1), increasing the *age* but

>    not touching *current* makes no sense:

>

>    * Increase the current value whenever an interface has been added,

> removed or changed.

>    * Increase the age value only if the changes made to the ABI are

> backward compatible.

>

>    The curl doc again agrees with that.

>

> Do these two points make sense to people?

>

> Cheers,

> --

> Steve McIntyre                                steve.mcintyre@linaro.org

> <http://www.linaro.org/> Linaro.org | Open source software for ARM SoCs

>

>



-- 
Mike Holmes
Program Manager - Linaro Networking Group
Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs
"Work should be fun and collaborative, the rest follows"
Maxim Uvarov Dec. 1, 2016, 2:29 p.m. | #6
On 12/01/16 17:25, Mike Holmes wrote:
> Thanks Steve

>

> In an effort to close on this

>

> Steve and Anders both say it should be

>

> -ODPHELPER_LIBSO_VERSION=110:0:1

> +ODPHELPER_LIBSO_VERSION=110:1:1

>

> And they are our best resourse I consider my self educated :)

> Maxim / Anders can we take the CURL  text and add any extra 

> explanation we need before  adding it to our docs ?

>

> Mike


ok, if first two patches ok then please add review-by and I will resping 
the latest with that changes and comment from curl.

Maxim.

>

> On 1 December 2016 at 09:17, Steve McIntyre <steve.mcintyre@linaro.org 

> <mailto:steve.mcintyre@linaro.org>> wrote:

>

>     On Thu, Dec 01, 2016 at 04:05:14PM +0300, Maxim Uvarov wrote:

>     >On 12/01/16 01:09, Anders Roxell wrote:

>     >> Since the ABI isn't changed we shouldn't bump the age only the revision.

>     >> The curl project [1] describes the rules in a easier way.

>     >>

>     >>[1]https://github.com/curl/curl/blob/master/lib/Makefile.am#L95

>     <https://github.com/curl/curl/blob/master/lib/Makefile.am#L95>

>     >

>     >curl project is not official documentation for autotools. So we

>     can take this

>     >under account but can not just follow it.

>     >

>     >So we have 2 official links describing that numbers:

>     >

>     >1. https://autotools.io/libtool/version.html

>     <https://autotools.io/libtool/version.html>

>     >2.

>     https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html

>     <https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html>

>     >

>     >From link 1:

>     >"Always increase the revision value. "

>     >

>     >From link 2:

>     >"If the library source code has changed at all since the last

>     update, then

>     >increment revision (‘c:r:a’ becomes ‘c:/r+1/:a’). "

>

>     Hi guys,

>

>     Two things here...

>

>     1. Maxim's two docs say exactly what the curl doc says - just in

>        different language. Also from link 1:

>

>        """

>        Warning

>

>        A common mistake is to assume that the three values passed to

>        -version-info map directly into the three numbers at the end of the

>        library name. This is not the case, and indeed, current, revision

>        and age are applied differently depending on the operating system

>        that one is using.

>        """

>

>        The libtool -version_info stuff is *horrendously* confusing for

>        many people precisely because of this awful mismatch :-( WTF

>        they've defined things this way I have no idea...

>

>     2. That just describes the *revision*, however. You've also increased

>        the *age* by 2, and that's what Anders was complaining about. From

>        the doc you have referenced here (link 1), increasing the *age* but

>        not touching *current* makes no sense:

>

>        * Increase the current value whenever an interface has been

>     added, removed or changed.

>        * Increase the age value only if the changes made to the ABI

>     are backward compatible.

>

>        The curl doc again agrees with that.

>

>     Do these two points make sense to people?

>

>     Cheers,

>     --

>     Steve McIntyre steve.mcintyre@linaro.org

>     <mailto:steve.mcintyre@linaro.org>

>     <http://www.linaro.org/> Linaro.org | Open source software for ARM

>     SoCs

>

>

>

>

> -- 

> Mike Holmes

> Program Manager - Linaro Networking Group

> Linaro.org <http://www.linaro.org/>***│ *Open source software for ARM SoCs

> "Work should be fun and collaborative, the rest follows"

>
Anders Roxell Dec. 1, 2016, 6:41 p.m. | #7
On 2016-12-01 17:29, Maxim Uvarov wrote:
> On 12/01/16 17:25, Mike Holmes wrote:

> >Thanks Steve

> >

> >In an effort to close on this

> >

> >Steve and Anders both say it should be

> >

> >-ODPHELPER_LIBSO_VERSION=110:0:1

> >+ODPHELPER_LIBSO_VERSION=110:1:1

> >

> >And they are our best resourse I consider my self educated :)

> >Maxim / Anders can we take the CURL  text and add any extra explanation we

> >need before  adding it to our docs ?

> >

> >Mike

> 

> ok, if first two patches ok then please add review-by and I will resping the

> latest with that changes and comment from curl.


Please add a link to the gnu [1] describes it as well.
[1] https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html

Cheers,
Anders

> 

> Maxim.

> 

> >

> >On 1 December 2016 at 09:17, Steve McIntyre <steve.mcintyre@linaro.org

> ><mailto:steve.mcintyre@linaro.org>> wrote:

> >

> >    On Thu, Dec 01, 2016 at 04:05:14PM +0300, Maxim Uvarov wrote:

> >    >On 12/01/16 01:09, Anders Roxell wrote:

> >    >> Since the ABI isn't changed we shouldn't bump the age only the revision.

> >    >> The curl project [1] describes the rules in a easier way.

> >    >>

> >    >>[1]https://github.com/curl/curl/blob/master/lib/Makefile.am#L95

> >    <https://github.com/curl/curl/blob/master/lib/Makefile.am#L95>

> >    >

> >    >curl project is not official documentation for autotools. So we

> >    can take this

> >    >under account but can not just follow it.

> >    >

> >    >So we have 2 official links describing that numbers:

> >    >

> >    >1. https://autotools.io/libtool/version.html

> >    <https://autotools.io/libtool/version.html>

> >    >2.

> >    https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html

> >    <https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html>

> >    >

> >    >From link 1:

> >    >"Always increase the revision value. "

> >    >

> >    >From link 2:

> >    >"If the library source code has changed at all since the last

> >    update, then

> >    >increment revision (‘c:r:a’ becomes ‘c:/r+1/:a’). "

> >

> >    Hi guys,

> >

> >    Two things here...

> >

> >    1. Maxim's two docs say exactly what the curl doc says - just in

> >       different language. Also from link 1:

> >

> >       """

> >       Warning

> >

> >       A common mistake is to assume that the three values passed to

> >       -version-info map directly into the three numbers at the end of the

> >       library name. This is not the case, and indeed, current, revision

> >       and age are applied differently depending on the operating system

> >       that one is using.

> >       """

> >

> >       The libtool -version_info stuff is *horrendously* confusing for

> >       many people precisely because of this awful mismatch :-( WTF

> >       they've defined things this way I have no idea...

> >

> >    2. That just describes the *revision*, however. You've also increased

> >       the *age* by 2, and that's what Anders was complaining about. From

> >       the doc you have referenced here (link 1), increasing the *age* but

> >       not touching *current* makes no sense:

> >

> >       * Increase the current value whenever an interface has been

> >    added, removed or changed.

> >       * Increase the age value only if the changes made to the ABI

> >    are backward compatible.

> >

> >       The curl doc again agrees with that.

> >

> >    Do these two points make sense to people?

> >

> >    Cheers,

> >    --

> >    Steve McIntyre steve.mcintyre@linaro.org

> >    <mailto:steve.mcintyre@linaro.org>

> >    <http://www.linaro.org/> Linaro.org | Open source software for ARM

> >    SoCs

> >

> >

> >

> >

> >-- 

> >Mike Holmes

> >Program Manager - Linaro Networking Group

> >Linaro.org <http://www.linaro.org/>***│ *Open source software for ARM SoCs

> >"Work should be fun and collaborative, the rest follows"

> >

> 


-- 
Anders Roxell
anders.roxell@linaro.org
M: +46 709 71 42 85 | IRC: roxell

Patch

diff --git a/configure.ac b/configure.ac
index b460a65..fe7e47d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3,7 +3,7 @@  AC_PREREQ([2.5])
 # Set correct API version
 ##########################################################################
 m4_define([odpapi_generation_version], [1])
-m4_define([odpapi_major_version], [11])
+m4_define([odpapi_major_version], [12])
 m4_define([odpapi_minor_version], [0])
 m4_define([odpapi_point_version], [0])
 m4_define([odpapi_version],
@@ -30,10 +30,10 @@  AM_SILENT_RULES([yes])
 ##########################################################################
 # Set correct platform library version
 ##########################################################################
-ODP_LIBSO_VERSION=111:0:0
+ODP_LIBSO_VERSION=112:0:0
 AC_SUBST(ODP_LIBSO_VERSION)
 
-ODPHELPER_LIBSO_VERSION=110:0:1
+ODPHELPER_LIBSO_VERSION=110:1:2
 AC_SUBST(ODPHELPER_LIBSO_VERSION)
 
 # Checks for programs.