devfreq: rk3399_dmc: Remove dangling rcu_read_unlock()

Message ID 2958843865a6ed790ff9ecfc9cacd54d752cace5.1480588927.git.viresh.kumar@linaro.org
State Accepted
Commit d8323de3d4062e1b5a5aa7e9c0f935138405a582
Headers show

Commit Message

Viresh Kumar Dec. 1, 2016, 10:42 a.m.
This call never had the rcu_read_lock() counterpart. Remove the unlock
part as well.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

---
 drivers/devfreq/rk3399_dmc.c | 1 -
 1 file changed, 1 deletion(-)

-- 
2.7.1.410.g6faf27b

--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Chanwoo Choi Dec. 2, 2016, 8:43 a.m. | #1
Hi Viresh,

On 2016년 12월 01일 19:42, Viresh Kumar wrote:
> This call never had the rcu_read_lock() counterpart. Remove the unlock

> part as well.

> 

> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

> ---

>  drivers/devfreq/rk3399_dmc.c | 1 -

>  1 file changed, 1 deletion(-)

> 

> diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c

> index 192240423fee..4cc5be08720a 100644

> --- a/drivers/devfreq/rk3399_dmc.c

> +++ b/drivers/devfreq/rk3399_dmc.c

> @@ -408,7 +408,6 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev)

>  	 */

>  	if (dev_pm_opp_of_add_table(dev)) {

>  		dev_err(dev, "Invalid operating-points in device tree.\n");

> -		rcu_read_unlock();

>  		return -EINVAL;

>  	}

>  

> 


Looks good to me.

Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>


-- 
Best Regards,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c
index 192240423fee..4cc5be08720a 100644
--- a/drivers/devfreq/rk3399_dmc.c
+++ b/drivers/devfreq/rk3399_dmc.c
@@ -408,7 +408,6 @@  static int rk3399_dmcfreq_probe(struct platform_device *pdev)
 	 */
 	if (dev_pm_opp_of_add_table(dev)) {
 		dev_err(dev, "Invalid operating-points in device tree.\n");
-		rcu_read_unlock();
 		return -EINVAL;
 	}