[API-NEXT,PATCHv2] linux-gen: pool add missing eof for error prints

Message ID 1480607973-11866-1-git-send-email-maxim.uvarov@linaro.org
State New
Headers show

Commit Message

Maxim Uvarov Dec. 1, 2016, 3:59 p.m.
During debug found missing end of lines in debug prints.

Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>

---
 platform/linux-generic/odp_pool.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

-- 
2.7.1.250.gff4ea60

Comments

Bill Fischofer Dec. 2, 2016, 12:35 a.m. | #1
On Thu, Dec 1, 2016 at 9:59 AM, Maxim Uvarov <maxim.uvarov@linaro.org> wrote:
> During debug found missing end of lines in debug prints.

>

> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>


Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org>


> ---

>  platform/linux-generic/odp_pool.c | 12 ++++++------

>  1 file changed, 6 insertions(+), 6 deletions(-)

>

> diff --git a/platform/linux-generic/odp_pool.c b/platform/linux-generic/odp_pool.c

> index 4be3827..f63efb6 100644

> --- a/platform/linux-generic/odp_pool.c

> +++ b/platform/linux-generic/odp_pool.c

> @@ -285,7 +285,7 @@ static odp_pool_t pool_create(const char *name, odp_pool_param_t *params,

>         char uarea_name[ODP_POOL_NAME_LEN + sizeof(postfix)];

>

>         if (params == NULL) {

> -               ODP_ERR("No params");

> +               ODP_ERR("No params\n");

>                 return ODP_POOL_INVALID;

>         }

>

> @@ -300,7 +300,7 @@ static odp_pool_t pool_create(const char *name, odp_pool_param_t *params,

>         /* Validate requested buffer alignment */

>         if (align > ODP_CONFIG_BUFFER_ALIGN_MAX ||

>             align != ODP_ALIGN_ROUNDDOWN_POWER_2(align, align)) {

> -               ODP_ERR("Bad align requirement");

> +               ODP_ERR("Bad align requirement\n");

>                 return ODP_POOL_INVALID;

>         }

>

> @@ -332,7 +332,7 @@ static odp_pool_t pool_create(const char *name, odp_pool_param_t *params,

>                 break;

>

>         default:

> -               ODP_ERR("Bad pool type");

> +               ODP_ERR("Bad pool type\n");

>                 return ODP_POOL_INVALID;

>         }

>

> @@ -342,7 +342,7 @@ static odp_pool_t pool_create(const char *name, odp_pool_param_t *params,

>         pool = reserve_pool();

>

>         if (pool == NULL) {

> -               ODP_ERR("No more free pools");

> +               ODP_ERR("No more free pools\n");

>                 return ODP_POOL_INVALID;

>         }

>

> @@ -390,7 +390,7 @@ static odp_pool_t pool_create(const char *name, odp_pool_param_t *params,

>         pool->shm = shm;

>

>         if (shm == ODP_SHM_INVALID) {

> -               ODP_ERR("Shm reserve failed");

> +               ODP_ERR("Shm reserve failed\n");

>                 goto error;

>         }

>

> @@ -404,7 +404,7 @@ static odp_pool_t pool_create(const char *name, odp_pool_param_t *params,

>                 pool->uarea_shm = shm;

>

>                 if (shm == ODP_SHM_INVALID) {

> -                       ODP_ERR("Shm reserve failed (uarea)");

> +                       ODP_ERR("Shm reserve failed (uarea)\n");

>                         goto error;

>                 }

>

> --

> 2.7.1.250.gff4ea60

>

Patch

diff --git a/platform/linux-generic/odp_pool.c b/platform/linux-generic/odp_pool.c
index 4be3827..f63efb6 100644
--- a/platform/linux-generic/odp_pool.c
+++ b/platform/linux-generic/odp_pool.c
@@ -285,7 +285,7 @@  static odp_pool_t pool_create(const char *name, odp_pool_param_t *params,
 	char uarea_name[ODP_POOL_NAME_LEN + sizeof(postfix)];
 
 	if (params == NULL) {
-		ODP_ERR("No params");
+		ODP_ERR("No params\n");
 		return ODP_POOL_INVALID;
 	}
 
@@ -300,7 +300,7 @@  static odp_pool_t pool_create(const char *name, odp_pool_param_t *params,
 	/* Validate requested buffer alignment */
 	if (align > ODP_CONFIG_BUFFER_ALIGN_MAX ||
 	    align != ODP_ALIGN_ROUNDDOWN_POWER_2(align, align)) {
-		ODP_ERR("Bad align requirement");
+		ODP_ERR("Bad align requirement\n");
 		return ODP_POOL_INVALID;
 	}
 
@@ -332,7 +332,7 @@  static odp_pool_t pool_create(const char *name, odp_pool_param_t *params,
 		break;
 
 	default:
-		ODP_ERR("Bad pool type");
+		ODP_ERR("Bad pool type\n");
 		return ODP_POOL_INVALID;
 	}
 
@@ -342,7 +342,7 @@  static odp_pool_t pool_create(const char *name, odp_pool_param_t *params,
 	pool = reserve_pool();
 
 	if (pool == NULL) {
-		ODP_ERR("No more free pools");
+		ODP_ERR("No more free pools\n");
 		return ODP_POOL_INVALID;
 	}
 
@@ -390,7 +390,7 @@  static odp_pool_t pool_create(const char *name, odp_pool_param_t *params,
 	pool->shm = shm;
 
 	if (shm == ODP_SHM_INVALID) {
-		ODP_ERR("Shm reserve failed");
+		ODP_ERR("Shm reserve failed\n");
 		goto error;
 	}
 
@@ -404,7 +404,7 @@  static odp_pool_t pool_create(const char *name, odp_pool_param_t *params,
 		pool->uarea_shm = shm;
 
 		if (shm == ODP_SHM_INVALID) {
-			ODP_ERR("Shm reserve failed (uarea)");
+			ODP_ERR("Shm reserve failed (uarea)\n");
 			goto error;
 		}