enable shared library for non-abi compat mode

Message ID 1480689044-14837-1-git-send-email-maxim.uvarov@linaro.org
State New
Headers show

Commit Message

Maxim Uvarov Dec. 2, 2016, 2:30 p.m.
Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>

---
 configure.ac | 1 -
 1 file changed, 1 deletion(-)

-- 
2.7.1.250.gff4ea60

Comments

Anders Roxell Dec. 2, 2016, 3:28 p.m. | #1
On 2 December 2016 at 15:30, Maxim Uvarov <maxim.uvarov@linaro.org> wrote:
> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>

> ---

>  configure.ac | 1 -

>  1 file changed, 1 deletion(-)

>

> diff --git a/configure.ac b/configure.ac

> index 3e89b0a..57edd33 100644

> --- a/configure.ac

> +++ b/configure.ac

> @@ -253,7 +253,6 @@ AC_ARG_ENABLE([abi-compat],

>      [if test "x$enableval" = "xno"; then

>         ODP_ABI_COMPAT=0

>         abi_compat=no

> -       enable_shared=no


If we replace the the shared lib (--abi-compat) with the shared lib
built without abi-comapt, we can't tell that they are incompatible.
The SO number may be forced to be changed for the abi-compat version.
However, we have not changed the SO version for the non-abi-compat.

Inline for a shared library isn't bad if the inline code for all
platforms on the same architecture is the same. If it is not the same
it should be a static library.

Cheers,
Anders
Savolainen, Petri (Nokia - FI/Espoo) Dec. 5, 2016, 7:43 a.m. | #2
> -----Original Message-----

> From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org] On Behalf Of Maxim

> Uvarov

> Sent: Friday, December 02, 2016 4:31 PM

> To: lng-odp@lists.linaro.org

> Subject: [lng-odp] [PATCH] enable shared library for non-abi compat mode

> 

> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>

> ---

>  configure.ac | 1 -

>  1 file changed, 1 deletion(-)

> 

> diff --git a/configure.ac b/configure.ac

> index 3e89b0a..57edd33 100644

> --- a/configure.ac

> +++ b/configure.ac

> @@ -253,7 +253,6 @@ AC_ARG_ENABLE([abi-compat],

>      [if test "x$enableval" = "xno"; then

>  	ODP_ABI_COMPAT=0

>  	abi_compat=no

> -	enable_shared=no

>      fi])

>  AC_SUBST(ODP_ABI_COMPAT)



>     @@ -336,6 +334,7 @@ AC_MSG_RESULT([

>             static libraries:       ${enable_static}

>             shared libraries:       ${enable_shared}

>             ABI compatible:         ${abi_compat}

>     +       ODP_ABI_COMPAT:         ${ODP_ABI_COMPAT}


Revert also this extra print of ABI compat. One status print is enough.

After these reverts, only --enable-abi-compat is changed to --disable-abi-compat (in ./configure --help). Autotools define both (enable/disable) automatically, so --disable-abi-compat was always there (the one I was using anyway).

-Petri
Anders Roxell Dec. 5, 2016, 8:02 a.m. | #3
On 5 December 2016 at 08:43, Savolainen, Petri (Nokia - FI/Espoo)
<petri.savolainen@nokia-bell-labs.com> wrote:
>> -----Original Message-----

>> From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org] On Behalf Of Maxim

>> Uvarov

>> Sent: Friday, December 02, 2016 4:31 PM

>> To: lng-odp@lists.linaro.org

>> Subject: [lng-odp] [PATCH] enable shared library for non-abi compat mode

>>

>> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>

>> ---

>>  configure.ac | 1 -

>>  1 file changed, 1 deletion(-)

>>

>> diff --git a/configure.ac b/configure.ac

>> index 3e89b0a..57edd33 100644

>> --- a/configure.ac

>> +++ b/configure.ac

>> @@ -253,7 +253,6 @@ AC_ARG_ENABLE([abi-compat],

>>      [if test "x$enableval" = "xno"; then

>>       ODP_ABI_COMPAT=0

>>       abi_compat=no

>> -     enable_shared=no

>>      fi])

>>  AC_SUBST(ODP_ABI_COMPAT)

>

>

>>     @@ -336,6 +334,7 @@ AC_MSG_RESULT([

>>             static libraries:       ${enable_static}

>>             shared libraries:       ${enable_shared}

>>             ABI compatible:         ${abi_compat}

>>     +       ODP_ABI_COMPAT:         ${ODP_ABI_COMPAT}

>

> Revert also this extra print of ABI compat. One status print is enough.


agree.

>

> After these reverts, only --enable-abi-compat is changed to --disable-abi-compat (in ./configure --help). Autotools define both (enable/disable) automatically, so --disable-abi-compat was always there


Right, thats true.

> (the one I was using anyway).


OK.

Anders

>

> -Petri

>

Patch

diff --git a/configure.ac b/configure.ac
index 3e89b0a..57edd33 100644
--- a/configure.ac
+++ b/configure.ac
@@ -253,7 +253,6 @@  AC_ARG_ENABLE([abi-compat],
     [if test "x$enableval" = "xno"; then
 	ODP_ABI_COMPAT=0
 	abi_compat=no
-	enable_shared=no
     fi])
 AC_SUBST(ODP_ABI_COMPAT)