diff mbox

[oe,meta-gnome,6/7] gthumb: Add missing dependency on gnome-common-native

Message ID 20161206023625.12901-4-raj.khem@gmail.com
State Accepted
Commit b0493d4ccf69dbf615461b3f4346ae0439b1453c
Headers show

Commit Message

Khem Raj Dec. 6, 2016, 2:36 a.m. UTC
| ../gthumb-2.12.4/configure: line 17557: GNOME_MAINTAINER_MODE_DEFINES: command not found
| ../gthumb-2.12.4/configure: line 17558: syntax error near unexpected token `maximum'
| ../gthumb-2.12.4/configure: line 17558: `GNOME_COMPILE_WARNINGS(maximum)'

Signed-off-by: Khem Raj <raj.khem@gmail.com>

---
 meta-gnome/recipes-gnome/gthumb/gthumb_2.12.4.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.10.2

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Comments

Andreas Müller Dec. 6, 2016, 8:56 a.m. UTC | #1
On Tue, Dec 6, 2016 at 3:36 AM, Khem Raj <raj.khem@gmail.com> wrote:
> | ../gthumb-2.12.4/configure: line 17557: GNOME_MAINTAINER_MODE_DEFINES: command not found

> | ../gthumb-2.12.4/configure: line 17558: syntax error near unexpected token `maximum'

> | ../gthumb-2.12.4/configure: line 17558: `GNOME_COMPILE_WARNINGS(maximum)'

>

> Signed-off-by: Khem Raj <raj.khem@gmail.com>

> ---

>  meta-gnome/recipes-gnome/gthumb/gthumb_2.12.4.bb | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

>

> diff --git a/meta-gnome/recipes-gnome/gthumb/gthumb_2.12.4.bb b/meta-gnome/recipes-gnome/gthumb/gthumb_2.12.4.bb

> index 5eee7f0..13c027c 100644

> --- a/meta-gnome/recipes-gnome/gthumb/gthumb_2.12.4.bb

> +++ b/meta-gnome/recipes-gnome/gthumb/gthumb_2.12.4.bb

> @@ -2,7 +2,7 @@ SUMMARY = "gThumb is an image viewer and browser for the GNOME Desktop"

>  SECTION = "x11/gnome"

>  LICENSE = "GPLv2"

>  LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552"

> -DEPENDS = "glib-2.0 gtk+ libxml2 gnome-doc-utils libunique gconf libpng gstreamer jpeg tiff gst-plugins-base intltool-native"

> +DEPENDS = "gnome-common-native glib-2.0 gtk+ libxml2 gnome-doc-utils libunique gconf libpng gstreamer jpeg tiff gst-plugins-base intltool-native"

>

>  PR = "r4"

>

> --

> 2.10.2

>

* Are there patches missing in this series (1/2 2/2)?
* What about gnome-menus3?

Andreas
-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Khem Raj Dec. 7, 2016, 7:40 p.m. UTC | #2
On Tue, Dec 6, 2016 at 12:56 AM, Andreas Müller
<schnitzeltony@googlemail.com> wrote:
> On Tue, Dec 6, 2016 at 3:36 AM, Khem Raj <raj.khem@gmail.com> wrote:
>> | ../gthumb-2.12.4/configure: line 17557: GNOME_MAINTAINER_MODE_DEFINES: command not found
>> | ../gthumb-2.12.4/configure: line 17558: syntax error near unexpected token `maximum'
>> | ../gthumb-2.12.4/configure: line 17558: `GNOME_COMPILE_WARNINGS(maximum)'
>>
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>>  meta-gnome/recipes-gnome/gthumb/gthumb_2.12.4.bb | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta-gnome/recipes-gnome/gthumb/gthumb_2.12.4.bb b/meta-gnome/recipes-gnome/gthumb/gthumb_2.12.4.bb
>> index 5eee7f0..13c027c 100644
>> --- a/meta-gnome/recipes-gnome/gthumb/gthumb_2.12.4.bb
>> +++ b/meta-gnome/recipes-gnome/gthumb/gthumb_2.12.4.bb
>> @@ -2,7 +2,7 @@ SUMMARY = "gThumb is an image viewer and browser for the GNOME Desktop"
>>  SECTION = "x11/gnome"
>>  LICENSE = "GPLv2"
>>  LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552"
>> -DEPENDS = "glib-2.0 gtk+ libxml2 gnome-doc-utils libunique gconf libpng gstreamer jpeg tiff gst-plugins-base intltool-native"
>> +DEPENDS = "gnome-common-native glib-2.0 gtk+ libxml2 gnome-doc-utils libunique gconf libpng gstreamer jpeg tiff gst-plugins-base intltool-native"
>>
>>  PR = "r4"
>>
>> --
>> 2.10.2
>>
> * Are there patches missing in this series (1/2 2/2)?

No, it was missed out from prior series.

> * What about gnome-menus3?

havent seen that fail. but probably needs similar fix.

>
> Andreas
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Ross Burton Dec. 8, 2016, 12:48 p.m. UTC | #3
On 7 December 2016 at 19:40, Khem Raj <raj.khem@gmail.com> wrote:

> havent seen that fail. but probably needs similar fix.

>


Sorry about these - I thought I caught them all when I sent the patches.

Ross
-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
diff mbox

Patch

diff --git a/meta-gnome/recipes-gnome/gthumb/gthumb_2.12.4.bb b/meta-gnome/recipes-gnome/gthumb/gthumb_2.12.4.bb
index 5eee7f0..13c027c 100644
--- a/meta-gnome/recipes-gnome/gthumb/gthumb_2.12.4.bb
+++ b/meta-gnome/recipes-gnome/gthumb/gthumb_2.12.4.bb
@@ -2,7 +2,7 @@  SUMMARY = "gThumb is an image viewer and browser for the GNOME Desktop"
 SECTION = "x11/gnome"
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552"
-DEPENDS = "glib-2.0 gtk+ libxml2 gnome-doc-utils libunique gconf libpng gstreamer jpeg tiff gst-plugins-base intltool-native"
+DEPENDS = "gnome-common-native glib-2.0 gtk+ libxml2 gnome-doc-utils libunique gconf libpng gstreamer jpeg tiff gst-plugins-base intltool-native"
 
 PR = "r4"