| Message ID | 20250219140239.1378758-21-m.wilczynski@samsung.com |
|---|---|
| State | New |
| Headers | show |
| Series | Enable drm/imagination BXM-4-64 Support for LicheePi 4A | expand |
On Wed, Feb 19, 2025 at 03:02:38PM +0100, Michal Wilczynski wrote: > T-HEAD TH1520 SoC requires to put the GPU out of the reset state as part > of the power-up sequence. > > Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com> > --- > arch/riscv/boot/dts/thead/th1520.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/thead/th1520.dtsi > index 474f31576a1b..6b34aab4b455 100644 > --- a/arch/riscv/boot/dts/thead/th1520.dtsi > +++ b/arch/riscv/boot/dts/thead/th1520.dtsi > @@ -7,6 +7,7 @@ > #include <dt-bindings/interrupt-controller/irq.h> > #include <dt-bindings/clock/thead,th1520-clk-ap.h> > #include <dt-bindings/power/thead,th1520-power.h> > +#include <dt-bindings/reset/thead,th1520-reset.h> Are you okay if I omit this hunk? My thead-dt-for-next branch is based on 6.15-rc1 but thead,th1520-reset.h only exists in next until the merge window. > > / { > compatible = "thead,th1520"; > @@ -497,6 +498,12 @@ clk: clock-controller@ffef010000 { > #clock-cells = <1>; > }; > > + rst: reset-controller@ffef528000 { > + compatible = "thead,th1520-reset"; > + reg = <0xff 0xef528000 0x0 0x4f>; > + #reset-cells = <1>; > + }; > + > clk_vo: clock-controller@ffef528050 { > compatible = "thead,th1520-clk-vo"; > reg = <0xff 0xef528050 0x0 0xfb0>; > -- > 2.34.1 > With the above caveat: Reviewed-by: Drew Fustini <drew@pdp7.com> -Drew
On 4/19/25 21:09, Drew Fustini wrote: > On Wed, Feb 19, 2025 at 03:02:38PM +0100, Michal Wilczynski wrote: >> T-HEAD TH1520 SoC requires to put the GPU out of the reset state as part >> of the power-up sequence. >> >> Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com> >> --- >> arch/riscv/boot/dts/thead/th1520.dtsi | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/thead/th1520.dtsi >> index 474f31576a1b..6b34aab4b455 100644 >> --- a/arch/riscv/boot/dts/thead/th1520.dtsi >> +++ b/arch/riscv/boot/dts/thead/th1520.dtsi >> @@ -7,6 +7,7 @@ >> #include <dt-bindings/interrupt-controller/irq.h> >> #include <dt-bindings/clock/thead,th1520-clk-ap.h> >> #include <dt-bindings/power/thead,th1520-power.h> >> +#include <dt-bindings/reset/thead,th1520-reset.h> > > Are you okay if I omit this hunk? My thead-dt-for-next branch is based > on 6.15-rc1 but thead,th1520-reset.h only exists in next until the merge > window. Yeah, I'm not exactly sure how to coordinate such stuff, obviosuly it would be best if this chunk would make it to the 6.16, but if you think it would be problematic then omit it, no problem. I will then update this patch series v3 [1] to gracefully handle lack of reset, as the 6.16 will not contain the required reset line for sure. [1] - https://lore.kernel.org/all/20250414-apr_14_for_sending-v2-2-70c5af2af96c@samsung.com/ > >> >> / { >> compatible = "thead,th1520"; >> @@ -497,6 +498,12 @@ clk: clock-controller@ffef010000 { >> #clock-cells = <1>; >> }; >> >> + rst: reset-controller@ffef528000 { >> + compatible = "thead,th1520-reset"; >> + reg = <0xff 0xef528000 0x0 0x4f>; >> + #reset-cells = <1>; >> + }; >> + >> clk_vo: clock-controller@ffef528050 { >> compatible = "thead,th1520-clk-vo"; >> reg = <0xff 0xef528050 0x0 0xfb0>; >> -- >> 2.34.1 >> > > With the above caveat: > > Reviewed-by: Drew Fustini <drew@pdp7.com> > > > -Drew > Best regards,
On Tue, Apr 22, 2025 at 09:47:34AM +0200, Michal Wilczynski wrote: > > > On 4/19/25 21:09, Drew Fustini wrote: > > On Wed, Feb 19, 2025 at 03:02:38PM +0100, Michal Wilczynski wrote: > >> T-HEAD TH1520 SoC requires to put the GPU out of the reset state as part > >> of the power-up sequence. > >> > >> Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com> > >> --- > >> arch/riscv/boot/dts/thead/th1520.dtsi | 7 +++++++ > >> 1 file changed, 7 insertions(+) > >> > >> diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/thead/th1520.dtsi > >> index 474f31576a1b..6b34aab4b455 100644 > >> --- a/arch/riscv/boot/dts/thead/th1520.dtsi > >> +++ b/arch/riscv/boot/dts/thead/th1520.dtsi > >> @@ -7,6 +7,7 @@ > >> #include <dt-bindings/interrupt-controller/irq.h> > >> #include <dt-bindings/clock/thead,th1520-clk-ap.h> > >> #include <dt-bindings/power/thead,th1520-power.h> > >> +#include <dt-bindings/reset/thead,th1520-reset.h> > > > > Are you okay if I omit this hunk? My thead-dt-for-next branch is based > > on 6.15-rc1 but thead,th1520-reset.h only exists in next until the merge > > window. > > Yeah, I'm not exactly sure how to coordinate such stuff, obviosuly it > would be best if this chunk would make it to the 6.16, but if you think > it would be problematic then omit it, no problem. > > I will then update this patch series v3 [1] to gracefully handle lack of > reset, as the 6.16 will not contain the required reset line for sure. > > [1] - https://lore.kernel.org/all/20250414-apr_14_for_sending-v2-2-70c5af2af96c@samsung.com/ I've applied this patch to my thead-dt-for-next tree: https://github.com/pdp7/linux/commit/1b136de08b5feca37ebdb6d28db3c9c6285aba5a We should be able to test with the driver in next once a new next is published (which I assume will be on Monday in Austrlia). Thanks, Drew
diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/thead/th1520.dtsi index 474f31576a1b..6b34aab4b455 100644 --- a/arch/riscv/boot/dts/thead/th1520.dtsi +++ b/arch/riscv/boot/dts/thead/th1520.dtsi @@ -7,6 +7,7 @@ #include <dt-bindings/interrupt-controller/irq.h> #include <dt-bindings/clock/thead,th1520-clk-ap.h> #include <dt-bindings/power/thead,th1520-power.h> +#include <dt-bindings/reset/thead,th1520-reset.h> / { compatible = "thead,th1520"; @@ -497,6 +498,12 @@ clk: clock-controller@ffef010000 { #clock-cells = <1>; }; + rst: reset-controller@ffef528000 { + compatible = "thead,th1520-reset"; + reg = <0xff 0xef528000 0x0 0x4f>; + #reset-cells = <1>; + }; + clk_vo: clock-controller@ffef528050 { compatible = "thead,th1520-clk-vo"; reg = <0xff 0xef528050 0x0 0xfb0>;
T-HEAD TH1520 SoC requires to put the GPU out of the reset state as part of the power-up sequence. Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com> --- arch/riscv/boot/dts/thead/th1520.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)