diff mbox

[Linaro-uefi,linaro-uefi,v6,30/37] Hisilicon/D03: switch to NullMemoryTest

Message ID 1481021828-59826-31-git-send-email-heyi.guo@linaro.org
State Superseded
Headers show

Commit Message

gary guo Dec. 6, 2016, 10:57 a.m. UTC
The NullMemoryTestDxe and GenericMemoryTestDxe both have one function,
which is switching the untested memory of type EfiGcdMemoryTypeReserved to
EfiGcdMemoryTypeSystemMemory.

The above 4GB memory is not reported as system memory in UEFI memory map
before BDS on hisilicon platforms.
After running memory test protocol, whether it is from
NullMemoryTestDxe or GenericMemoryTestDxe, memory space above 4GB will be
switched to EfiGcdMemoryTypeSystemMemory and reported in UEFI memory map.

There are 8 DIMM slots at D03 platform,
it takes about 2 minutes to do memory test when
inserting full memory(16G*8), so we switch to NullMemoryTest
to promote boot time.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
---
 Platforms/Hisilicon/D03/D03.dsc | 2 +-
 Platforms/Hisilicon/D03/D03.fdf | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Leif Lindholm Dec. 6, 2016, 11:52 a.m. UTC | #1
On Tue, Dec 06, 2016 at 06:57:01PM +0800, Heyi Guo wrote:
> The NullMemoryTestDxe and GenericMemoryTestDxe both have one function,
> which is switching the untested memory of type EfiGcdMemoryTypeReserved to
> EfiGcdMemoryTypeSystemMemory.
> 
> The above 4GB memory is not reported as system memory in UEFI memory map
> before BDS on hisilicon platforms.
> After running memory test protocol, whether it is from
> NullMemoryTestDxe or GenericMemoryTestDxe, memory space above 4GB will be
> switched to EfiGcdMemoryTypeSystemMemory and reported in UEFI memory map.
> 
> There are 8 DIMM slots at D03 platform,
> it takes about 2 minutes to do memory test when
> inserting full memory(16G*8), so we switch to NullMemoryTest
> to promote boot time.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Heyi Guo <heyi.guo@linaro.org>

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

> ---
>  Platforms/Hisilicon/D03/D03.dsc | 2 +-
>  Platforms/Hisilicon/D03/D03.fdf | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Platforms/Hisilicon/D03/D03.dsc b/Platforms/Hisilicon/D03/D03.dsc
> index 850b16b..40aec5c 100644
> --- a/Platforms/Hisilicon/D03/D03.dsc
> +++ b/Platforms/Hisilicon/D03/D03.dsc
> @@ -506,7 +506,7 @@
>    #
>    # Memory test
>    #
> -  MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/GenericMemoryTestDxe.inf
> +  MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe.inf
>  
>    MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
>    MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
> diff --git a/Platforms/Hisilicon/D03/D03.fdf b/Platforms/Hisilicon/D03/D03.fdf
> index d101abb..3302ec9 100644
> --- a/Platforms/Hisilicon/D03/D03.fdf
> +++ b/Platforms/Hisilicon/D03/D03.fdf
> @@ -290,7 +290,7 @@ READ_LOCK_STATUS   = TRUE
>    #
>    INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
>  
> -  INF MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/GenericMemoryTestDxe.inf
> +  INF MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe.inf
>    INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
>    INF MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
>    INF IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf
> -- 
> 1.9.1
>
diff mbox

Patch

diff --git a/Platforms/Hisilicon/D03/D03.dsc b/Platforms/Hisilicon/D03/D03.dsc
index 850b16b..40aec5c 100644
--- a/Platforms/Hisilicon/D03/D03.dsc
+++ b/Platforms/Hisilicon/D03/D03.dsc
@@ -506,7 +506,7 @@ 
   #
   # Memory test
   #
-  MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/GenericMemoryTestDxe.inf
+  MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe.inf
 
   MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
   MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
diff --git a/Platforms/Hisilicon/D03/D03.fdf b/Platforms/Hisilicon/D03/D03.fdf
index d101abb..3302ec9 100644
--- a/Platforms/Hisilicon/D03/D03.fdf
+++ b/Platforms/Hisilicon/D03/D03.fdf
@@ -290,7 +290,7 @@  READ_LOCK_STATUS   = TRUE
   #
   INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
 
-  INF MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/GenericMemoryTestDxe.inf
+  INF MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe.inf
   INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
   INF MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
   INF IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf