diff mbox

[Linaro-uefi,linaro-uefi,v6,31/37] Hisilicon: fix PXE boot fail issue

Message ID 1481021828-59826-32-git-send-email-heyi.guo@linaro.org
State Superseded
Headers show

Commit Message

gary guo Dec. 6, 2016, 10:57 a.m. UTC 
The images not from FV are treated as 3rd party images,
and will be dispatched after EndOfDxe event due to
EDK2 commit 8be37a5cee, so we signal a EndOfDxe event
or the bootloader application will not be executed.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
 Chips/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.c      | 2 ++
 Chips/Hisilicon/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf | 1 +
 2 files changed, 3 insertions(+)

Comments

Leif Lindholm Dec. 6, 2016, 11:53 a.m. UTC | #1 
On Tue, Dec 06, 2016 at 06:57:02PM +0800, Heyi Guo wrote:
> The images not from FV are treated as 3rd party images,
> and will be dispatched after EndOfDxe event due to
> EDK2 commit 8be37a5cee, so we signal a EndOfDxe event
> or the bootloader application will not be executed.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

> ---
>  Chips/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.c      | 2 ++
>  Chips/Hisilicon/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf | 1 +
>  2 files changed, 3 insertions(+)
> 
> diff --git a/Chips/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.c b/Chips/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.c
> index 43a4385..efefeb6 100644
> --- a/Chips/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.c
> +++ b/Chips/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.c
> @@ -157,6 +157,8 @@ PlatformBdsInit (
>    VOID
>    )
>  {
> +  //Signal EndofDxe Event
> +  EfiEventGroupSignal(&gEfiEndOfDxeEventGroupGuid);
>  }
>  
>  
> diff --git a/Chips/Hisilicon/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf b/Chips/Hisilicon/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf
> index 236e314..baceb57 100644
> --- a/Chips/Hisilicon/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf
> +++ b/Chips/Hisilicon/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf
> @@ -67,6 +67,7 @@
>    gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut
>  
>  [Guids]
> +  gEfiEndOfDxeEventGroupGuid
>    gEfiFileInfoGuid
>    gEfiFileSystemInfoGuid
>    gEfiFileSystemVolumeLabelInfoIdGuid
> -- 
> 1.9.1
>
diff mbox

Patch

diff --git a/Chips/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.c b/Chips/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.c
index 43a4385..efefeb6 100644
--- a/Chips/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.c
+++ b/Chips/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.c
@@ -157,6 +157,8 @@  PlatformBdsInit (
   VOID
   )
 {
+  //Signal EndofDxe Event
+  EfiEventGroupSignal(&gEfiEndOfDxeEventGroupGuid);
 }
 
 
diff --git a/Chips/Hisilicon/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf b/Chips/Hisilicon/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf
index 236e314..baceb57 100644
--- a/Chips/Hisilicon/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf
+++ b/Chips/Hisilicon/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf
@@ -67,6 +67,7 @@ 
   gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut
 
 [Guids]
+  gEfiEndOfDxeEventGroupGuid
   gEfiFileInfoGuid
   gEfiFileSystemInfoGuid
   gEfiFileSystemVolumeLabelInfoIdGuid