diff mbox series

[v6,2/9] regulator: dt-bindings: Add TI TPS65214 PMIC bindings

Message ID 20250305210351.249811-3-s-ramamoorthy@ti.com
State New
Headers show
Series Add TI TPS65214 & TPS65215 MFD & Regulator Support | expand

Commit Message

Shree Ramamoorthy March 5, 2025, 9:03 p.m. UTC 
- TPS65214 is a Power Management IC with 3 Buck regulators and 2 LDOs.
- TPS65214 has 2 LDOS and 1 GPO, whereas TPS65219 has 4 LDOs and 2 GPOs.
- TPS65214's LDO1 maps to TPS65219's LDO3.
- A key difference between TPS65215 & TPS65214 are the LDO current and
  voltage output ranges and the configurable options available.
- The remaining features for both devices are the same.

Signed-off-by: Shree Ramamoorthy <s-ramamoorthy@ti.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../devicetree/bindings/regulator/ti,tps65219.yaml     | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

Comments

Krzysztof Kozlowski March 6, 2025, 7:25 a.m. UTC | #1 
On 05/03/2025 22:03, Shree Ramamoorthy wrote:
>  
> @@ -102,7 +106,9 @@ allOf:
>        properties:
>          compatible:
>            contains:
> -            const: ti,tps65215
> +            enum:
> +              - ti,tps65214
> +              - ti,tps65215

I do not see improvements and you did not respond to my comment.

Best regards,
Krzysztof
Shree Ramamoorthy March 6, 2025, 10:58 p.m. UTC | #2 
Hi,

On 3/6/2025 1:25 AM, Krzysztof Kozlowski wrote:
> On 05/03/2025 22:03, Shree Ramamoorthy wrote:
>>  
>> @@ -102,7 +106,9 @@ allOf:
>>        properties:
>>          compatible:
>>            contains:
>> -            const: ti,tps65215
>> +            enum:
>> +              - ti,tps65214
>> +              - ti,tps65215
> I do not see improvements and you did not respond to my comment.
>
> Best regards,
> Krzysztof

Sorry for missing the enum fix, I thought I had included that and should've double checked.
Thank you again for reviewing these patches!
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml b/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml
index b0d47415bf83..7c64e588a8b5 100644
--- a/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml
+++ b/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml
@@ -4,7 +4,7 @@ 
 $id: http://devicetree.org/schemas/regulator/ti,tps65219.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
-title: TI TPS65215/TPS65219 Power Management Integrated Circuits
+title: TI TPS65214/TPS65215/TPS65219 Power Management Integrated Circuit
 
 maintainers:
   - Jerome Neanne <jerome.neanne@baylibre.com>
@@ -18,9 +18,13 @@  description: |
   TI TPS65215 is a derivative of TPS65219 with 3 Buck regulators, 2 Low
   Drop-out Regulators (LDOs), 1 GPIO, 1 GPO, and power-button.
 
+  TI TPS65214 is a derivative of TPS65219 with 3 Buck regulators, 2 Low
+  Drop-out Regulators (LDOs), 1 GPIO, 1 GPO, and power-button.
+
 properties:
   compatible:
     enum:
+      - ti,tps65214
       - ti,tps65215
       - ti,tps65219
 
@@ -102,7 +106,9 @@  allOf:
       properties:
         compatible:
           contains:
-            const: ti,tps65215
+            enum:
+              - ti,tps65214
+              - ti,tps65215
     then:
       properties:
         regulators: