From patchwork Wed Dec 7 12:33:45 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 87081 Delivered-To: patch@linaro.org Received: by 10.140.20.101 with SMTP id 92csp290994qgi; Wed, 7 Dec 2016 04:35:59 -0800 (PST) X-Received: by 10.107.174.142 with SMTP id n14mr57863310ioo.205.1481114159617; Wed, 07 Dec 2016 04:35:59 -0800 (PST) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id i31si17261867ioo.48.2016.12.07.04.35.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Dec 2016 04:35:59 -0800 (PST) Received-SPF: neutral (google.com: 192.237.175.120 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) client-ip=192.237.175.120; Authentication-Results: mx.google.com; spf=neutral (google.com: 192.237.175.120 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) smtp.mailfrom=xen-devel-bounces@lists.xen.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cEbQF-00067w-SK; Wed, 07 Dec 2016 12:34:07 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cEbQF-00067L-4C for xen-devel@lists.xen.org; Wed, 07 Dec 2016 12:34:07 +0000 Received: from [85.158.137.68] by server-12.bemta-3.messagelabs.com id 3F/11-28947-EB108485; Wed, 07 Dec 2016 12:34:06 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrKLMWRWlGSWpSXmKPExsVysyfVTXcvo0e Ewccl5hZLPi5mcWD0OLr7N1MAYxRrZl5SfkUCa8buf82sBVslKzqurWNpYHwv3MXIxSEksJlR YuaDL2wQzmlGiXsT25i7GDk52AQ0Je58/sQEYosISEtc+3yZEcRmFnCQePPxHguILSyQKnF6T SMbiM0ioCrxuu0tkM3BwSvgIvFquyBIWEJATuLkscmsIDangKvEra9/wVqFgEq+Ni1jmcDIvY CRYRWjenFqUVlqka6FXlJRZnpGSW5iZo6uoYGxXm5qcXFiempOYlKxXnJ+7iZGoHcZgGAH44V 250OMkhxMSqK8uya4RwjxJeWnVGYkFmfEF5XmpBYfYpTh4FCS4OVh8IgQEixKTU+tSMvMAYYZ TFqCg0dJhHfff6BW3uKCxNzizHSI1ClGRSlxXnGQPgGQREZpHlwbLLQvMcpKCfMyAh0ixFOQW pSbWYIq/4pRnINRSZiXC2QKT2ZeCdz0V0CLmYAWz7sBtrgkESEl1cBouY1x6ov71zz/LWFVr2 Mrva2fLzZBPnhGyXWVkviJrFkvTar+Oqk89fDx31c7RS8uUi876s3piK65n7a8UJoZFjU1S/J LvfRbqQVFOiwps6uE505jrUyf3OA1bXXLFpWCuS33BJNXRq8Nmh+0ac00vdSlOzb8EqksvHKR +c9ORu/W6oOXP21VYinOSDTUYi4qTgQApTN3WWgCAAA= X-Env-Sender: julien.grall@arm.com X-Msg-Ref: server-10.tower-31.messagelabs.com!1481114045!74235965!1 X-Originating-IP: [217.140.101.70] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.0.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 49934 invoked from network); 7 Dec 2016 12:34:05 -0000 Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by server-10.tower-31.messagelabs.com with SMTP; 7 Dec 2016 12:34:05 -0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 27DC1154D; Wed, 7 Dec 2016 04:34:05 -0800 (PST) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.218.32]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 89E343F477; Wed, 7 Dec 2016 04:34:04 -0800 (PST) From: Julien Grall To: xen-devel@lists.xen.org Date: Wed, 7 Dec 2016 12:33:45 +0000 Message-Id: <1481114033-11024-6-git-send-email-julien.grall@arm.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1481114033-11024-1-git-send-email-julien.grall@arm.com> References: <1481114033-11024-1-git-send-email-julien.grall@arm.com> Cc: Julien Grall , sstabellini@kernel.org Subject: [Xen-devel] [PATCH 05/13] xen/arm: vgic: Switch vgic_to_sgi return from int to bool and progate up to... X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" vgic_v{2,3}_to_sgi. vgic_*to_sgi functions can only return 2 values: 0 or 1. Use bool instead to make clear only two possible values exist. Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini --- xen/arch/arm/vgic-v2.c | 4 ++-- xen/arch/arm/vgic-v3.c | 2 +- xen/arch/arm/vgic.c | 8 ++++---- xen/include/asm-arm/vgic.h | 6 +++--- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/xen/arch/arm/vgic-v2.c b/xen/arch/arm/vgic-v2.c index c6d280e..3dbcfe8 100644 --- a/xen/arch/arm/vgic-v2.c +++ b/xen/arch/arm/vgic-v2.c @@ -374,7 +374,7 @@ read_reserved: return 1; } -static int vgic_v2_to_sgi(struct vcpu *v, register_t sgir) +static bool vgic_v2_to_sgi(struct vcpu *v, register_t sgir) { int virq; @@ -403,7 +403,7 @@ static int vgic_v2_to_sgi(struct vcpu *v, register_t sgir) printk(XENLOG_G_DEBUG "%pv: vGICD: unhandled GICD_SGIR write %"PRIregister" with wrong mode\n", v, sgir); - return 0; + return false; } return vgic_to_sgi(v, sgir, sgi_mode, virq, &target); diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c index ec038a3..17c3000 100644 --- a/xen/arch/arm/vgic-v3.c +++ b/xen/arch/arm/vgic-v3.c @@ -1269,7 +1269,7 @@ write_reserved: return 1; } -static int vgic_v3_to_sgi(struct vcpu *v, register_t sgir) +static bool vgic_v3_to_sgi(struct vcpu *v, register_t sgir) { int virq; int irqmode; diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c index 84735a9..3e1774d 100644 --- a/xen/arch/arm/vgic.c +++ b/xen/arch/arm/vgic.c @@ -393,8 +393,8 @@ void vgic_enable_irqs(struct vcpu *v, uint32_t r, int n) } } -int vgic_to_sgi(struct vcpu *v, register_t sgir, enum gic_sgi_mode irqmode, int virq, - const struct sgi_target *target) +bool vgic_to_sgi(struct vcpu *v, register_t sgir, enum gic_sgi_mode irqmode, + int virq, const struct sgi_target *target) { struct domain *d = v->domain; int vcpuid; @@ -440,10 +440,10 @@ int vgic_to_sgi(struct vcpu *v, register_t sgir, enum gic_sgi_mode irqmode, int gprintk(XENLOG_WARNING, "vGICD:unhandled GICD_SGIR write %"PRIregister" \ with wrong mode\n", sgir); - return 0; + return false; } - return 1; + return true; } struct pending_irq *irq_to_pending(struct vcpu *v, unsigned int irq) diff --git a/xen/include/asm-arm/vgic.h b/xen/include/asm-arm/vgic.h index 1f371c8..83843fa 100644 --- a/xen/include/asm-arm/vgic.h +++ b/xen/include/asm-arm/vgic.h @@ -309,9 +309,9 @@ int vgic_v3_init(struct domain *d, int *mmio_count); extern int domain_vgic_register(struct domain *d, int *mmio_count); extern int vcpu_vgic_free(struct vcpu *v); -extern int vgic_to_sgi(struct vcpu *v, register_t sgir, - enum gic_sgi_mode irqmode, int virq, - const struct sgi_target *target); +extern bool vgic_to_sgi(struct vcpu *v, register_t sgir, + enum gic_sgi_mode irqmode, int virq, + const struct sgi_target *target); extern void vgic_migrate_irq(struct vcpu *old, struct vcpu *new, unsigned int irq); /* Reserve a specific guest vIRQ */