From patchwork Thu Dec 8 09:07:45 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Lyon X-Patchwork-Id: 87216 Delivered-To: patch@linaro.org Received: by 10.182.112.6 with SMTP id im6csp765679obb; Thu, 8 Dec 2016 01:08:26 -0800 (PST) X-Received: by 10.84.217.149 with SMTP id p21mr128297008pli.121.1481188106058; Thu, 08 Dec 2016 01:08:26 -0800 (PST) Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id c19si6053868pgk.317.2016.12.08.01.08.25 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Dec 2016 01:08:26 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-return-443763-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org; spf=pass (google.com: domain of gcc-patches-return-443763-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=gcc-patches-return-443763-patch=linaro.org@gcc.gnu.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; q=dns; s=default; b=ZZaq4m5qWKNA88S uNdAXu3Me98gKxbBfRaBpLrfBTiL5IXkJIRwAwuFvp93ObZKdwGQlNDDqGtnZL/n eObdLVgwvBBeSLrtlEOLu7mLcYuDVRSn0gwUBJKVuhCG4DNdAKkFgnUJ1eLbB3A+ egefyafkWWWccYoklqQTNt4m6HNA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; s=default; bh=iw9V0wywKmoQVcxGQ/xny gxNhxY=; b=m+ovzxE7BEXZ17YlokwFlMZ42HsCg1HoskxjEBDvqpxGYKttLoZPI gAdr87rNQvtiRXGO30I0tcC+V8Z9vVk7THkyCeGMLOWdBcojo+SB2ch9reYl4qlZ dCGHm6pRZbsFBch1Fl0w9fRUJOP5d+z2S2mcE98SQTmPPqqR73zJyE= Received: (qmail 95241 invoked by alias); 8 Dec 2016 09:07:59 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 95197 invoked by uid 89); 8 Dec 2016 09:07:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=disclaimer, privacy, company X-HELO: mail-qk0-f182.google.com Received: from mail-qk0-f182.google.com (HELO mail-qk0-f182.google.com) (209.85.220.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 08 Dec 2016 09:07:48 +0000 Received: by mail-qk0-f182.google.com with SMTP id n21so443911521qka.3 for ; Thu, 08 Dec 2016 01:07:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=p9Zc8f3u83O5hnfEpON6cEMn1w9XawGFHSlp4Ux+UAg=; b=nAiX6fa7FmZZomQXd+MI4HuoA6wB1Y+16+fKBXLi8Z2pxBMspUZbTM/VootznU68oR gCH5JQLMuVLjsQxRGfPd2SJc+OAgkTADmG75XC8higYGdiKDbFYU6OrQxexAKbRUjKJd meqEx39fonOzgAzpQfjFE1jIvrR4U/hIysVUMrG0y+qfOrYWhXPzG8PzSLMCh6vgxo6E 4FxpgOucwAFpd5/K+T+LDzIo8/p4owfnDBJIsThyvlFjKVLoOQC5Riu/ISz63t7cdc+k MMRVDfKflsxtzJHRYaHoSoT0ZIVd76kHZuZz0uPvmS49q/SD38OfZrXr2yQaseI9ZygG Sa8g== X-Gm-Message-State: AKaTC03bpdEdujJdPQ/CxFsK2GzGQmM2fWp+c9y2hSu70h01VO0h0JwLdEI6nex7KFqrR5Zn8hQN2jau0uCy8JFy X-Received: by 10.55.103.133 with SMTP id b127mr62604145qkc.16.1481188066504; Thu, 08 Dec 2016 01:07:46 -0800 (PST) MIME-Version: 1.0 Received: by 10.140.101.144 with HTTP; Thu, 8 Dec 2016 01:07:45 -0800 (PST) In-Reply-To: References: <5845888A.7000007@foss.arm.com> From: Christophe Lyon Date: Thu, 8 Dec 2016 10:07:45 +0100 Message-ID: Subject: Re: [ARM][PATCH] Fix failing poly64 tests on ARM To: Tamar Christina Cc: Kyrill Tkachov , GCC Patches , "nickc@redhat.com" , Richard Earnshaw X-IsSubscribed: yes Sending again, after removing ARM's "company disclaimer or privacy notice"... On 8 December 2016 at 10:03, Christophe Lyon wrote: > Hi, > > On 6 December 2016 at 11:55, Tamar Christina wrote: >> Hi Christophe, >> >> Aarch64 seems to still pass. It seems the types are really unused after I moved the other tests to p64_p128. >> > > I checked the attached patch fixes the failing tests on ARM/AArch64 > (no advsimd-intrinsic test > fail after this patch is applied). > > OK for trunk? > > Thanks, > > Christophe > > >> Thanks, >> Tamar >> >> ________________________________________ >> From: Christophe Lyon >> Sent: Monday, December 5, 2016 6:33:43 PM >> To: Kyrill Tkachov >> Cc: Tamar Christina; GCC Patches; nickc@redhat.com; Richard Earnshaw >> Subject: Re: [ARM][PATCH] Fix failing poly64 tests on ARM >> >> Hi Tamar, >> >> >> On 5 December 2016 at 16:32, Kyrill Tkachov wrote: >>> >>> On 05/12/16 10:39, Tamar Christina wrote: >>>> >>>> Hi All, >>>> >>>> This patch fixes test failures on arm-none-eabi. >>>> Poly64 was being used by files that were not supposed >>>> to be testing poly64 types. >>>> >>>> I have added a new MACRO that must be defined in addition >>>> to having CRYPTO available before use of Poly64 types are >>>> allowed in the header arm-neon-ref.h. >>>> >>>> Ok for trunk? >>>> >>>> gcc/testsuite/ >>>> 2016-12-01 Tamar Christina >>>> >>>> * gcc.target/aarch64/advsimd-intrinsics/arm-neon-ref.h: Gate use >>>> of Poly64 on USE_CRYPTO_TYPES. >>>> * gcc.target/aarch64/advsimd-intrinsics/p64_p128.c: Define >>>> USE_CRYPTO_TYPES. >>>> * gcc.target/aarch64/advsimd-intrinsics/vreinterpret_p128.c: >>>> Likewise. >>>> * gcc.target/aarch64/advsimd-intrinsics/vreinterpret_p64.c: >>>> Likewise. >>> >>> >>> Ok, but please make sure the line length in the ChangeLog doesn't go over 80 >>> characters. >>> Kyrill >> >> Since 'expected_poly64x[12]' isn't used, there is no need to declare it, >> and the attached patch seems to work (tested only on arm-none-linux-gnueabihf >> --target-board=-mthumb/-march=armv8-a/-mfpu=crypto-neon-fp-armv8/-mfloat-abi=hard >> >> All the tests for poly64 use dedicated output buffers, at least for the moment. >> >> Does my patch break aarch64? >> >> Christophe gcc/testsuite/ChangeLog: 2016-12-08 Christophe Lyon * gcc.target/aarch64/advsimd-intrinsics/arm-neon-ref.h (CHECK_CRYPTO): Remove. (expected_poly64x1_t, expected_poly64x2_t): Remove diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/arm-neon-ref.h b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/arm-neon-ref.h index beaf6ac..4728639 100644 --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/arm-neon-ref.h +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/arm-neon-ref.h @@ -99,13 +99,6 @@ extern size_t strlen(const char *); fprintf(stderr, "CHECKED %s %s\n", STR(VECT_TYPE(T, W, N)), MSG); \ } -#if defined (__ARM_FEATURE_CRYPTO) -#define CHECK_CRYPTO(MSG,T,W,N,FMT,EXPECTED,COMMENT) \ - CHECK(MSG,T,W,N,FMT,EXPECTED,COMMENT) -#else -#define CHECK_CRYPTO(MSG,T,W,N,FMT,EXPECTED,COMMENT) -#endif - /* Floating-point variant. */ #define CHECK_FP(MSG,T,W,N,FMT,EXPECTED,COMMENT) \ { \ @@ -198,9 +191,6 @@ extern ARRAY(expected, uint, 32, 2); extern ARRAY(expected, uint, 64, 1); extern ARRAY(expected, poly, 8, 8); extern ARRAY(expected, poly, 16, 4); -#if defined (__ARM_FEATURE_CRYPTO) -extern ARRAY(expected, poly, 64, 1); -#endif extern ARRAY(expected, hfloat, 16, 4); extern ARRAY(expected, hfloat, 32, 2); extern ARRAY(expected, hfloat, 64, 1); @@ -214,9 +204,6 @@ extern ARRAY(expected, uint, 32, 4); extern ARRAY(expected, uint, 64, 2); extern ARRAY(expected, poly, 8, 16); extern ARRAY(expected, poly, 16, 8); -#if defined (__ARM_FEATURE_CRYPTO) -extern ARRAY(expected, poly, 64, 2); -#endif extern ARRAY(expected, hfloat, 16, 8); extern ARRAY(expected, hfloat, 32, 4); extern ARRAY(expected, hfloat, 64, 2); @@ -233,7 +220,6 @@ extern ARRAY(expected, hfloat, 64, 2); CHECK(test_name, uint, 64, 1, PRIx64, EXPECTED, comment); \ CHECK(test_name, poly, 8, 8, PRIx8, EXPECTED, comment); \ CHECK(test_name, poly, 16, 4, PRIx16, EXPECTED, comment); \ - CHECK_CRYPTO(test_name, poly, 64, 1, PRIx64, EXPECTED, comment); \ CHECK_FP(test_name, float, 32, 2, PRIx32, EXPECTED, comment); \ \ CHECK(test_name, int, 8, 16, PRIx8, EXPECTED, comment); \ @@ -246,7 +232,6 @@ extern ARRAY(expected, hfloat, 64, 2); CHECK(test_name, uint, 64, 2, PRIx64, EXPECTED, comment); \ CHECK(test_name, poly, 8, 16, PRIx8, EXPECTED, comment); \ CHECK(test_name, poly, 16, 8, PRIx16, EXPECTED, comment); \ - CHECK_CRYPTO(test_name, poly, 64, 2, PRIx64, EXPECTED, comment); \ CHECK_FP(test_name, float, 32, 4, PRIx32, EXPECTED, comment); \ } \