[1/2,v3] sched: fix find_idlest_group for fork

Message ID 1481216215-24651-2-git-send-email-vincent.guittot@linaro.org
State Accepted
Commit f519a3f1c6b7a990e5aed37a8f853c6ecfdee945
Headers show

Commit Message

Vincent Guittot Dec. 8, 2016, 4:56 p.m.
During fork, the utilization of a task is init once the rq has been
selected because the current utilization level of the rq is used to set
the utilization of the fork task. As the task's utilization is still
null at this step of the fork sequence, it doesn't make sense to look for
some spare capacity that can fit the task's utilization.
Furthermore, I can see perf regressions for the test "hackbench -P -g 1"
because the least loaded policy is always bypassed and tasks are not
spread during fork.

With this patch and the fix below, we are back to same performances as
for v4.8. The fix below is only a temporary one used for the test until a
smarter solution is found because we can't simply remove the test which is
useful for others benchmarks

@@ -5708,13 +5708,6 @@ static int select_idle_cpu(struct task_struct *p, struct sched_domain *sd, int t

 	avg_cost = this_sd->avg_scan_cost;

-	/*
-	 * Due to large variance we need a large fuzz factor; hackbench in
-	 * particularly is sensitive here.
-	 */
-	if ((avg_idle / 512) < avg_cost)
-		return -1;
-
 	time = local_clock();

 	for_each_cpu_wrap(cpu, sched_domain_span(sd), target, wrap) {

Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>

Acked-by: Morten Rasmussen <morten.rasmussen@arm.com>

---
 kernel/sched/fair.c | 6 ++++++
 1 file changed, 6 insertions(+)

-- 
2.7.4

Comments

Matt Fleming Dec. 9, 2016, 1:18 p.m. | #1
On Thu, 08 Dec, at 05:56:53PM, Vincent Guittot wrote:
> During fork, the utilization of a task is init once the rq has been

> selected because the current utilization level of the rq is used to set

> the utilization of the fork task. As the task's utilization is still

> null at this step of the fork sequence, it doesn't make sense to look for

> some spare capacity that can fit the task's utilization.

> Furthermore, I can see perf regressions for the test "hackbench -P -g 1"

> because the least loaded policy is always bypassed and tasks are not

> spread during fork.

> 

> With this patch and the fix below, we are back to same performances as

> for v4.8. The fix below is only a temporary one used for the test until a

> smarter solution is found because we can't simply remove the test which is

> useful for others benchmarks

> 

> @@ -5708,13 +5708,6 @@ static int select_idle_cpu(struct task_struct *p, struct sched_domain *sd, int t

> 

>  	avg_cost = this_sd->avg_scan_cost;

> 

> -	/*

> -	 * Due to large variance we need a large fuzz factor; hackbench in

> -	 * particularly is sensitive here.

> -	 */

> -	if ((avg_idle / 512) < avg_cost)

> -		return -1;

> -

>  	time = local_clock();

> 

>  	for_each_cpu_wrap(cpu, sched_domain_span(sd), target, wrap) {

> 

> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>

> Acked-by: Morten Rasmussen <morten.rasmussen@arm.com>

> ---

>  kernel/sched/fair.c | 6 ++++++

>  1 file changed, 6 insertions(+)


Tested-by: Matt Fleming <matt@codeblueprint.co.uk>

Reviewed-by: Matt Fleming <matt@codeblueprint.co.uk>

Patch

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 92cb50d..1da846b 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -5473,13 +5473,19 @@  find_idlest_group(struct sched_domain *sd, struct task_struct *p,
 	 * utilized systems if we require spare_capacity > task_util(p),
 	 * so we allow for some task stuffing by using
 	 * spare_capacity > task_util(p)/2.
+	 * spare capacity can't be used for fork because the utilization has
+	 * not been set yet as it need to get a rq to init the utilization
 	 */
+	if (sd_flag & SD_BALANCE_FORK)
+		goto skip_spare;
+
 	if (this_spare > task_util(p) / 2 &&
 	    imbalance*this_spare > 100*most_spare)
 		return NULL;
 	else if (most_spare > task_util(p) / 2)
 		return most_spare_sg;
 
+skip_spare:
 	if (!idlest || 100*this_load < imbalance*min_load)
 		return NULL;
 	return idlest;