| Message ID | 20250331072707.3988687-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v1,1/1] media: i2c: max9671x: Remove (explicitly) unused header | expand |
Hi, Thanks for your patch On Mon, 2025-03-31 at 10:27 +0300, Andy Shevchenko wrote: > The fwnode.h is not supposed to be used by the drivers as it > has the definitions for the core parts for different device > property provider implementations. Drop it. > > Note, that fwnode API for drivers is provided in property.h > which is included here. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/media/i2c/max96714.c | 2 +- > drivers/media/i2c/max96717.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/i2c/max96714.c b/drivers/media/i2c/max96714.c > index 159753b13777..3cc1b1ae47d1 100644 > --- a/drivers/media/i2c/max96714.c > +++ b/drivers/media/i2c/max96714.c > @@ -7,11 +7,11 @@ > > #include <linux/bitfield.h> > #include <linux/bitops.h> > -#include <linux/fwnode.h> > #include <linux/gpio/consumer.h> > #include <linux/i2c.h> > #include <linux/i2c-mux.h> > #include <linux/module.h> > +#include <linux/property.h> > #include <linux/regmap.h> > #include <linux/regulator/consumer.h> > > diff --git a/drivers/media/i2c/max96717.c b/drivers/media/i2c/max96717.c > index 30c5ca0e817a..23fb7e67d1a4 100644 > --- a/drivers/media/i2c/max96717.c > +++ b/drivers/media/i2c/max96717.c > @@ -9,10 +9,10 @@ > #include <linux/clk.h> > #include <linux/clk-provider.h> > #include <linux/delay.h> > -#include <linux/fwnode.h> > #include <linux/gpio/driver.h> > #include <linux/i2c-mux.h> > #include <linux/i2c.h> > +#include <linux/property.h> > #include <linux/regmap.h> > > #include <media/v4l2-cci.h> > Reviewed-by: Julien Massot <julien.massot@collabora.com> Julien
diff --git a/drivers/media/i2c/max96714.c b/drivers/media/i2c/max96714.c index 159753b13777..3cc1b1ae47d1 100644 --- a/drivers/media/i2c/max96714.c +++ b/drivers/media/i2c/max96714.c @@ -7,11 +7,11 @@ #include <linux/bitfield.h> #include <linux/bitops.h> -#include <linux/fwnode.h> #include <linux/gpio/consumer.h> #include <linux/i2c.h> #include <linux/i2c-mux.h> #include <linux/module.h> +#include <linux/property.h> #include <linux/regmap.h> #include <linux/regulator/consumer.h> diff --git a/drivers/media/i2c/max96717.c b/drivers/media/i2c/max96717.c index 30c5ca0e817a..23fb7e67d1a4 100644 --- a/drivers/media/i2c/max96717.c +++ b/drivers/media/i2c/max96717.c @@ -9,10 +9,10 @@ #include <linux/clk.h> #include <linux/clk-provider.h> #include <linux/delay.h> -#include <linux/fwnode.h> #include <linux/gpio/driver.h> #include <linux/i2c-mux.h> #include <linux/i2c.h> +#include <linux/property.h> #include <linux/regmap.h> #include <media/v4l2-cci.h>
The fwnode.h is not supposed to be used by the drivers as it has the definitions for the core parts for different device property provider implementations. Drop it. Note, that fwnode API for drivers is provided in property.h which is included here. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/media/i2c/max96714.c | 2 +- drivers/media/i2c/max96717.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)