[1/5] ARM: dts: qcom: apq8064: Add missing scm clock

Message ID 20161221114939.19973-1-bjorn.andersson@linaro.org
State New
Headers show

Commit Message

Bjorn Andersson Dec. 21, 2016, 11:49 a.m.
As per the device tree binding the apq8064 scm node requires the core
clock to be specified, so add this.

Cc: John Stultz <john.stultz@linaro.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

---
 arch/arm/boot/dts/qcom-apq8064.dtsi | 3 +++
 1 file changed, 3 insertions(+)

-- 
2.11.0

--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Andy Gross Dec. 29, 2016, 3:14 a.m. | #1
On Wed, Dec 21, 2016 at 03:49:35AM -0800, Bjorn Andersson wrote:
> As per the device tree binding the apq8064 scm node requires the core

> clock to be specified, so add this.

> 

> Cc: John Stultz <john.stultz@linaro.org>

> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> ---

>  arch/arm/boot/dts/qcom-apq8064.dtsi | 3 +++

>  1 file changed, 3 insertions(+)

> 

> diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi

> index 268bd470c865..78bf155a52f3 100644

> --- a/arch/arm/boot/dts/qcom-apq8064.dtsi

> +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi

> @@ -303,6 +303,9 @@

>  	firmware {

>  		scm {

>  			compatible = "qcom,scm-apq8064";

> +

> +			clocks = <&gcc CE3_CORE_CLK>;

> +			clock-names = "core";


Isn't this supposed to be the DFAB clk?  The RPM one?  I think that's why we let
the clock just fall through optionally before the recent changes that broke
this.

Regards,

Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
John Stultz Jan. 7, 2017, 1:07 a.m. | #2
On Wed, Dec 21, 2016 at 3:49 AM, Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
> Add nodes for the Riva PIL, IRIS RF module, BT and WiFI services exposed

> by the Riva firmware and the related memory reserve.

>

> Also provides pinctrl nodes for devices enabling the riva-pil.

>

> Cc: John Stultz <john.stultz@linaro.org>

> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>


Tested-by: John Stultz <john.stultz@linaro.org>


thanks
-john
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch hide | download patch | download mbox

diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi
index 268bd470c865..78bf155a52f3 100644
--- a/arch/arm/boot/dts/qcom-apq8064.dtsi
+++ b/arch/arm/boot/dts/qcom-apq8064.dtsi
@@ -303,6 +303,9 @@ 
 	firmware {
 		scm {
 			compatible = "qcom,scm-apq8064";
+
+			clocks = <&gcc CE3_CORE_CLK>;
+			clock-names = "core";
 		};
 	};