From patchwork Thu Dec 29 23:27:26 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Gross X-Patchwork-Id: 89293 Delivered-To: patch@linaro.org Received: by 10.140.20.101 with SMTP id 92csp6207872qgi; Thu, 29 Dec 2016 15:27:57 -0800 (PST) X-Received: by 10.84.210.233 with SMTP id a96mr93502865pli.118.1483054077292; Thu, 29 Dec 2016 15:27:57 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 33si54965685plt.66.2016.12.29.15.27.56; Thu, 29 Dec 2016 15:27:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753396AbcL2X1t (ORCPT + 25 others); Thu, 29 Dec 2016 18:27:49 -0500 Received: from mail-oi0-f45.google.com ([209.85.218.45]:33254 "EHLO mail-oi0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753334AbcL2X1g (ORCPT ); Thu, 29 Dec 2016 18:27:36 -0500 Received: by mail-oi0-f45.google.com with SMTP id 128so215752281oig.0 for ; Thu, 29 Dec 2016 15:27:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Q01SEgpWz3aVhdZDw9PK2F1PR8ZxZ7TnZ+Rzq58FWxY=; b=eXse6zMJtuy7fMnK91GR4Eee5/axhCo8kn1HOzp0CXHdqGHnj5Wu8LD9rQ6V6Xwluo Y28l1xCPjKmD1hku3a6HDdEISNar4gYouEZlodkZjHhrbCi3GuNCLUVwWDQuXzj9L3sy 9+RbU9gFUnrccPzc3kqLyFgt61oiwJPw48aiI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Q01SEgpWz3aVhdZDw9PK2F1PR8ZxZ7TnZ+Rzq58FWxY=; b=ZuFY1pBoqhlwLpzFyihdeVYvO0FgXt1HwXBnDE/fb6MfRzzCnLqJq/F/PTS4n3eVOy gDFFOExXFI+MzbaRO3HEBhrahEfY27vXfTV5n7tWjzK1x1e8dsvUn6qqSBFHZIbR4GL/ Zv83/Td8NJYxysEPYOI2IsKXtmzJ7Bu5CY3Brx3i8Bbba++LhLcE+GveI9d2cENmKGHV TDaAVLM8gQ/MFefd1xf0I3vRH7/p08OTDYBr+EbWtyNxr6HbMLRmKIvsPUIxX7S66/f2 4+HENB08nkZLn66CMw41kYQVIPqqqlk+RjJx4l9o1aWaZX33IT4kni72AQDlZxKkQTid fGJQ== X-Gm-Message-State: AIkVDXJYePIb3C7Q+OJeMq5S6i8okcZfAtwFnBWc5hLY9kkImDY7t9mZLUahcfkiV40BSJJ4 X-Received: by 10.157.38.189 with SMTP id l58mr14589223otb.114.1483054055242; Thu, 29 Dec 2016 15:27:35 -0800 (PST) Received: from localhost ([2602:306:3406:6500:1902:d2c:340d:eaac]) by smtp.gmail.com with ESMTPSA id 90sm25899889otw.15.2016.12.29.15.27.34 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 29 Dec 2016 15:27:34 -0800 (PST) From: Andy Gross To: linux-kernel@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, will.deacon@arm.com, lorenzo.pieralisi@arm.com, Kevin Hilman , Srinivas Kandagatla , Bjorn Andersson , linux@armlinux.org.uk, Andy Gross Subject: [Patch v2 2/2] firmware: qcom: scm: Fix interrupted SCM calls Date: Thu, 29 Dec 2016 17:27:26 -0600 Message-Id: <1483054046-3327-3-git-send-email-andy.gross@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1483054046-3327-1-git-send-email-andy.gross@linaro.org> References: <1483054046-3327-1-git-send-email-andy.gross@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch adds a Qualcomm specific quirk to the arm_smccc_smc call. On Qualcomm ARM64 platforms, the SMC call can return before it has completed. If this occurs, the call can be restarted, but it requires using the returned session ID value from the interrupted SMC call. The quirk stores off the session ID from the interrupted call in the quirk structure so that it can be used by the caller. This patch folds in a fix given by Sricharan R: https://lkml.org/lkml/2016/9/28/272 Signed-off-by: Andy Gross --- arch/arm64/kernel/smccc-call.S | 9 ++++++++- drivers/firmware/qcom_scm-64.c | 13 ++++++++++--- include/linux/arm-smccc.h | 11 ++++++++--- 3 files changed, 26 insertions(+), 7 deletions(-) -- 1.9.1 Reviewed-by: Will Deacon diff --git a/arch/arm64/kernel/smccc-call.S b/arch/arm64/kernel/smccc-call.S index 6290696..72ecdca 100644 --- a/arch/arm64/kernel/smccc-call.S +++ b/arch/arm64/kernel/smccc-call.S @@ -12,6 +12,7 @@ * */ #include +#include #include .macro SMCCC instr @@ -20,7 +21,13 @@ ldr x4, [sp] stp x0, x1, [x4, #ARM_SMCCC_RES_X0_OFFS] stp x2, x3, [x4, #ARM_SMCCC_RES_X2_OFFS] - ret + ldr x4, [sp, #8] + cbz x4, 1f /* no quirk structure */ + ldr x9, [x4, #ARM_SMCCC_QUIRK_ID_OFFS] + cmp x9, #ARM_SMCCC_QUIRK_QCOM_A6 + b.ne 1f + str x6, [x4, ARM_SMCCC_QUIRK_STATE_OFFS] +1: ret .cfi_endproc .endm diff --git a/drivers/firmware/qcom_scm-64.c b/drivers/firmware/qcom_scm-64.c index 4a0f5ea..1e2e519 100644 --- a/drivers/firmware/qcom_scm-64.c +++ b/drivers/firmware/qcom_scm-64.c @@ -91,6 +91,7 @@ static int qcom_scm_call(struct device *dev, u32 svc_id, u32 cmd_id, dma_addr_t args_phys = 0; void *args_virt = NULL; size_t alloc_len; + struct arm_smccc_quirk quirk = {.id = ARM_SMCCC_QUIRK_QCOM_A6}; if (unlikely(arglen > N_REGISTER_ARGS)) { alloc_len = N_EXT_QCOM_SCM_ARGS * sizeof(u64); @@ -131,10 +132,16 @@ static int qcom_scm_call(struct device *dev, u32 svc_id, u32 cmd_id, qcom_smccc_convention, ARM_SMCCC_OWNER_SIP, fn_id); + quirk.state.a6 = 0; + do { - arm_smccc_smc(cmd, desc->arginfo, desc->args[0], - desc->args[1], desc->args[2], x5, 0, 0, - res); + arm_smccc_smc_quirk(cmd, desc->arginfo, desc->args[0], + desc->args[1], desc->args[2], x5, + quirk.state.a6, 0, res, &quirk); + + if (res->a0 == QCOM_SCM_INTERRUPTED) + cmd = res->a0; + } while (res->a0 == QCOM_SCM_INTERRUPTED); mutex_unlock(&qcom_scm_lock); diff --git a/include/linux/arm-smccc.h b/include/linux/arm-smccc.h index cde4f1f..64d0454 100644 --- a/include/linux/arm-smccc.h +++ b/include/linux/arm-smccc.h @@ -14,9 +14,6 @@ #ifndef __LINUX_ARM_SMCCC_H #define __LINUX_ARM_SMCCC_H -#include -#include - /* * This file provides common defines for ARM SMC Calling Convention as * specified in @@ -60,6 +57,13 @@ #define ARM_SMCCC_OWNER_TRUSTED_OS 50 #define ARM_SMCCC_OWNER_TRUSTED_OS_END 63 +#define ARM_SMCCC_QUIRK_NONE 0 +#define ARM_SMCCC_QUIRK_QCOM_A6 1 /* Save/restore register a6 */ + +#ifndef __ASSEMBLY__ + +#include +#include /** * struct arm_smccc_res - Result from SMC/HVC call * @a0-a3 result values from registers 0 to 3 @@ -121,4 +125,5 @@ asmlinkage void arm_smccc_hvc(unsigned long a0, unsigned long a1, #define arm_smccc_smc_quirk(a0, a1, a2, a3, a4, a5, a6, a7, res, quirk) \ __arm_smccc_smc(a0, a1, a2, a3, a4, a5, a6, a7, res, quirk) +#endif /*__ASSEMBLY__*/ #endif /*__LINUX_ARM_SMCCC_H*/