[01/21] sh: sh7724: Don't use a public mmc header for MMC_PROGRESS*

Message ID 1483102054-1752-2-git-send-email-ulf.hansson@linaro.org
State New
Headers show

Commit Message

Ulf Hansson Dec. 30, 2016, 12:47 p.m.
The enum that specifies the MMC_PROGRESS* types, is a sh mmcif specific
thing and has no relevance in a public mmc header. Currently it's used only
by the sh romImage MMCIF boot, so let's instead define the enum in there
and rename the types to MMCIF_* to show this.

Cc: linux-sh@vger.kernel.org
Cc: Simon Horman <horms@verge.net.au>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: Rich Felker <dalias@libc.org>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

---
 arch/sh/boot/romimage/mmcif-sh7724.c | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

-- 
1.9.1

Comments

Simon Horman Jan. 3, 2017, 9:24 a.m. | #1
On Fri, Dec 30, 2016 at 01:47:14PM +0100, Ulf Hansson wrote:
> The enum that specifies the MMC_PROGRESS* types, is a sh mmcif specific

> thing and has no relevance in a public mmc header. Currently it's used only

> by the sh romImage MMCIF boot, so let's instead define the enum in there

> and rename the types to MMCIF_* to show this.

> 

> Cc: linux-sh@vger.kernel.org

> Cc: Simon Horman <horms@verge.net.au>

> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>

> Cc: Rich Felker <dalias@libc.org>

> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>


Reviewed-by: Simon Horman <horms+renesas@verge.net.au>


I assume there is also a patch to remove the enum from
include/linux/mmc/boot.h
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Linus Walleij Jan. 9, 2017, 3 p.m. | #2
On Fri, Dec 30, 2016 at 1:47 PM, Ulf Hansson <ulf.hansson@linaro.org> wrote:

> The enum that specifies the MMC_PROGRESS* types, is a sh mmcif specific

> thing and has no relevance in a public mmc header. Currently it's used only

> by the sh romImage MMCIF boot, so let's instead define the enum in there

> and rename the types to MMCIF_* to show this.

>

> Cc: linux-sh@vger.kernel.org

> Cc: Simon Horman <horms@verge.net.au>

> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>

> Cc: Rich Felker <dalias@libc.org>

> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>


As Simon notices: this also needs to delete <linux/mmc/boot.h>.

With that:
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>


Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ulf Hansson Jan. 10, 2017, 3:28 p.m. | #3
On 9 January 2017 at 16:00, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Fri, Dec 30, 2016 at 1:47 PM, Ulf Hansson <ulf.hansson@linaro.org> wrote:

>

>> The enum that specifies the MMC_PROGRESS* types, is a sh mmcif specific

>> thing and has no relevance in a public mmc header. Currently it's used only

>> by the sh romImage MMCIF boot, so let's instead define the enum in there

>> and rename the types to MMCIF_* to show this.

>>

>> Cc: linux-sh@vger.kernel.org

>> Cc: Simon Horman <horms@verge.net.au>

>> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>

>> Cc: Rich Felker <dalias@libc.org>

>> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

>

> As Simon notices: this also needs to delete <linux/mmc/boot.h>.


Yes, it's done as change on top of this one.

https://patchwork.kernel.org/patch/9492077/

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/arch/sh/boot/romimage/mmcif-sh7724.c b/arch/sh/boot/romimage/mmcif-sh7724.c
index 16b1225..6595b6b4 100644
--- a/arch/sh/boot/romimage/mmcif-sh7724.c
+++ b/arch/sh/boot/romimage/mmcif-sh7724.c
@@ -9,7 +9,6 @@ 
  */
 
 #include <linux/mmc/sh_mmcif.h>
-#include <linux/mmc/boot.h>
 #include <mach/romimage.h>
 
 #define MMCIF_BASE      (void __iomem *)0xa4ca0000
@@ -22,6 +21,13 @@ 
 #define HIZCRC		0xa405015c
 #define DRVCRA		0xa405018a
 
+enum {
+	MMCIF_PROGRESS_ENTER,
+	MMCIF_PROGRESS_INIT,
+	MMCIF_PROGRESS_LOAD,
+	MMCIF_PROGRESS_DONE
+};
+
 /* SH7724 specific MMCIF loader
  *
  * loads the romImage from an MMC card starting from block 512
@@ -30,7 +36,7 @@ 
  */
 asmlinkage void mmcif_loader(unsigned char *buf, unsigned long no_bytes)
 {
-	mmcif_update_progress(MMC_PROGRESS_ENTER);
+	mmcif_update_progress(MMCIF_PROGRESS_ENTER);
 
 	/* enable clock to the MMCIF hardware block */
 	__raw_writel(__raw_readl(MSTPCR2) & ~0x20000000, MSTPCR2);
@@ -53,12 +59,12 @@  asmlinkage void mmcif_loader(unsigned char *buf, unsigned long no_bytes)
 	/* high drive capability for MMC pins */
 	__raw_writew(__raw_readw(DRVCRA) | 0x3000, DRVCRA);
 
-	mmcif_update_progress(MMC_PROGRESS_INIT);
+	mmcif_update_progress(MMCIF_PROGRESS_INIT);
 
 	/* setup MMCIF hardware */
 	sh_mmcif_boot_init(MMCIF_BASE);
 
-	mmcif_update_progress(MMC_PROGRESS_LOAD);
+	mmcif_update_progress(MMCIF_PROGRESS_LOAD);
 
 	/* load kernel via MMCIF interface */
 	sh_mmcif_boot_do_read(MMCIF_BASE, 512,
@@ -68,5 +74,5 @@  asmlinkage void mmcif_loader(unsigned char *buf, unsigned long no_bytes)
 	/* disable clock to the MMCIF hardware block */
 	__raw_writel(__raw_readl(MSTPCR2) | 0x20000000, MSTPCR2);
 
-	mmcif_update_progress(MMC_PROGRESS_DONE);
+	mmcif_update_progress(MMCIF_PROGRESS_DONE);
 }