[Linaro-uefi,linaro-uefi,v2,1/4] Platforms/ARM/VExpress: Size DRAM to accommodate Standalone MM image

Message ID 1483545044-21489-2-git-send-email-achin.gupta@arm.com
State New
Headers show

Commit Message

Achin Gupta Jan. 4, 2017, 3:50 p.m.
From: Achin Gupta <achin.gupta@arm.com>

This patch reduces the size of the DRAM available to UEFI so that the freed
memory can be used to load the Standalone MM image in the secure world.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Achin Gupta <achin.gupta@arm.com>
---
 Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Ryan Harkin Jan. 4, 2017, 5:18 p.m. | #1
Hi Achin,

On 4 January 2017 at 15:50,  <achin.gupta@arm.com> wrote:
> From: Achin Gupta <achin.gupta@arm.com>
>
> This patch reduces the size of the DRAM available to UEFI so that the freed
> memory can be used to load the Standalone MM image in the secure world.

What is "MM"?

>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Achin Gupta <achin.gupta@arm.com>
> ---
>  Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc b/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc
> index cf4b803..82acd87 100644
> --- a/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc
> +++ b/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc
> @@ -108,8 +108,13 @@
>    gArmPlatformTokenSpaceGuid.PcdCPUCoreSecondaryStackSize|0x0
>
>    # System Memory (2GB - 16MB of Trusted DRAM at the top of the 32bit address space)
> +
>    gArmTokenSpaceGuid.PcdSystemMemoryBase|0x80000000
> +!if $(ARM_STANDALONE_MM_ENABLE) == FALSE

Why did you not make it check for the new flag being set and
defaulting to the new behaviour if the platform hasn't set it to
false, rather than change the behaviour only if the platform
specifically enabled the new feature?

>    gArmTokenSpaceGuid.PcdSystemMemorySize|0x7F000000
> +!else
> +  gArmTokenSpaceGuid.PcdSystemMemorySize|0x74000000
> +!endif
>
>    # Size of the region used by UEFI in permanent memory (Reserved 64MB)
>    gArmPlatformTokenSpaceGuid.PcdSystemMemoryUefiRegionSize|0x04000000
> --
> 1.9.1
>
> _______________________________________________
> Linaro-uefi mailing list
> Linaro-uefi@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/linaro-uefi

Patch hide | download patch | download mbox

diff --git a/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc b/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc
index cf4b803..82acd87 100644
--- a/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc
+++ b/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc
@@ -108,8 +108,13 @@ 
   gArmPlatformTokenSpaceGuid.PcdCPUCoreSecondaryStackSize|0x0
 
   # System Memory (2GB - 16MB of Trusted DRAM at the top of the 32bit address space)
+
   gArmTokenSpaceGuid.PcdSystemMemoryBase|0x80000000
+!if $(ARM_STANDALONE_MM_ENABLE) == FALSE
   gArmTokenSpaceGuid.PcdSystemMemorySize|0x7F000000
+!else
+  gArmTokenSpaceGuid.PcdSystemMemorySize|0x74000000
+!endif
 
   # Size of the region used by UEFI in permanent memory (Reserved 64MB)
   gArmPlatformTokenSpaceGuid.PcdSystemMemoryUefiRegionSize|0x04000000