i2c: print correct device invalid address

Message ID 1483700577-60130-1-git-send-email-john.garry@huawei.com
State New
Headers show

Commit Message

John Garry Jan. 6, 2017, 11:02 a.m.
In of_i2c_register_device(), when the check for
device address validity fails we print the info.addr,
which has not been assigned properly.

Fix this by printing the actual invalid address.

Signed-off-by: John Garry <john.garry@huawei.com>


-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Vladimir Zapolskiy Jan. 7, 2017, 9:43 p.m. | #1
On 01/06/2017 01:02 PM, John Garry wrote:
> In of_i2c_register_device(), when the check for

> device address validity fails we print the info.addr,

> which has not been assigned properly.

> 

> Fix this by printing the actual invalid address.

> 

> Signed-off-by: John Garry <john.garry@huawei.com>

> 

> diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c

> index cf9e396..03cfcdd 100644

> --- a/drivers/i2c/i2c-core.c

> +++ b/drivers/i2c/i2c-core.c

> @@ -1708,7 +1708,7 @@ static struct i2c_client *of_i2c_register_device(struct i2c_adapter *adap,

>  

>  	if (i2c_check_addr_validity(addr, info.flags)) {

>  		dev_err(&adap->dev, "of_i2c: invalid addr=%x on %s\n",

> -			info.addr, node->full_name);

> +			addr, node->full_name);

>  		return ERR_PTR(-EINVAL);

>  	}

>  

> 


Reviewed-by: Vladimir Zapolskiy <vz@mleia.com>

Fixes: b4e2f6ac1281 ("i2c: apply DT flags when probing")

Thank you for the fix.

--
With best wishes,
Vladimir
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Wolfram Sang Jan. 12, 2017, 7:07 p.m. | #2
On Fri, Jan 06, 2017 at 07:02:57PM +0800, John Garry wrote:
> In of_i2c_register_device(), when the check for

> device address validity fails we print the info.addr,

> which has not been assigned properly.

> 

> Fix this by printing the actual invalid address.

> 

> Signed-off-by: John Garry <john.garry@huawei.com>


Applied to for-current, thanks!

--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch hide | download patch | download mbox

diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index cf9e396..03cfcdd 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -1708,7 +1708,7 @@  static struct i2c_client *of_i2c_register_device(struct i2c_adapter *adap,
 
 	if (i2c_check_addr_validity(addr, info.flags)) {
 		dev_err(&adap->dev, "of_i2c: invalid addr=%x on %s\n",
-			info.addr, node->full_name);
+			addr, node->full_name);
 		return ERR_PTR(-EINVAL);
 	}