From patchwork Sun Jan 8 16:41:00 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Khoronzhuk X-Patchwork-Id: 90316 Delivered-To: patch@linaro.org Received: by 10.140.20.101 with SMTP id 92csp512371qgi; Sun, 8 Jan 2017 08:42:31 -0800 (PST) X-Received: by 10.98.158.210 with SMTP id f79mr8917898pfk.145.1483893751916; Sun, 08 Jan 2017 08:42:31 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h187si2129288pfe.95.2017.01.08.08.42.31; Sun, 08 Jan 2017 08:42:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753938AbdAHQmT (ORCPT + 5 others); Sun, 8 Jan 2017 11:42:19 -0500 Received: from mail-lf0-f42.google.com ([209.85.215.42]:33759 "EHLO mail-lf0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753863AbdAHQlJ (ORCPT ); Sun, 8 Jan 2017 11:41:09 -0500 Received: by mail-lf0-f42.google.com with SMTP id k86so81784150lfi.0 for ; Sun, 08 Jan 2017 08:41:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=kvpjoIqNhs8d0SQF7sSoTDwEZHDfRvL8uXO1rKuVxzg=; b=iJU91DWi0kOPD9eWU4v2+bIwdUhksBUkqpNGY4fbS03b6hXt34jw2O6KDe9Yznv3HA cUvy4vvWwl5xaUP9T1laixaNDdLZYB8pFTLhqakCc+aY7vgyvCrv0lwJZkbeTUG9HlBJ ANiL+zmjQd42tvfDl5FMZAd3g3Pml5B+a5dv4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=kvpjoIqNhs8d0SQF7sSoTDwEZHDfRvL8uXO1rKuVxzg=; b=Z+/GqW4qNmYB2KYjs9mZ3vjpSuZD21Zm2RnGy8q35V3KB+EC5LN4gtSJ6oIbAj4/D2 fomKPrwPn/Euye2lA+HR/83EmJO3o+DF5+nrj1CgxVJMLSTry1av2GAjPZe8TVUHAefQ 82YHcLVKMgV1cLy2FsuEXfQU53w26aIz4jLwK1JFPhvGza8VnYx+8QRXjjjVCdqgY1qm YbD/G1Prp3X1zP4zHBNz/v5qBhhrbEqyCJu8SnMa/98SP8okZDRM4sjFv/gs+Pc1gGgY xg9FkNJZrBql5Mp4VTcgu7+SOV6z5mqCqihYNmmnBtMsdKzzS5so4qSMvYtiHkgNyxzh KmWQ== X-Gm-Message-State: AIkVDXKk8PoEZ4rwxgXh5HTqKtQSY9Cf+73GAmAid5M0E2rOMd4Ei1C09EMaxRhNFG7tp4J+ X-Received: by 10.46.71.204 with SMTP id u195mr6322267lja.71.1483893668251; Sun, 08 Jan 2017 08:41:08 -0800 (PST) Received: from localhost.localdomain (183-224-132-95.pool.ukrtel.net. [95.132.224.183]) by smtp.gmail.com with ESMTPSA id c77sm20196895lfg.29.2017.01.08.08.41.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 08 Jan 2017 08:41:07 -0800 (PST) From: Ivan Khoronzhuk To: netdev@vger.kernel.org, mugunthanvnm@ti.com Cc: linux-omap@vger.kernel.org, grygorii.strashko@ti.com, linux-kernel@vger.kernel.org, Ivan Khoronzhuk Subject: [PATCH 1/4] net: ethernet: ti: cpsw: remove dual check from common res usage function Date: Sun, 8 Jan 2017 18:41:00 +0200 Message-Id: <1483893663-15673-2-git-send-email-ivan.khoronzhuk@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1483893663-15673-1-git-send-email-ivan.khoronzhuk@linaro.org> References: <1483893663-15673-1-git-send-email-ivan.khoronzhuk@linaro.org> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Common res usage is possible only in case an interface is running. In case of not dual emac here can be only one interface, so while ndo_open and switch mode, only one interface can be opened, thus if open is called no any interface is running ... and no common res are used. So remove check on dual emac, it will simplify code/understanding and will match the name it's called. Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/cpsw.c | 3 --- 1 file changed, 3 deletions(-) -- 2.7.4 diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index f339268..d261024 100644 --- a/drivers/net/ethernet/ti/cpsw.c +++ b/drivers/net/ethernet/ti/cpsw.c @@ -1240,9 +1240,6 @@ static int cpsw_common_res_usage_state(struct cpsw_common *cpsw) u32 i; u32 usage_count = 0; - if (!cpsw->data.dual_emac) - return 0; - for (i = 0; i < cpsw->data.slaves; i++) if (cpsw->slaves[i].open_stat) usage_count++;