diff mbox

hw/display/framebuffer.c: Avoid overflow for framebuffers > 4GB

Message ID 1483980309-30821-1-git-send-email-peter.maydell@linaro.org
State Accepted
Commit ba56e4cad41ea2b2fb68d18a632ebc7d4e4b1051
Headers show

Commit Message

Peter Maydell Jan. 9, 2017, 4:45 p.m. UTC 
Coverity points out that calculating src_len by multiplying
src_width by rows could overflow. This can only happen in
the implausible case of a framebuffer larger than 4GB, but
we may as well fix it, placating Coverity. (CID1005515)

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

---
 hw/display/framebuffer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.7.4
diff mbox

Patch

diff --git a/hw/display/framebuffer.c b/hw/display/framebuffer.c
index df51358..25aa46c 100644
--- a/hw/display/framebuffer.c
+++ b/hw/display/framebuffer.c
@@ -78,7 +78,7 @@  void framebuffer_update_display(
 
     i = *first_row;
     *first_row = -1;
-    src_len = src_width * rows;
+    src_len = (hwaddr)src_width * rows;
 
     mem = mem_section->mr;
     if (!mem) {